letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Browse Source 
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/components/reminders/reminder-card.tsx
View File

@@ -136,7 +136,7 @@ export function ReminderCard({
onClick={(e) => e.stopPropagation()}
aria-label={`Actions for reminder: ${reminder.title}`}
>
<MoreHorizontal className="h-4 w-4" />
<MoreHorizontal className="h-4 w-4" aria-hidden />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
@@ -146,7 +146,7 @@ export function ReminderCard({
onComplete(reminder.id);
}}
>
<CheckCircle2 className="mr-2 h-3.5 w-3.5 text-green-600" />
<CheckCircle2 className="mr-2 h-3.5 w-3.5 text-green-600" aria-hidden />
Complete
</DropdownMenuItem>
<DropdownMenuItem
@@ -155,7 +155,7 @@ export function ReminderCard({
onSnooze(reminder.id);
}}
>
<Clock className="mr-2 h-3.5 w-3.5" />
<Clock className="mr-2 h-3.5 w-3.5" aria-hidden />
Snooze
</DropdownMenuItem>
<DropdownMenuItem
@@ -164,7 +164,7 @@ export function ReminderCard({
onEdit(reminder);
}}
>
<Bell className="mr-2 h-3.5 w-3.5" />
<Bell className="mr-2 h-3.5 w-3.5" aria-hidden />
Edit
</DropdownMenuItem>
<DropdownMenuItem
@@ -174,7 +174,7 @@ export function ReminderCard({
onDismiss(reminder.id);
}}
>
<XCircle className="mr-2 h-3.5 w-3.5" />
<XCircle className="mr-2 h-3.5 w-3.5" aria-hidden />
Dismiss
</DropdownMenuItem>
</DropdownMenuContent>
@@ -183,7 +183,7 @@ export function ReminderCard({
}
>
<div className="flex items-start gap-3">
<ListCardAvatar icon={<Bell className="h-5 w-5" />} />
<ListCardAvatar icon={<Bell className="h-5 w-5" aria-hidden />} />
<div className="min-w-0 flex-1">
{/* Title row + spacer for actions button */}
<div className="flex items-start justify-between gap-2">

18
src/components/reminders/reminder-list.tsx
View File

@@ -153,7 +153,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
Auto
</Badge>
)}
{overdue && <AlertTriangle className="h-3.5 w-3.5 text-destructive" />}
{overdue && <AlertTriangle className="h-3.5 w-3.5 text-destructive" aria-hidden />}
</div>
{row.original.client && (
<span className="text-xs text-muted-foreground">
@@ -193,7 +193,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
const Icon = config.icon;
return (
<div className="flex items-center gap-1.5 text-sm">
<Icon className="h-3.5 w-3.5" />
<Icon className="h-3.5 w-3.5" aria-hidden />
{config.label}
</div>
);
@@ -218,7 +218,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
className="text-green-600 hover:text-green-700"
onClick={() => handleComplete(row.original.id)}
>
<CheckCircle2 className="h-4 w-4" />
<CheckCircle2 className="h-4 w-4" aria-hidden />
</Button>
</TooltipTrigger>
<TooltipContent>Mark complete</TooltipContent>
@@ -231,7 +231,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
aria-label="Snooze"
onClick={() => setSnoozingId(row.original.id)}
>
<Clock className="h-4 w-4" />
<Clock className="h-4 w-4" aria-hidden />
</Button>
</TooltipTrigger>
<TooltipContent>Snooze</TooltipContent>
@@ -248,7 +248,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
setFormOpen(true);
}}
>
<Pencil className="h-4 w-4" />
<Pencil className="h-4 w-4" aria-hidden />
</Button>
</TooltipTrigger>
<TooltipContent>Edit</TooltipContent>
@@ -262,7 +262,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
className="text-muted-foreground hover:text-foreground"
onClick={() => handleDismiss(row.original.id)}
>
<XCircle className="h-4 w-4" />
<XCircle className="h-4 w-4" aria-hidden />
</Button>
</TooltipTrigger>
<TooltipContent>Dismiss</TooltipContent>
@@ -289,7 +289,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
setFormOpen(true);
}}
>
<Plus className="mr-1.5 h-4 w-4" />
<Plus className="mr-1.5 h-4 w-4" aria-hidden />
New Reminder
</Button>
}
@@ -303,7 +303,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
setFormOpen(true);
}}
>
<Plus className="mr-1.5 h-4 w-4" />
<Plus className="mr-1.5 h-4 w-4" aria-hidden />
New Reminder
</Button>
</div>
@@ -371,7 +371,7 @@ export function ReminderList({ embedded = false }: ReminderListProps = {}) {
)}
emptyState={
<div className="text-center py-8">
<Bell className="mx-auto h-8 w-8 text-muted-foreground mb-2" />
<Bell className="mx-auto h-8 w-8 text-muted-foreground mb-2" aria-hidden />
<p className="text-muted-foreground">No reminders.</p>
<Button
variant="link"