fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -91,7 +91,7 @@ export function UserMenu({ trigger, align = 'end', user, ports }: UserMenuProps)
regardless of how many ports the operator has access to. */}
<DropdownMenuSub>
<DropdownMenuSubTrigger>
<Building2 className="w-4 h-4 mr-2" />
<Building2 className="w-4 h-4 mr-2" aria-hidden />
Switch port
</DropdownMenuSubTrigger>
<DropdownMenuSubContent className="w-56">
@@ -116,31 +116,31 @@ export function UserMenu({ trigger, align = 'end', user, ports }: UserMenuProps)
{/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
<DropdownMenuItem onClick={() => router.push(`${base}/settings/profile` as any)}>
<User className="w-4 h-4 mr-2" />
<User className="w-4 h-4 mr-2" aria-hidden />
Profile
</DropdownMenuItem>
{/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
<DropdownMenuItem onClick={() => router.push(`${base}/settings` as any)}>
<Settings className="w-4 h-4 mr-2" />
<Settings className="w-4 h-4 mr-2" aria-hidden />
Settings
</DropdownMenuItem>
<DropdownMenuItem
// eslint-disable-next-line @typescript-eslint/no-explicit-any
onClick={() => router.push(`${base}/settings#notifications` as any)}
>
<Bell className="w-4 h-4 mr-2" />
<Bell className="w-4 h-4 mr-2" aria-hidden />
Notification preferences
</DropdownMenuItem>
<DropdownMenuSeparator />
<DropdownMenuItem onClick={handleToggleDarkMode}>
{darkMode ? (
<>
<Sun className="w-4 h-4 mr-2" />
<Sun className="w-4 h-4 mr-2" aria-hidden />
Light Mode
</>
) : (
<>
<Moon className="w-4 h-4 mr-2" />
<Moon className="w-4 h-4 mr-2" aria-hidden />
Dark Mode
</>
)}
@@ -150,7 +150,7 @@ export function UserMenu({ trigger, align = 'end', user, ports }: UserMenuProps)
className="text-destructive focus:text-destructive"
onClick={() => router.push('/api/auth/sign-out')}
>
<LogOut className="w-4 h-4 mr-2" />
<LogOut className="w-4 h-4 mr-2" aria-hidden />
Sign Out
</DropdownMenuItem>
</DropdownMenuContent>