letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Browse Source 
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/layout/breadcrumbs.tsx
View File

@@ -123,7 +123,7 @@ export function Breadcrumbs() {
</BreadcrumbItem>
{!crumb.isLast && (
<BreadcrumbSeparator className="text-muted-foreground/40">
<ChevronRight className="w-3 h-3" />
<ChevronRight className="w-3 h-3" aria-hidden />
</BreadcrumbSeparator>
)}
</Fragment>

2
src/components/layout/inbox.tsx
View File

@@ -123,7 +123,7 @@ export function Inbox() {
aria-label={`Inbox${combined > 0 ? ` (${combined} unread)` : ''}`}
data-testid="inbox-bell"
>
<InboxIcon className="h-5 w-5" />
<InboxIcon className="h-5 w-5" aria-hidden />
{combined > 0 ? (
<span
key={combined}

2
src/components/layout/mobile/mobile-topbar.tsx
View File

@@ -54,7 +54,7 @@ export function MobileTopbar() {
'text-white/95 active:bg-white/10 transition-colors',
)}
>
<ChevronLeft className="size-[22px] stroke-[2.25]" />
<ChevronLeft className="size-[22px] stroke-[2.25]" aria-hidden />
</button>
) : (
<div

10
src/components/layout/sidebar.tsx
View File

@@ -304,9 +304,9 @@ function SidebarContent({
)}
>
{collapsed ? (
<ChevronRight className="w-4 h-4" />
<ChevronRight className="w-4 h-4" aria-hidden />
) : (
<ChevronLeft className="w-4 h-4" />
<ChevronLeft className="w-4 h-4" aria-hidden />
)}
</button>
)}
@@ -334,9 +334,9 @@ function SidebarContent({
className="text-slate-400 hover:text-slate-700 transition-colors"
>
{adminExpanded ? (
<ChevronUp className="w-3 h-3" />
<ChevronUp className="w-3 h-3" aria-hidden />
) : (
<ChevronDown className="w-3 h-3" />
<ChevronDown className="w-3 h-3" aria-hidden />
)}
</button>
)}
@@ -355,7 +355,7 @@ function SidebarContent({
))}
</ul>
)}
<Separator className="mt-3 bg-slate-200" />
<Separator className="mt-3 bg-slate-200" aria-hidden />
</div>
);
})}

4
src/components/layout/topbar.tsx
View File

@@ -68,7 +68,7 @@ export function Topbar({ ports, user }: TopbarProps) {
'text-muted-foreground hover:text-foreground hover:bg-accent transition-colors',
)}
>
<ChevronLeft className="h-4 w-4" />
<ChevronLeft className="h-4 w-4" aria-hidden />
</button>
)}
<Breadcrumbs />
@@ -92,7 +92,7 @@ export function Topbar({ ports, user }: TopbarProps) {
size="sm"
className="bg-gradient-brand hover:opacity-90 text-white gap-1.5 shadow-sm transition-all duration-base ease-smooth hover:scale-[1.02]"
>
<Plus className="w-4 h-4" />
<Plus className="w-4 h-4" aria-hidden />
<span className="hidden sm:inline">New</span>
</Button>
</DropdownMenuTrigger>

14
src/components/layout/user-menu.tsx
View File

@@ -91,7 +91,7 @@ export function UserMenu({ trigger, align = 'end', user, ports }: UserMenuProps)
regardless of how many ports the operator has access to. */}
<DropdownMenuSub>
<DropdownMenuSubTrigger>
<Building2 className="w-4 h-4 mr-2" />
<Building2 className="w-4 h-4 mr-2" aria-hidden />
Switch port
</DropdownMenuSubTrigger>
<DropdownMenuSubContent className="w-56">
@@ -116,31 +116,31 @@ export function UserMenu({ trigger, align = 'end', user, ports }: UserMenuProps)
{/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
<DropdownMenuItem onClick={() => router.push(`${base}/settings/profile` as any)}>
<User className="w-4 h-4 mr-2" />
<User className="w-4 h-4 mr-2" aria-hidden />
Profile
</DropdownMenuItem>
{/* eslint-disable-next-line @typescript-eslint/no-explicit-any */}
<DropdownMenuItem onClick={() => router.push(`${base}/settings` as any)}>
<Settings className="w-4 h-4 mr-2" />
<Settings className="w-4 h-4 mr-2" aria-hidden />
Settings
</DropdownMenuItem>
<DropdownMenuItem
// eslint-disable-next-line @typescript-eslint/no-explicit-any
onClick={() => router.push(`${base}/settings#notifications` as any)}
>
<Bell className="w-4 h-4 mr-2" />
<Bell className="w-4 h-4 mr-2" aria-hidden />
Notification preferences
</DropdownMenuItem>
<DropdownMenuSeparator />
<DropdownMenuItem onClick={handleToggleDarkMode}>
{darkMode ? (
<>
<Sun className="w-4 h-4 mr-2" />
<Sun className="w-4 h-4 mr-2" aria-hidden />
Light Mode
</>
) : (
<>
<Moon className="w-4 h-4 mr-2" />
<Moon className="w-4 h-4 mr-2" aria-hidden />
Dark Mode
</>
)}
@@ -150,7 +150,7 @@ export function UserMenu({ trigger, align = 'end', user, ports }: UserMenuProps)
className="text-destructive focus:text-destructive"
onClick={() => router.push('/api/auth/sign-out')}
>
<LogOut className="w-4 h-4 mr-2" />
<LogOut className="w-4 h-4 mr-2" aria-hidden />
Sign Out
</DropdownMenuItem>
</DropdownMenuContent>