letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Browse Source 
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/components/interests/interest-timeline.tsx
View File

@@ -46,17 +46,23 @@ function eventIcon(event: TimelineEvent) {
if (type === 'outcome_set') {
const outcome = (event.metadata as Record<string, unknown>).outcome as string | undefined;
if (outcome === 'won') return <Trophy className="h-4 w-4 text-emerald-600" />;
if (outcome && LOST_OUTCOMES.has(outcome)) return <XCircle className="h-4 w-4 text-rose-600" />;
return <XCircle className="h-4 w-4 text-rose-600" />;
if (outcome === 'won') return <Trophy className="h-4 w-4 text-emerald-600" aria-hidden />;
if (outcome && LOST_OUTCOMES.has(outcome))
return <XCircle className="h-4 w-4 text-rose-600" aria-hidden />;
return <XCircle className="h-4 w-4 text-rose-600" aria-hidden />;
}
if (type === 'outcome_cleared') return <RefreshCcw className="h-4 w-4 text-blue-500" />;
if (event.type === 'document_event') return <FileText className="h-4 w-4 text-sky-600" />;
if (event.action === 'create') return <PlusCircle className="h-4 w-4 text-green-500" />;
if (event.action === 'archive') return <Archive className="h-4 w-4 text-orange-500" />;
if (event.action === 'restore') return <RotateCcw className="h-4 w-4 text-blue-500" />;
if (type === 'stage_change') return <Clock className="h-4 w-4 text-purple-500" />;
return <Pencil className="h-4 w-4 text-muted-foreground" />;
if (type === 'outcome_cleared')
return <RefreshCcw className="h-4 w-4 text-blue-500" aria-hidden />;
if (event.type === 'document_event')
return <FileText className="h-4 w-4 text-sky-600" aria-hidden />;
if (event.action === 'create')
return <PlusCircle className="h-4 w-4 text-green-500" aria-hidden />;
if (event.action === 'archive')
return <Archive className="h-4 w-4 text-orange-500" aria-hidden />;
if (event.action === 'restore')
return <RotateCcw className="h-4 w-4 text-blue-500" aria-hidden />;
if (type === 'stage_change') return <Clock className="h-4 w-4 text-purple-500" aria-hidden />;
return <Pencil className="h-4 w-4 text-muted-foreground" aria-hidden />;
}
function actorLabel(event: TimelineEvent): string | null {
@@ -121,7 +127,7 @@ export function InterestTimeline({ interestId }: InterestTimelineProps) {
{event.description}
{isAuto ? (
<span className="ml-2 inline-flex items-center gap-1 rounded-full bg-muted px-1.5 py-0.5 align-middle text-[10px] font-medium uppercase tracking-wide text-muted-foreground">
<Bot className="h-3 w-3" />
<Bot className="h-3 w-3" aria-hidden />
Auto
</span>
) : null}