fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -340,7 +340,7 @@ function MilestoneSection({
|
||||
return (
|
||||
<li key={step.label} className="flex items-start gap-2 text-sm">
|
||||
{done ? (
|
||||
<CheckCircle2 className="mt-0.5 size-4 shrink-0 text-emerald-600" />
|
||||
<CheckCircle2 className="mt-0.5 size-4 shrink-0 text-emerald-600" aria-hidden />
|
||||
) : (
|
||||
<Circle
|
||||
className={cn(
|
||||
@@ -650,7 +650,7 @@ function OverviewTab({
|
||||
<div className="flex flex-wrap items-center gap-x-3 gap-y-1.5">
|
||||
<Button asChild size="sm" className="h-7 px-2.5 text-xs">
|
||||
<Link href={`/${portSlug}/invoices/new?interestId=${interestId}&kind=deposit`}>
|
||||
<Plus className="size-3.5" />
|
||||
<Plus className="size-3.5" aria-hidden />
|
||||
Create deposit invoice
|
||||
</Link>
|
||||
</Button>
|
||||
@@ -710,7 +710,7 @@ function OverviewTab({
|
||||
<span className="text-[10px] font-semibold uppercase tracking-wide">Past</span>
|
||||
{pastMilestones.map((m) => (
|
||||
<span key={m.key} className="inline-flex items-center gap-1.5">
|
||||
<CheckCircle2 className="size-3 text-emerald-600" />
|
||||
<CheckCircle2 className="size-3 text-emerald-600" aria-hidden />
|
||||
<span className="font-medium text-foreground">{m.title}</span>
|
||||
<span>·</span>
|
||||
<span>{m.pastSummary}</span>
|
||||
|
||||
Reference in New Issue
Block a user