fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -81,7 +81,7 @@ export function AddBerthToInterestDialog({
|
||||
title="Pitching specifically"
|
||||
description="The client is pitched on this exact berth."
|
||||
consequence="This berth will appear as under interest on the public map."
|
||||
icon={<Eye className="size-4" />}
|
||||
icon={<Eye className="size-4" aria-hidden />}
|
||||
/>
|
||||
<RoleCard
|
||||
value="exploring"
|
||||
@@ -89,7 +89,7 @@ export function AddBerthToInterestDialog({
|
||||
title="Just exploring"
|
||||
description="The berth is being considered or covered by the EOI bundle, but not pitched specifically."
|
||||
consequence="This berth is hidden from the public map."
|
||||
icon={<EyeOff className="size-4" />}
|
||||
icon={<EyeOff className="size-4" aria-hidden />}
|
||||
/>
|
||||
</RadioGroup>
|
||||
|
||||
@@ -109,7 +109,9 @@ export function AddBerthToInterestDialog({
|
||||
Cancel
|
||||
</Button>
|
||||
<Button type="button" onClick={handleSubmit} disabled={mutation.isPending}>
|
||||
{mutation.isPending ? <Loader2 className="mr-1.5 size-3.5 animate-spin" /> : null}
|
||||
{mutation.isPending ? (
|
||||
<Loader2 className="mr-1.5 size-3.5 animate-spin" aria-hidden />
|
||||
) : null}
|
||||
Add berth to interest
|
||||
</Button>
|
||||
</DialogFooter>
|
||||
|
||||
Reference in New Issue
Block a user