fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -48,7 +48,7 @@ function ReceiptThumbnail({ fileId }: { fileId: string }) {
|
||||
if (isLoading) {
|
||||
return (
|
||||
<div className="flex h-32 items-center justify-center rounded border bg-muted/40 text-xs text-muted-foreground">
|
||||
<Loader2 className="mr-2 h-3 w-3 animate-spin" /> Loading preview…
|
||||
<Loader2 className="mr-2 h-3 w-3 animate-spin" aria-hidden /> Loading preview…
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -69,7 +69,7 @@ function ReceiptThumbnail({ fileId }: { fileId: string }) {
|
||||
</a>
|
||||
) : (
|
||||
<div className="flex h-32 items-center justify-center text-muted-foreground">
|
||||
<FileText className="h-8 w-8" />
|
||||
<FileText className="h-8 w-8" aria-hidden />
|
||||
</div>
|
||||
)}
|
||||
<div className="mt-2 flex items-center justify-between text-xs text-muted-foreground">
|
||||
@@ -78,7 +78,7 @@ function ReceiptThumbnail({ fileId }: { fileId: string }) {
|
||||
href={`/api/v1/files/${fileId}/download`}
|
||||
className="inline-flex items-center gap-1 text-primary hover:underline"
|
||||
>
|
||||
<Download className="h-3 w-3" /> Download
|
||||
<Download className="h-3 w-3" aria-hidden /> Download
|
||||
</a>
|
||||
</div>
|
||||
</div>
|
||||
@@ -131,7 +131,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
|
||||
if (isLoading) {
|
||||
return (
|
||||
<div className="flex items-center justify-center p-12">
|
||||
<Loader2 className="h-6 w-6 animate-spin text-muted-foreground" />
|
||||
<Loader2 className="h-6 w-6 animate-spin text-muted-foreground" aria-hidden />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -162,7 +162,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
|
||||
{onEdit && (
|
||||
<PermissionGate resource="expenses" action="edit">
|
||||
<Button variant="outline" size="sm" onClick={onEdit}>
|
||||
<Edit className="mr-1.5 h-4 w-4" />
|
||||
<Edit className="mr-1.5 h-4 w-4" aria-hidden />
|
||||
Edit
|
||||
</Button>
|
||||
</PermissionGate>
|
||||
@@ -174,7 +174,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
|
||||
className="text-destructive"
|
||||
onClick={() => setArchiveOpen(true)}
|
||||
>
|
||||
<Archive className="mr-1.5 h-4 w-4" />
|
||||
<Archive className="mr-1.5 h-4 w-4" aria-hidden />
|
||||
Archive
|
||||
</Button>
|
||||
</PermissionGate>
|
||||
@@ -259,7 +259,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
|
||||
<Card>
|
||||
<CardHeader>
|
||||
<CardTitle className="text-sm font-medium flex items-center gap-2">
|
||||
<Receipt className="h-4 w-4" />
|
||||
<Receipt className="h-4 w-4" aria-hidden />
|
||||
Receipts ({expense.receiptFileIds.length})
|
||||
</CardTitle>
|
||||
</CardHeader>
|
||||
|
||||
Reference in New Issue
Block a user