letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Browse Source 
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/components/expenses/expense-card.tsx
View File

@@ -108,22 +108,22 @@ export function ExpenseCard({ expense, portSlug, onEdit, onArchive }: ExpenseCar
onClick={(e) => e.stopPropagation()}
aria-label={`Actions for expense: ${title}`}
>
<MoreHorizontal className="h-4 w-4" />
<MoreHorizontal className="h-4 w-4" aria-hidden />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
<DropdownMenuItem asChild>
<Link href={`/${portSlug}/expenses/${expense.id}`}>
<Eye className="mr-2 h-3.5 w-3.5" />
<Eye className="mr-2 h-3.5 w-3.5" aria-hidden />
View
</Link>
</DropdownMenuItem>
<DropdownMenuItem onClick={() => onEdit(expense)}>
<Pencil className="mr-2 h-3.5 w-3.5" />
<Pencil className="mr-2 h-3.5 w-3.5" aria-hidden />
Edit
</DropdownMenuItem>
<DropdownMenuItem className="text-destructive" onClick={() => onArchive(expense)}>
<Archive className="mr-2 h-3.5 w-3.5" />
<Archive className="mr-2 h-3.5 w-3.5" aria-hidden />
Archive
</DropdownMenuItem>
</DropdownMenuContent>
@@ -131,7 +131,7 @@ export function ExpenseCard({ expense, portSlug, onEdit, onArchive }: ExpenseCar
}
>
<div className="flex items-start gap-3">
<ListCardAvatar icon={<Receipt className="h-5 w-5" />} />
<ListCardAvatar icon={<Receipt className="h-5 w-5" aria-hidden />} />
<div className="min-w-0 flex-1">
{/* Title row + spacer for actions button */}
<div className="flex items-start justify-between gap-2">
@@ -159,7 +159,9 @@ export function ExpenseCard({ expense, portSlug, onEdit, onArchive }: ExpenseCar
{/* Date meta */}
{dateFormatted ? (
<div className="mt-0.5 flex flex-wrap items-center gap-x-2 text-xs text-muted-foreground">
<ListCardMeta icon={<Calendar className="h-3 w-3" />}>{dateFormatted}</ListCardMeta>
<ListCardMeta icon={<Calendar className="h-3 w-3" aria-hidden />}>
{dateFormatted}
</ListCardMeta>
</div>
) : null}

8
src/components/expenses/expense-columns.tsx
View File

@@ -166,22 +166,22 @@ export function getExpenseColumns({
className="h-7 w-7"
onClick={(e) => e.stopPropagation()}
>
<MoreHorizontal className="h-4 w-4" />
<MoreHorizontal className="h-4 w-4" aria-hidden />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
<DropdownMenuItem asChild>
<Link href={`/${portSlug}/expenses/${row.original.id}`}>
<Eye className="mr-2 h-3.5 w-3.5" />
<Eye className="mr-2 h-3.5 w-3.5" aria-hidden />
View
</Link>
</DropdownMenuItem>
<DropdownMenuItem onClick={() => onEdit(row.original)}>
<Pencil className="mr-2 h-3.5 w-3.5" />
<Pencil className="mr-2 h-3.5 w-3.5" aria-hidden />
Edit
</DropdownMenuItem>
<DropdownMenuItem className="text-destructive" onClick={() => onArchive(row.original)}>
<Archive className="mr-2 h-3.5 w-3.5" />
<Archive className="mr-2 h-3.5 w-3.5" aria-hidden />
Archive
</DropdownMenuItem>
</DropdownMenuContent>

14
src/components/expenses/expense-detail.tsx
View File

@@ -48,7 +48,7 @@ function ReceiptThumbnail({ fileId }: { fileId: string }) {
if (isLoading) {
return (
<div className="flex h-32 items-center justify-center rounded border bg-muted/40 text-xs text-muted-foreground">
<Loader2 className="mr-2 h-3 w-3 animate-spin" /> Loading preview…
<Loader2 className="mr-2 h-3 w-3 animate-spin" aria-hidden /> Loading preview…
</div>
);
}
@@ -69,7 +69,7 @@ function ReceiptThumbnail({ fileId }: { fileId: string }) {
</a>
) : (
<div className="flex h-32 items-center justify-center text-muted-foreground">
<FileText className="h-8 w-8" />
<FileText className="h-8 w-8" aria-hidden />
</div>
)}
<div className="mt-2 flex items-center justify-between text-xs text-muted-foreground">
@@ -78,7 +78,7 @@ function ReceiptThumbnail({ fileId }: { fileId: string }) {
href={`/api/v1/files/${fileId}/download`}
className="inline-flex items-center gap-1 text-primary hover:underline"
>
<Download className="h-3 w-3" /> Download
<Download className="h-3 w-3" aria-hidden /> Download
</a>
</div>
</div>
@@ -131,7 +131,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
if (isLoading) {
return (
<div className="flex items-center justify-center p-12">
<Loader2 className="h-6 w-6 animate-spin text-muted-foreground" />
<Loader2 className="h-6 w-6 animate-spin text-muted-foreground" aria-hidden />
</div>
);
}
@@ -162,7 +162,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
{onEdit && (
<PermissionGate resource="expenses" action="edit">
<Button variant="outline" size="sm" onClick={onEdit}>
<Edit className="mr-1.5 h-4 w-4" />
<Edit className="mr-1.5 h-4 w-4" aria-hidden />
Edit
</Button>
</PermissionGate>
@@ -174,7 +174,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
className="text-destructive"
onClick={() => setArchiveOpen(true)}
>
<Archive className="mr-1.5 h-4 w-4" />
<Archive className="mr-1.5 h-4 w-4" aria-hidden />
Archive
</Button>
</PermissionGate>
@@ -259,7 +259,7 @@ export function ExpenseDetail({ expenseId, onEdit, onArchived }: ExpenseDetailPr
<Card>
<CardHeader>
<CardTitle className="text-sm font-medium flex items-center gap-2">
<Receipt className="h-4 w-4" />
<Receipt className="h-4 w-4" aria-hidden />
Receipts ({expense.receiptFileIds.length})
</CardTitle>
</CardHeader>

2
src/components/expenses/expense-duplicate-banner.tsx
View File

@@ -75,7 +75,7 @@ export function ExpenseDuplicateBanner({ expense }: Props) {
)}
>
<div className="flex min-w-0 items-start gap-2">
<AlertTriangle className="mt-0.5 h-4 w-4 shrink-0" />
<AlertTriangle className="mt-0.5 h-4 w-4 shrink-0" aria-hidden />
<div className="min-w-0">
<p className="font-medium">Looks like a duplicate</p>
<p className="mt-0.5 text-xs text-amber-800">

6
src/components/expenses/expense-form-dialog.tsx
View File

@@ -363,7 +363,7 @@ export function ExpenseFormDialog({ open, onOpenChange, expense }: ExpenseFormDi
disabled={noReceipt}
onClick={() => fileInputRef.current?.click()}
>
<Upload className="mr-2 h-4 w-4" />
<Upload className="mr-2 h-4 w-4" aria-hidden />
Upload receipt image or PDF
</Button>
)}
@@ -393,7 +393,7 @@ export function ExpenseFormDialog({ open, onOpenChange, expense }: ExpenseFormDi
{noReceipt && (
<div className="flex gap-2 rounded-md border border-amber-300 bg-amber-50 p-2 text-xs text-amber-900 dark:border-amber-900 dark:bg-amber-950/40 dark:text-amber-200">
<AlertTriangle className="h-4 w-4 shrink-0" />
<AlertTriangle className="h-4 w-4 shrink-0" aria-hidden />
<span>
Expenses without a receipt may not be reimbursed by the parent company. The PDF
export will flag this expense.
@@ -416,7 +416,7 @@ export function ExpenseFormDialog({ open, onOpenChange, expense }: ExpenseFormDi
disabled={isSubmitting || mutation.isPending || isUploading || !canSubmit}
>
{(isSubmitting || mutation.isPending) && (
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
<Loader2 className="mr-2 h-4 w-4 animate-spin" aria-hidden />
)}
{isEdit ? 'Save changes' : 'Create Expense'}
</Button>

4
src/components/expenses/trip-label-combobox.tsx
View File

@@ -73,7 +73,7 @@ export function TripLabelCombobox({
className={cn('w-full justify-between font-normal', !value && 'text-muted-foreground')}
>
<span className="truncate">{value || placeholder}</span>
<ChevronsUpDown className="ml-2 h-4 w-4 shrink-0 opacity-50" />
<ChevronsUpDown className="ml-2 h-4 w-4 shrink-0 opacity-50" aria-hidden />
</Button>
</PopoverTrigger>
<PopoverContent className="w-(--radix-popper-anchor-width) min-w-[260px] p-0">
@@ -102,7 +102,7 @@ export function TripLabelCombobox({
{showCreate ? (
<CommandGroup heading="New">
<CommandItem value={`__create__${trimmed}`} onSelect={() => commit(trimmed)}>
<Plus className="mr-2 h-4 w-4" />
<Plus className="mr-2 h-4 w-4" aria-hidden />
<span className="truncate">Create &ldquo;{trimmed}&rdquo;</span>
</CommandItem>
</CommandGroup>