fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -101,12 +101,12 @@ export function EmailDraftButton({
<Button variant="outline" size="sm" onClick={handleGenerateDraft} disabled={isLoading}>
{isLoading ? (
<>
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" />
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" aria-hidden />
Generating...
</>
) : (
<>
<Mail className="mr-1.5 h-3.5 w-3.5" />
<Mail className="mr-1.5 h-3.5 w-3.5" aria-hidden />
Draft Email
</>
)}
@@ -156,12 +156,12 @@ export function EmailDraftButton({
<Button variant="outline" size="sm" onClick={handleCopy}>
{copied ? (
<>
<Check className="mr-1.5 h-3.5 w-3.5 text-green-600" />
<Check className="mr-1.5 h-3.5 w-3.5 text-green-600" aria-hidden />
Copied
</>
) : (
<>
<Copy className="mr-1.5 h-3.5 w-3.5" />
<Copy className="mr-1.5 h-3.5 w-3.5" aria-hidden />
Copy to clipboard
</>
)}
@@ -174,7 +174,7 @@ export function EmailDraftButton({
>
{isLoading ? (
<>
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" />
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" aria-hidden />
Regenerating...
</>
) : (