fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -117,7 +117,7 @@ export function EmailAccountsList() {
</p>
</div>
<Button onClick={() => setSheetOpen(true)}>
<Plus className="h-4 w-4 mr-1.5" />
<Plus className="h-4 w-4 mr-1.5" aria-hidden />
Add account
</Button>
</div>
@@ -126,14 +126,14 @@ export function EmailAccountsList() {
<p className="text-sm text-muted-foreground">Loading</p>
) : accounts.length === 0 ? (
<div className="rounded-lg border border-dashed p-8 text-center text-muted-foreground">
<Mail className="mx-auto h-6 w-6 mb-2" />
<Mail className="mx-auto h-6 w-6 mb-2" aria-hidden />
<p className="text-sm">No email accounts connected.</p>
</div>
) : (
<div className="rounded-lg border divide-y">
{accounts.map((a) => (
<div key={a.id} className="flex items-center gap-3 p-3">
<Mail className="h-5 w-5 text-muted-foreground" />
<Mail className="h-5 w-5 text-muted-foreground" aria-hidden />
<div className="flex-1 min-w-0">
<div className="text-sm font-medium truncate">{a.emailAddress}</div>
<div className="text-xs text-muted-foreground">
@@ -152,12 +152,12 @@ export function EmailAccountsList() {
disabled={syncMutation.isPending}
title="Sync now"
>
<RefreshCw className="h-4 w-4" />
<RefreshCw className="h-4 w-4" aria-hidden />
</Button>
<ConfirmationDialog
trigger={
<Button variant="ghost" size="icon" className="text-destructive">
<Trash2 className="h-4 w-4" />
<Trash2 className="h-4 w-4" aria-hidden />
</Button>
}
title="Remove account"

View File

@@ -101,12 +101,12 @@ export function EmailDraftButton({
<Button variant="outline" size="sm" onClick={handleGenerateDraft} disabled={isLoading}>
{isLoading ? (
<>
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" />
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" aria-hidden />
Generating...
</>
) : (
<>
<Mail className="mr-1.5 h-3.5 w-3.5" />
<Mail className="mr-1.5 h-3.5 w-3.5" aria-hidden />
Draft Email
</>
)}
@@ -156,12 +156,12 @@ export function EmailDraftButton({
<Button variant="outline" size="sm" onClick={handleCopy}>
{copied ? (
<>
<Check className="mr-1.5 h-3.5 w-3.5 text-green-600" />
<Check className="mr-1.5 h-3.5 w-3.5 text-green-600" aria-hidden />
Copied
</>
) : (
<>
<Copy className="mr-1.5 h-3.5 w-3.5" />
<Copy className="mr-1.5 h-3.5 w-3.5" aria-hidden />
Copy to clipboard
</>
)}
@@ -174,7 +174,7 @@ export function EmailDraftButton({
>
{isLoading ? (
<>
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" />
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" aria-hidden />
Regenerating...
</>
) : (

View File

@@ -35,11 +35,11 @@ export function EmailThreadsList() {
{Array.from({ length: 4 }).map((_, i) => (
<div key={i} className="p-3 space-y-2">
<div className="flex items-center justify-between gap-2">
<Skeleton className="h-4 w-1/3" />
<Skeleton className="h-3 w-16" />
<Skeleton className="h-4 w-1/3" aria-hidden />
<Skeleton className="h-3 w-16" aria-hidden />
</div>
<Skeleton className="h-3 w-1/2" />
<Skeleton className="h-3 w-2/3" />
<Skeleton className="h-3 w-1/2" aria-hidden />
<Skeleton className="h-3 w-2/3" aria-hidden />
</div>
))}
</div>