fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -50,7 +50,7 @@ export function EntityFolderView({ portSlug, entityType, entityId }: Props) {
|
||||
<div className="space-y-4">
|
||||
<AggregatedSection<'workflows'>
|
||||
title="Signing in progress"
|
||||
icon={<ClipboardSignature className="h-4 w-4 text-muted-foreground" />}
|
||||
icon={<ClipboardSignature className="h-4 w-4 text-muted-foreground" aria-hidden />}
|
||||
groups={workflowGroups}
|
||||
loading={workflowsLoading}
|
||||
emptyMessage="No workflows in flight for this entity."
|
||||
@@ -68,7 +68,7 @@ export function EntityFolderView({ portSlug, entityType, entityId }: Props) {
|
||||
|
||||
<AggregatedSection<'files'>
|
||||
title="Files"
|
||||
icon={<FileText className="h-4 w-4 text-muted-foreground" />}
|
||||
icon={<FileText className="h-4 w-4 text-muted-foreground" aria-hidden />}
|
||||
groups={fileGroups}
|
||||
loading={filesLoading}
|
||||
emptyMessage="No files for this entity yet."
|
||||
@@ -86,7 +86,7 @@ export function EntityFolderView({ portSlug, entityType, entityId }: Props) {
|
||||
className="min-h-[44px] gap-1 px-2 text-xs text-brand"
|
||||
onClick={() => setDetailsId(signedFromDocumentId)}
|
||||
>
|
||||
<Eye className="h-3 w-3" />
|
||||
<Eye className="h-3 w-3" aria-hidden />
|
||||
View signing details
|
||||
</Button>
|
||||
) : null}
|
||||
|
||||
Reference in New Issue
Block a user