letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Browse Source 
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/components/clients/smart-archive-dialog.tsx
View File

@@ -283,7 +283,7 @@ function SmartArchiveDialogBody({
{isLoading ? (
<div className="py-8 text-center text-sm text-muted-foreground">
<Loader2 className="h-5 w-5 animate-spin mx-auto mb-2" />
<Loader2 className="h-5 w-5 animate-spin mx-auto mb-2" aria-hidden />
Loading dossier…
</div>
) : error || !dossier ? (
@@ -296,7 +296,7 @@ function SmartArchiveDialogBody({
<Card className="border-red-300 bg-red-50">
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium text-red-800 flex items-center gap-2">
<AlertTriangle className="h-4 w-4" /> Cannot archive
<AlertTriangle className="h-4 w-4" aria-hidden /> Cannot archive
</CardTitle>
</CardHeader>
<CardContent className="text-sm text-red-700 space-y-1">
@@ -311,7 +311,7 @@ function SmartArchiveDialogBody({
<Card className="border-amber-300 bg-amber-50">
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium text-amber-900 flex items-center gap-2">
<AlertTriangle className="h-4 w-4" />
<AlertTriangle className="h-4 w-4" aria-hidden />
Late-stage deal — confirmation required
</CardTitle>
</CardHeader>
@@ -328,7 +328,8 @@ function SmartArchiveDialogBody({
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium flex items-center gap-2">
<FileText className="h-4 w-4" /> Pipeline interests ({dossier.interests.length})
<FileText className="h-4 w-4" aria-hidden /> Pipeline interests (
{dossier.interests.length})
</CardTitle>
</CardHeader>
<CardContent className="text-xs space-y-1">
@@ -371,7 +372,7 @@ function SmartArchiveDialogBody({
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium flex items-center gap-2">
<Anchor className="h-4 w-4" /> Berths ({dossier.berths.length})
<Anchor className="h-4 w-4" aria-hidden /> Berths ({dossier.berths.length})
</CardTitle>
</CardHeader>
<CardContent className="space-y-3">
@@ -425,7 +426,7 @@ function SmartArchiveDialogBody({
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium flex items-center gap-2">
<Ship className="h-4 w-4" /> Yachts owned ({dossier.yachts.length})
<Ship className="h-4 w-4" aria-hidden /> Yachts owned ({dossier.yachts.length})
</CardTitle>
</CardHeader>
<CardContent className="space-y-2">
@@ -459,7 +460,7 @@ function SmartArchiveDialogBody({
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium flex items-center gap-2">
<Anchor className="h-4 w-4" /> Active reservations (
<Anchor className="h-4 w-4" aria-hidden /> Active reservations (
{dossier.reservations.length})
</CardTitle>
</CardHeader>
@@ -493,7 +494,8 @@ function SmartArchiveDialogBody({
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium flex items-center gap-2">
<Receipt className="h-4 w-4" /> Outstanding invoices ({dossier.invoices.length})
<Receipt className="h-4 w-4" aria-hidden /> Outstanding invoices (
{dossier.invoices.length})
</CardTitle>
</CardHeader>
<CardContent className="space-y-2">
@@ -527,7 +529,7 @@ function SmartArchiveDialogBody({
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium flex items-center gap-2">
<FileText className="h-4 w-4" /> In-flight signing requests
<FileText className="h-4 w-4" aria-hidden /> In-flight signing requests
</CardTitle>
</CardHeader>
<CardContent className="space-y-2">
@@ -559,7 +561,7 @@ function SmartArchiveDialogBody({
<Card className="border-muted">
<CardHeader className="pb-2">
<CardTitle className="text-sm font-medium flex items-center gap-2">
<Users className="h-4 w-4" /> Automatically handled
<Users className="h-4 w-4" aria-hidden /> Automatically handled
</CardTitle>
</CardHeader>
<CardContent className="text-xs text-muted-foreground space-y-1">
@@ -600,7 +602,7 @@ function SmartArchiveDialogBody({
onClick={() => archiveMutation.mutate()}
>
{archiveMutation.isPending ? (
<Loader2 className="h-3.5 w-3.5 animate-spin mr-1.5" />
<Loader2 className="h-3.5 w-3.5 animate-spin mr-1.5" aria-hidden />
) : null}
Archive
</Button>