fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -111,7 +111,7 @@ export function GdprExportButton({ clientId }: { clientId: string }) {
|
||||
<Dialog open={open} onOpenChange={setOpen}>
|
||||
<DialogTrigger asChild>
|
||||
<Button variant="outline" size="sm" className="h-8">
|
||||
<FileDown className="mr-1.5 h-3.5 w-3.5" />
|
||||
<FileDown className="mr-1.5 h-3.5 w-3.5" aria-hidden />
|
||||
GDPR export
|
||||
</Button>
|
||||
</DialogTrigger>
|
||||
@@ -154,9 +154,9 @@ export function GdprExportButton({ clientId }: { clientId: string }) {
|
||||
|
||||
<Button onClick={() => request.mutate()} disabled={request.isPending}>
|
||||
{request.isPending ? (
|
||||
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" />
|
||||
<Loader2 className="mr-1.5 h-3.5 w-3.5 animate-spin" aria-hidden />
|
||||
) : (
|
||||
<FileDown className="mr-1.5 h-3.5 w-3.5" />
|
||||
<FileDown className="mr-1.5 h-3.5 w-3.5" aria-hidden />
|
||||
)}
|
||||
Queue export
|
||||
</Button>
|
||||
@@ -180,7 +180,7 @@ export function GdprExportButton({ clientId }: { clientId: string }) {
|
||||
</div>
|
||||
{r.sentTo ? (
|
||||
<div className="text-xs text-muted-foreground inline-flex items-center gap-1">
|
||||
<Mail className="h-3 w-3" />
|
||||
<Mail className="h-3 w-3" aria-hidden />
|
||||
Sent to {r.sentTo}
|
||||
</div>
|
||||
) : null}
|
||||
@@ -195,7 +195,7 @@ export function GdprExportButton({ clientId }: { clientId: string }) {
|
||||
size="sm"
|
||||
onClick={() => downloadById(r.id)}
|
||||
>
|
||||
<Download className="h-3.5 w-3.5" />
|
||||
<Download className="h-3.5 w-3.5" aria-hidden />
|
||||
</Button>
|
||||
) : null}
|
||||
</li>
|
||||
|
||||
Reference in New Issue
Block a user