fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -73,7 +73,7 @@ export function UserCard({
onClick={(e) => e.stopPropagation()}
aria-label={`Actions for ${user.displayName}`}
>
<MoreHorizontal className="h-4 w-4" />
<MoreHorizontal className="h-4 w-4" aria-hidden />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
@@ -83,7 +83,7 @@ export function UserCard({
onEdit(user);
}}
>
<Pencil className="mr-2 h-3.5 w-3.5" />
<Pencil className="mr-2 h-3.5 w-3.5" aria-hidden />
Edit
</DropdownMenuItem>
<ConfirmationDialog
@@ -91,12 +91,12 @@ export function UserCard({
<DropdownMenuItem onSelect={(e) => e.preventDefault()} disabled={isToggling}>
{user.isActive ? (
<>
<PowerOff className="mr-2 h-3.5 w-3.5" />
<PowerOff className="mr-2 h-3.5 w-3.5" aria-hidden />
Disable sign-in
</>
) : (
<>
<Power className="mr-2 h-3.5 w-3.5 text-emerald-600" />
<Power className="mr-2 h-3.5 w-3.5 text-emerald-600" aria-hidden />
Enable sign-in
</>
)}
@@ -115,7 +115,7 @@ export function UserCard({
<ConfirmationDialog
trigger={
<DropdownMenuItem className="text-destructive" onSelect={(e) => e.preventDefault()}>
<Trash2 className="mr-2 h-3.5 w-3.5" />
<Trash2 className="mr-2 h-3.5 w-3.5" aria-hidden />
Remove
</DropdownMenuItem>
}
@@ -155,16 +155,18 @@ export function UserCard({
{/* Role + last login meta */}
<div className="mt-1 flex flex-wrap items-center gap-x-2 gap-y-0.5 text-xs text-muted-foreground">
<ListCardMeta icon={<Shield className="h-3 w-3" />}>
<ListCardMeta icon={<Shield className="h-3 w-3" aria-hidden />}>
{formatRole(user.role.name)}
</ListCardMeta>
{user.lastLoginAt ? (
<ListCardMeta icon={<Clock className="h-3 w-3" />}>
<ListCardMeta icon={<Clock className="h-3 w-3" aria-hidden />}>
{formatDistanceToNow(new Date(user.lastLoginAt), { addSuffix: true })}
</ListCardMeta>
) : (
<ListCardMeta icon={<Clock className="h-3 w-3" />}>Never logged in</ListCardMeta>
<ListCardMeta icon={<Clock className="h-3 w-3" aria-hidden />}>
Never logged in
</ListCardMeta>
)}
</div>

View File

@@ -130,7 +130,7 @@ export function UserList() {
onClick={() => handleEditUser(row.original)}
title="Edit user"
>
<Pencil className="h-4 w-4" />
<Pencil className="h-4 w-4" aria-hidden />
<span className="sr-only">Edit</span>
</Button>
</PermissionGate>
@@ -149,9 +149,9 @@ export function UserList() {
}
>
{row.original.isActive ? (
<PowerOff className="h-4 w-4" />
<PowerOff className="h-4 w-4" aria-hidden />
) : (
<Power className="h-4 w-4" />
<Power className="h-4 w-4" aria-hidden />
)}
<span className="sr-only">{row.original.isActive ? 'Disable' : 'Enable'}</span>
</Button>
@@ -176,7 +176,7 @@ export function UserList() {
title="Remove from port"
className="text-destructive hover:text-destructive"
>
<Trash2 className="h-4 w-4" />
<Trash2 className="h-4 w-4" aria-hidden />
<span className="sr-only">Remove</span>
</Button>
}
@@ -201,7 +201,7 @@ export function UserList() {
description="Manage users and their roles for this port"
actions={
<Button onClick={handleNewUser}>
<Plus className="mr-1.5 h-4 w-4" />
<Plus className="mr-1.5 h-4 w-4" aria-hidden />
New User
</Button>
}