fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -60,9 +60,9 @@ export function SystemMonitoringDashboard() {
<>
<div className="flex items-center gap-2 mb-3">
{health.overall === 'healthy' ? (
<CheckCircle2 className="h-4 w-4 text-green-500" />
<CheckCircle2 className="h-4 w-4 text-green-500" aria-hidden />
) : (
<AlertTriangle className="h-4 w-4 text-yellow-500" />
<AlertTriangle className="h-4 w-4 text-yellow-500" aria-hidden />
)}
<span className="text-sm text-muted-foreground">
All services checked at {new Date(health.checkedAt).toLocaleTimeString()}
@@ -88,7 +88,7 @@ export function SystemMonitoringDashboard() {
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-xs text-muted-foreground font-medium uppercase tracking-wide flex items-center gap-1.5">
<Wifi className="h-3.5 w-3.5" />
<Wifi className="h-3.5 w-3.5" aria-hidden />
Active Connections
</CardTitle>
</CardHeader>
@@ -100,7 +100,7 @@ export function SystemMonitoringDashboard() {
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-xs text-muted-foreground font-medium uppercase tracking-wide flex items-center gap-1.5">
<AlertTriangle className="h-3.5 w-3.5" />
<AlertTriangle className="h-3.5 w-3.5" aria-hidden />
Total Failed Jobs
</CardTitle>
</CardHeader>
@@ -114,7 +114,7 @@ export function SystemMonitoringDashboard() {
<Card>
<CardHeader className="pb-2">
<CardTitle className="text-xs text-muted-foreground font-medium uppercase tracking-wide flex items-center gap-1.5">
<Activity className="h-3.5 w-3.5" />
<Activity className="h-3.5 w-3.5" aria-hidden />
Active Jobs
</CardTitle>
</CardHeader>