fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -87,7 +87,7 @@ export function RoleList() {
<span className="font-medium">{formatRole(row.original.name)}</span>
{row.original.isSystem && (
<Badge variant="outline" className="text-xs">
<Lock className="mr-1 h-3 w-3" />
<Lock className="mr-1 h-3 w-3" aria-hidden />
System
</Badge>
)}
@@ -126,7 +126,7 @@ export function RoleList() {
cell: ({ row }) => (
<div className="flex items-center justify-end gap-1">
<Button variant="ghost" size="sm" onClick={() => handleEditRole(row.original)}>
<Pencil className="h-4 w-4" />
<Pencil className="h-4 w-4" aria-hidden />
<span className="sr-only">Edit</span>
</Button>
{!row.original.isSystem && (
@@ -137,7 +137,7 @@ export function RoleList() {
size="sm"
className="text-destructive hover:text-destructive"
>
<Trash2 className="h-4 w-4" />
<Trash2 className="h-4 w-4" aria-hidden />
<span className="sr-only">Delete</span>
</Button>
}
@@ -162,7 +162,7 @@ export function RoleList() {
description="Manage roles and their permissions"
actions={
<Button onClick={handleNewRole}>
<Plus className="mr-1.5 h-4 w-4" />
<Plus className="mr-1.5 h-4 w-4" aria-hidden />
New Role
</Button>
}
@@ -209,7 +209,7 @@ export function RoleList() {
onClick={() => handleEditRole(original)}
aria-label="Edit role"
>
<Pencil className="h-4 w-4" />
<Pencil className="h-4 w-4" aria-hidden />
</Button>
{!original.isSystem ? (
<ConfirmationDialog
@@ -220,7 +220,7 @@ export function RoleList() {
className="text-destructive hover:text-destructive"
aria-label="Delete role"
>
<Trash2 className="h-4 w-4" />
<Trash2 className="h-4 w-4" aria-hidden />
</Button>
}
title="Delete Role"