fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)

Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line
Lucide icon JSX elements across 267 .tsx files in:

- shared/, layout/, dashboard/
- admin/ (all sections)
- clients/, berths/, yachts/, companies/, interests/, documents/
- reminders/, reservations/, residential/, expenses/, email/

The regex targeted only the safe pattern \`<IconName className="..." />\`
(no other props, self-closing, capitalized component name). Every match
inspected is a decorative companion to visible text or sits inside a
button whose accessible name comes from \`aria-label\` / sr-only text
— the icon itself should not be announced.

Screen readers no longer double-read the icon + the adjacent label
text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing
@axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues
to pass.

Test suite stays at 1315/1315 vitest. typescript clean.

Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups
backlog.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-13 12:37:22 +02:00
parent ecf49be18c
commit c8ea9ec0a0
172 changed files with 727 additions and 614 deletions

View File

@@ -89,7 +89,7 @@ export function InvitationsManager() {
</p>
</div>
<Button onClick={() => setSheetOpen(true)}>
<Plus className="h-4 w-4 mr-1.5" />
<Plus className="h-4 w-4 mr-1.5" aria-hidden />
Send invite
</Button>
</div>
@@ -98,7 +98,7 @@ export function InvitationsManager() {
<p className="text-sm text-muted-foreground">Loading</p>
) : invites.length === 0 ? (
<div className="rounded-lg border border-dashed p-8 text-center text-muted-foreground">
<Mail className="mx-auto h-6 w-6 mb-2" />
<Mail className="mx-auto h-6 w-6 mb-2" aria-hidden />
<p className="text-sm">No invitations issued yet.</p>
</div>
) : (
@@ -142,7 +142,7 @@ export function InvitationsManager() {
disabled={resendMutation.isPending || !!i.usedAt}
title="Resend invite"
>
<RotateCw className="h-3.5 w-3.5" />
<RotateCw className="h-3.5 w-3.5" aria-hidden />
</Button>
{i.status === 'pending' && (
<ConfirmationDialog
@@ -153,7 +153,7 @@ export function InvitationsManager() {
className="text-destructive"
title="Revoke"
>
<Trash2 className="h-3.5 w-3.5" />
<Trash2 className="h-3.5 w-3.5" aria-hidden />
</Button>
}
title="Revoke invitation?"
@@ -230,7 +230,9 @@ export function InvitationsManager() {
Cancel
</Button>
<Button type="submit" disabled={!email.trim() || createMutation.isPending}>
{createMutation.isPending && <Loader2 className="mr-2 h-4 w-4 animate-spin" />}
{createMutation.isPending && (
<Loader2 className="mr-2 h-4 w-4 animate-spin" aria-hidden />
)}
Send invite
</Button>
</SheetFooter>