fix(audit-wave-10): aria-hidden sweep on decorative Lucide icons (#69)
Mechanical codemod added \`aria-hidden\` to 444 self-closing single-line Lucide icon JSX elements across 267 .tsx files in: - shared/, layout/, dashboard/ - admin/ (all sections) - clients/, berths/, yachts/, companies/, interests/, documents/ - reminders/, reservations/, residential/, expenses/, email/ The regex targeted only the safe pattern \`<IconName className="..." />\` (no other props, self-closing, capitalized component name). Every match inspected is a decorative companion to visible text or sits inside a button whose accessible name comes from \`aria-label\` / sr-only text — the icon itself should not be announced. Screen readers no longer double-read the icon + the adjacent label text (e.g. "Pencil Pencil Edit" → just "Edit"). The existing @axe-core/playwright smoke test (\`20-accessibility.spec.ts\`) continues to pass. Test suite stays at 1315/1315 vitest. typescript clean. Closes task #69 (aria-hidden sweep) from the AUDIT-2026-05-12 follow-ups backlog. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -207,7 +207,7 @@ export function PdfLogoUploader() {
|
||||
|
||||
{loading ? (
|
||||
<div className="flex items-center gap-2 text-sm text-muted-foreground">
|
||||
<Loader2 className="h-4 w-4 animate-spin" /> Loading current logo…
|
||||
<Loader2 className="h-4 w-4 animate-spin" aria-hidden /> Loading current logo…
|
||||
</div>
|
||||
) : current ? (
|
||||
<div className="flex items-start gap-4 rounded-md border p-4">
|
||||
@@ -232,7 +232,7 @@ export function PdfLogoUploader() {
|
||||
Test with sample PDF
|
||||
</Button>
|
||||
<Button variant="outline" size="sm" onClick={clear} disabled={working}>
|
||||
<Trash2 className="mr-1 h-3 w-3" /> Remove
|
||||
<Trash2 className="mr-1 h-3 w-3" aria-hidden /> Remove
|
||||
</Button>
|
||||
</div>
|
||||
</div>
|
||||
@@ -292,9 +292,9 @@ export function PdfLogoUploader() {
|
||||
<div className="flex gap-2">
|
||||
<Button onClick={upload} disabled={working}>
|
||||
{working ? (
|
||||
<Loader2 className="mr-1 h-3 w-3 animate-spin" />
|
||||
<Loader2 className="mr-1 h-3 w-3 animate-spin" aria-hidden />
|
||||
) : (
|
||||
<Upload className="mr-1 h-3 w-3" />
|
||||
<Upload className="mr-1 h-3 w-3" aria-hidden />
|
||||
)}
|
||||
Save logo
|
||||
</Button>
|
||||
@@ -316,7 +316,7 @@ export function PdfLogoUploader() {
|
||||
onClick={() => fileInputRef.current?.click()}
|
||||
disabled={working}
|
||||
>
|
||||
<RefreshCw className="mr-1 h-3 w-3" /> Choose a different file
|
||||
<RefreshCw className="mr-1 h-3 w-3" aria-hidden /> Choose a different file
|
||||
</Button>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user