feat(expenses+interests): trip/event grouping (lightweight)

Per the trips/events design discussion: instead of building a full
events domain (table + CRUD UI + calendar) for the 6–12 yacht shows
a year, ship the cheap version that covers the actual asks.

Expenses — `tripLabel` free-text:
- New `expenses.trip_label` text column (migration 0039) + index for
  filter / autocomplete lookup.
- Validator: createExpenseShape + listExpensesSchema +
  exportExpensePdfSchema.filter all accept tripLabel.
- Service: createExpense + updateExpense persist; listExpenses filters;
  new `listTripLabels(portId, search?)` returns distinct values
  ordered by most-recent expenseDate so the autocomplete surfaces
  recently-used labels first.
- New `GET /api/v1/expenses/trip-labels` endpoint (gated by
  expenses.view) backs the autocomplete.
- Form dialog: native `<datalist>` powered by the autocomplete query
  so reps don't end up with "Palm Beach 2026" / "palm-beach 2026"
  fragmented across two PDF sections.
- Expense list: new "Trip" column (badge) + free-text filter.
- Detail page: trip label rendered alongside Category / Payer.
- PDF export: GroupBy gains 'trip'; filter.tripLabel narrows the
  export. Untagged rows fall under "(no trip)".
- Trim/normalize on write so " Palm Beach 2026 " === "Palm Beach 2026".

Interests — event tagging via existing tag system:
- Reps can tag interests with an event tag (e.g. "Palm Beach 2026")
  via the existing InlineTagEditor on the detail page; tags are
  port-scoped and reusable.
- Interest list now has a TagPicker filter rendered next to the
  FilterBar so reps can sort prospects by event attended ("show me
  every lead from Palm Beach"). Hidden 'relation'-typed
  FilterDefinition for tagIds wires URL round-trip + saved-views
  capture without rendering inside the FilterBar.
- FilterBar deserializer now handles `relation` types as comma-joined
  arrays on URL load.

Why a free-text trip label and not a trips table:
- 6–12 events/year doesn't justify a domain. The CRUD UI cost would
  be most of the engineering, and reps already have the events on
  their personal calendars.
- If usage proves demand for per-event ROI dashboards or richer
  attribution, promote to a real `trips` table later. Migration
  path: trip_label → tripId is a backfill+swap.

Test status: 1168/1168 vitest. tsc clean. Migration 0039 applied
in dev (also caught + fixed an unrelated audit-v3 follow-up: 0037
had `idx_br_interest` colliding with the existing
`berth_recommendations.idx_br_interest`; renamed to
`idx_brr_interest` / `idx_brr_contract_file`).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-05-05 13:46:54 +02:00
parent 687a1f1c2f
commit c4a41d5f5b
17 changed files with 234 additions and 30 deletions

View File

@@ -1,4 +1,4 @@
import { eq, and, gte, lte, sql } from 'drizzle-orm';
import { eq, and, gte, lte, sql, isNull, ilike, isNotNull, desc, ne } from 'drizzle-orm';
import type { PgColumn } from 'drizzle-orm/pg-core';
import { db } from '@/lib/db';
@@ -19,6 +19,46 @@ import type {
export type { ListExpensesInput };
/**
* Trim + collapse whitespace on free-text trip labels so "Palm Beach 2026"
* and " Palm Beach 2026 " end up identical for the group-by + filter.
* Empty / whitespace-only collapses to null.
*/
function normalizeTripLabel(input: string | null | undefined): string | null {
if (input == null) return null;
const trimmed = input.replace(/\s+/g, ' ').trim();
return trimmed.length > 0 ? trimmed : null;
}
/**
* Distinct trip labels used in this port, ordered by most-recent first
* so the autocomplete surfaces "what reps actually used lately" rather
* than alphabetically. Powers the `tripLabel` <Combobox> on the expense
* form. Read-only — no mutation hooks.
*/
export async function listTripLabels(portId: string, search?: string): Promise<string[]> {
const conditions = [
eq(expenses.portId, portId),
isNotNull(expenses.tripLabel),
ne(expenses.tripLabel, ''),
isNull(expenses.archivedAt),
];
if (search && search.trim().length > 0) {
conditions.push(ilike(expenses.tripLabel, `%${search.trim()}%`));
}
const rows = await db
.selectDistinct({
tripLabel: expenses.tripLabel,
latest: sql<Date>`MAX(${expenses.expenseDate})`.as('latest'),
})
.from(expenses)
.where(and(...conditions))
.groupBy(expenses.tripLabel)
.orderBy(desc(sql`MAX(${expenses.expenseDate})`))
.limit(50);
return rows.map((r) => r.tripLabel as string).filter((s): s is string => Boolean(s));
}
export async function listExpenses(portId: string, query: ListExpensesInput) {
const filters = [];
@@ -34,6 +74,9 @@ export async function listExpenses(portId: string, query: ListExpensesInput) {
if (query.payer) {
filters.push(eq(expenses.payer, query.payer));
}
if (query.tripLabel) {
filters.push(eq(expenses.tripLabel, query.tripLabel));
}
if (query.dateFrom) {
filters.push(gte(expenses.expenseDate, new Date(query.dateFrom)));
}
@@ -106,6 +149,7 @@ export async function createExpense(portId: string, data: CreateExpenseInput, me
payer: data.payer,
expenseDate: data.expenseDate,
description: data.description,
tripLabel: normalizeTripLabel(data.tripLabel),
receiptFileIds: data.receiptFileIds ?? [],
noReceiptAcknowledged: data.noReceiptAcknowledged ?? false,
paymentStatus: data.paymentStatus,
@@ -175,6 +219,9 @@ export async function updateExpense(
}
const updateData: Record<string, unknown> = { ...data, updatedAt: new Date() };
if (data.tripLabel !== undefined) {
updateData.tripLabel = normalizeTripLabel(data.tripLabel);
}
// Re-convert to USD if amount or currency changed
const newAmount = data.amount ?? Number(existing.amount);