feat(expenses+interests): trip/event grouping (lightweight)

Per the trips/events design discussion: instead of building a full
events domain (table + CRUD UI + calendar) for the 6–12 yacht shows
a year, ship the cheap version that covers the actual asks.

Expenses — `tripLabel` free-text:
- New `expenses.trip_label` text column (migration 0039) + index for
  filter / autocomplete lookup.
- Validator: createExpenseShape + listExpensesSchema +
  exportExpensePdfSchema.filter all accept tripLabel.
- Service: createExpense + updateExpense persist; listExpenses filters;
  new `listTripLabels(portId, search?)` returns distinct values
  ordered by most-recent expenseDate so the autocomplete surfaces
  recently-used labels first.
- New `GET /api/v1/expenses/trip-labels` endpoint (gated by
  expenses.view) backs the autocomplete.
- Form dialog: native `<datalist>` powered by the autocomplete query
  so reps don't end up with "Palm Beach 2026" / "palm-beach 2026"
  fragmented across two PDF sections.
- Expense list: new "Trip" column (badge) + free-text filter.
- Detail page: trip label rendered alongside Category / Payer.
- PDF export: GroupBy gains 'trip'; filter.tripLabel narrows the
  export. Untagged rows fall under "(no trip)".
- Trim/normalize on write so " Palm Beach 2026 " === "Palm Beach 2026".

Interests — event tagging via existing tag system:
- Reps can tag interests with an event tag (e.g. "Palm Beach 2026")
  via the existing InlineTagEditor on the detail page; tags are
  port-scoped and reusable.
- Interest list now has a TagPicker filter rendered next to the
  FilterBar so reps can sort prospects by event attended ("show me
  every lead from Palm Beach"). Hidden 'relation'-typed
  FilterDefinition for tagIds wires URL round-trip + saved-views
  capture without rendering inside the FilterBar.
- FilterBar deserializer now handles `relation` types as comma-joined
  arrays on URL load.

Why a free-text trip label and not a trips table:
- 6–12 events/year doesn't justify a domain. The CRUD UI cost would
  be most of the engineering, and reps already have the events on
  their personal calendars.
- If usage proves demand for per-event ROI dashboards or richer
  attribution, promote to a real `trips` table later. Migration
  path: trip_label → tripId is a backfill+swap.

Test status: 1168/1168 vitest. tsc clean. Migration 0039 applied
in dev (also caught + fixed an unrelated audit-v3 follow-up: 0037
had `idx_br_interest` colliding with the existing
`berth_recommendations.idx_br_interest`; renamed to
`idx_brr_interest` / `idx_brr_contract_file`).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-05-05 13:46:54 +02:00
parent 687a1f1c2f
commit c4a41d5f5b
17 changed files with 234 additions and 30 deletions

View File

@@ -5,11 +5,7 @@ import { X, Filter, ChevronDown } from 'lucide-react';
import { Button } from '@/components/ui/button';
import { Input } from '@/components/ui/input';
import { Badge } from '@/components/ui/badge';
import {
Popover,
PopoverContent,
PopoverTrigger,
} from '@/components/ui/popover';
import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover';
import {
Select,
SelectContent,
@@ -20,13 +16,7 @@ import {
import { Checkbox } from '@/components/ui/checkbox';
import { Label } from '@/components/ui/label';
export type FilterType =
| 'text'
| 'select'
| 'multi-select'
| 'date-range'
| 'boolean'
| 'relation';
export type FilterType = 'text' | 'select' | 'multi-select' | 'date-range' | 'boolean' | 'relation';
export interface FilterOption {
label: string;
@@ -77,7 +67,9 @@ export function deserializeFiltersFromParams(
for (const def of definitions) {
const raw = params.get(def.key);
if (!raw) continue;
if (def.type === 'multi-select') {
if (def.type === 'multi-select' || def.type === 'relation') {
// `relation` types (e.g. tag-pickers rendered outside the FilterBar)
// also serialize as comma-joined arrays so the URL round-trips.
values[def.key] = raw.split(',');
} else if (def.type === 'boolean') {
values[def.key] = raw === 'true';
@@ -148,8 +140,10 @@ export function FilterBar({ filters, values, onChange, onClear }: FilterBarProps
const displayValue = Array.isArray(value)
? `${value.length} selected`
: typeof value === 'boolean'
? value ? 'Yes' : 'No'
: filter.options?.find((o) => o.value === String(value))?.label ?? String(value);
? value
? 'Yes'
: 'No'
: (filter.options?.find((o) => o.value === String(value))?.label ?? String(value));
return (
<Badge key={filter.key} variant="secondary" className="h-7 gap-1 px-2 font-normal">
@@ -194,10 +188,7 @@ function FilterField({
return (
<div className="space-y-1">
<Label className="text-xs">{definition.label}</Label>
<Select
value={(value as string) ?? ''}
onValueChange={(v) => onChange(v || undefined)}
>
<Select value={(value as string) ?? ''} onValueChange={(v) => onChange(v || undefined)}>
<SelectTrigger className="h-8">
<SelectValue placeholder={definition.placeholder ?? 'Any'} />
</SelectTrigger>