fix(audit): wire 6 missing email subject overrides (R2-H14)

Admin-editable subject overrides at /admin/email-templates were no-ops
for 6 of 8 templates — only portal_activation and portal_reset called
loadSubjectOverride. Added a shared resolveSubject() helper and wired
it into the missing senders:

- crm_invite + portal_invite_resend (crm-invite.service.ts)
- inquiry_client_confirmation (email worker via portId on job payload)
- inquiry_sales_notification (email worker via portId on job payload)
- residential_inquiry_client_confirmation (residential-inquiries route)
- residential_inquiry_sales_alert (residential-inquiries route)

The inquiry email worker payloads now carry portId + portName so the
worker can resolve the per-port override; producers in inquiry-
notifications.service.ts pass them through.

1175/1175 vitest passing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-05-06 22:26:41 +02:00
parent 59b9e8f177
commit c312cd3685
5 changed files with 126 additions and 17 deletions

View File

@@ -11,6 +11,7 @@ import {
residentialClientConfirmation,
residentialSalesAlert,
} from '@/lib/email/templates/residential-inquiry';
import { resolveSubject } from '@/lib/email/resolve-subject';
import { env } from '@/lib/env';
import { errorResponse, RateLimitError, ValidationError } from '@/lib/errors';
import { logger } from '@/lib/logger';
@@ -145,7 +146,13 @@ async function sendResidentialNotifications(args: {
firstName: data.firstName,
contactEmail: 'sales@portnimara.com',
});
await sendEmail(data.email, confirmation.subject, confirmation.html);
const confirmationSubject = await resolveSubject({
key: 'residential_inquiry_client_confirmation',
portId,
fallback: confirmation.subject,
tokens: { portName: 'Port Nimara', recipientName: data.firstName },
});
await sendEmail(data.email, confirmationSubject, confirmation.html);
// Sales-team alert - pull recipients from system_settings if configured;
// fall back to the inquiry_contact_email if available.
@@ -184,6 +191,17 @@ async function sendResidentialNotifications(args: {
preferences: data.preferences,
crmDeepLink,
});
const alertSubject = await resolveSubject({
key: 'residential_inquiry_sales_alert',
portId,
fallback: alert.subject,
tokens: {
portName: 'Port Nimara',
clientName: `${data.firstName} ${data.lastName}`.trim(),
email: data.email,
phone: data.phone,
},
});
await sendEmail(recipients, alert.subject, alert.html);
await sendEmail(recipients, alertSubject, alert.html);
}