refactor(sales): consolidate pipeline stages + wire EOI auto-advance
The 8→9 stage refresh from earlier today only updated constants.ts and the DB —
20 component/service files still hardcoded the old enum, leaving labels blank,
filter dropdowns wrong, kanban columns mismatched, and the analytics funnel
silently dropping new-stage rows. The platform also never advanced
pipelineStage on EOI lifecycle events: documents.service.ts wrote eoiStatus
but left the user-visible stage stuck.
This commit closes both gaps:
1. Single source of truth in src/lib/constants.ts — adds STAGE_LABELS,
STAGE_BADGE, STAGE_DOT, STAGE_WEIGHTS, STAGE_TRANSITIONS plus
stageLabel / stageBadgeClass / stageDotClass / safeStage /
canTransitionStage helpers. components/clients/pipeline-constants.ts
becomes a re-export shim so existing imports keep working.
2. 18 stale-enum surfaces migrated — interest list (table, card, filters,
form, stage picker), pipeline board, client card, berth interests tab,
portal client interests page, dashboard pipeline / funnel / revenue-
forecast charts, settings pipeline_weights default, dashboard.service
weights, analytics.service funnel stages, alert-rules stale-interest
filter, interest-scoring stage rank.
3. Documents tab wired into interest detail — replaced the placeholder in
interest-tabs.tsx with InterestDocumentsTab + InterestFilesTab so the
EOI launcher is back where salespeople work.
4. Auto-advance — new advanceStageIfBehind() in interests.service.ts
(forward-only, no-op if interest is already past the target). Called
from documents.service.ts on send (→ eoi_sent), Documenso completed
webhook (→ eoi_signed), and manual signed-EOI upload (→ eoi_signed).
5. Transition guard — canTransitionStage() blocks egregious skips
(e.g. completed → open, open → contract_signed). Enforced in
changeInterestStage before the DB write.
Tests updated to reflect the 9-stage model. tsc clean, vitest 832/832,
ESLint clean on every file touched.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -30,7 +30,14 @@ describe('analytics service', () => {
|
||||
const port = await makePort();
|
||||
const client = await makeClient({ portId: port.id });
|
||||
// 3 open, 2 details_sent, 1 visited
|
||||
for (const stage of ['open', 'open', 'open', 'details_sent', 'details_sent', 'visited']) {
|
||||
for (const stage of [
|
||||
'open',
|
||||
'open',
|
||||
'open',
|
||||
'details_sent',
|
||||
'details_sent',
|
||||
'in_communication',
|
||||
]) {
|
||||
await db.insert(interests).values({
|
||||
portId: port.id,
|
||||
clientId: client.id,
|
||||
@@ -42,7 +49,7 @@ describe('analytics service', () => {
|
||||
|
||||
const open = result.stages.find((s) => s.stage === 'open');
|
||||
const details = result.stages.find((s) => s.stage === 'details_sent');
|
||||
const visited = result.stages.find((s) => s.stage === 'visited');
|
||||
const visited = result.stages.find((s) => s.stage === 'in_communication');
|
||||
expect(open?.count).toBe(3);
|
||||
expect(open?.conversionPct).toBe(100);
|
||||
expect(details?.count).toBe(2);
|
||||
@@ -54,7 +61,7 @@ describe('analytics service', () => {
|
||||
it('returns zeros when port has no interests', async () => {
|
||||
const port = await makePort();
|
||||
const result = await computePipelineFunnel(port.id, '30d');
|
||||
expect(result.stages).toHaveLength(8);
|
||||
expect(result.stages).toHaveLength(9);
|
||||
expect(result.stages.every((s) => s.count === 0)).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user