refactor(sales): consolidate pipeline stages + wire EOI auto-advance

The 8→9 stage refresh from earlier today only updated constants.ts and the DB —
20 component/service files still hardcoded the old enum, leaving labels blank,
filter dropdowns wrong, kanban columns mismatched, and the analytics funnel
silently dropping new-stage rows. The platform also never advanced
pipelineStage on EOI lifecycle events: documents.service.ts wrote eoiStatus
but left the user-visible stage stuck.

This commit closes both gaps:

  1. Single source of truth in src/lib/constants.ts — adds STAGE_LABELS,
     STAGE_BADGE, STAGE_DOT, STAGE_WEIGHTS, STAGE_TRANSITIONS plus
     stageLabel / stageBadgeClass / stageDotClass / safeStage /
     canTransitionStage helpers. components/clients/pipeline-constants.ts
     becomes a re-export shim so existing imports keep working.

  2. 18 stale-enum surfaces migrated — interest list (table, card, filters,
     form, stage picker), pipeline board, client card, berth interests tab,
     portal client interests page, dashboard pipeline / funnel / revenue-
     forecast charts, settings pipeline_weights default, dashboard.service
     weights, analytics.service funnel stages, alert-rules stale-interest
     filter, interest-scoring stage rank.

  3. Documents tab wired into interest detail — replaced the placeholder in
     interest-tabs.tsx with InterestDocumentsTab + InterestFilesTab so the
     EOI launcher is back where salespeople work.

  4. Auto-advance — new advanceStageIfBehind() in interests.service.ts
     (forward-only, no-op if interest is already past the target). Called
     from documents.service.ts on send (→ eoi_sent), Documenso completed
     webhook (→ eoi_signed), and manual signed-EOI upload (→ eoi_signed).

  5. Transition guard — canTransitionStage() blocks egregious skips
     (e.g. completed → open, open → contract_signed). Enforced in
     changeInterestStage before the DB write.

Tests updated to reflect the 9-stage model. tsc clean, vitest 832/832,
ESLint clean on every file touched.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/lib/services/interests.service.ts

@@ -14,6 +14,7 @@ import { setEntityTags } from '@/lib/services/entity-tags.helper';
 import { buildListQuery } from '@/lib/db/query-builder';
 import { diffEntity } from '@/lib/entity-diff';
 import { softDelete, restore, withTransaction } from '@/lib/db/utils';
+import { PIPELINE_STAGES, canTransitionStage, type PipelineStage } from '@/lib/constants';
 import type {
   CreateInterestInput,
   UpdateInterestInput,
@@ -459,6 +460,15 @@ export async function changeInterestStage(
     throw new ValidationError('yachtId is required before leaving stage=open');
   }
 
+  // Block egregious skips. The transition table allows reasonable forward
+  // jumps (e.g. open → eoi_sent) while rejecting things like completed → open
+  // or open → contract_signed. Same-stage no-ops are allowed.
+  if (!canTransitionStage(existing.pipelineStage, data.pipelineStage)) {
+    throw new ValidationError(
+      `Cannot move interest from "${existing.pipelineStage}" directly to "${data.pipelineStage}".`,
+    );
+  }
+
   const oldStage = existing.pipelineStage;
 
   const [updated] = await db
@@ -469,9 +479,11 @@ export async function changeInterestStage(
 
   // BR-133: Auto-populate milestones based on stage
   const milestoneUpdates: Record<string, unknown> = {};
-  if (data.pipelineStage === 'signed_eoi_nda') milestoneUpdates.dateEoiSigned = new Date();
-  if (data.pipelineStage === 'contract') milestoneUpdates.dateContractSigned = new Date();
+  if (data.pipelineStage === 'eoi_sent') milestoneUpdates.dateEoiSent = new Date();
+  if (data.pipelineStage === 'eoi_signed') milestoneUpdates.dateEoiSigned = new Date();
   if (data.pipelineStage === 'deposit_10pct') milestoneUpdates.dateDepositReceived = new Date();
+  if (data.pipelineStage === 'contract_sent') milestoneUpdates.dateContractSent = new Date();
+  if (data.pipelineStage === 'contract_signed') milestoneUpdates.dateContractSigned = new Date();
   if (Object.keys(milestoneUpdates).length > 0) {
     await db
       .update(interests)
@@ -527,6 +539,45 @@ export async function changeInterestStage(
   return updated!;
 }
 
+// ─── Advance Stage If Behind ─────────────────────────────────────────────────
+//
+// Moves an interest forward to `target` if (and only if) it is currently behind
+// it in the pipeline order. Used by lifecycle events (EOI sent, EOI signed,
+// deposit recorded, contract signed) so the user-visible stage tracks reality
+// without overwriting a more advanced state — e.g. a late-arriving signed-EOI
+// webhook on an interest that has already moved on to `contract_sent` is a
+// no-op rather than a regression.
+//
+// Returns true when the stage was changed.
+export async function advanceStageIfBehind(
+  interestId: string,
+  portId: string,
+  target: PipelineStage,
+  meta: AuditMeta,
+  reason?: string,
+): Promise<boolean> {
+  const existing = await db.query.interests.findFirst({
+    where: and(eq(interests.id, interestId), eq(interests.portId, portId)),
+  });
+  if (!existing) return false;
+
+  const currentIdx = PIPELINE_STAGES.indexOf(existing.pipelineStage as PipelineStage);
+  const targetIdx = PIPELINE_STAGES.indexOf(target);
+  if (currentIdx === -1 || targetIdx === -1 || currentIdx >= targetIdx) {
+    return false;
+  }
+
+  // yachtId gate: changeInterestStage requires a yacht before leaving `open`.
+  // EOI events imply a yacht is in the picture, but if the data is missing we
+  // bail rather than throw — the EOI itself shouldn't fail because of this.
+  if (existing.pipelineStage === 'open' && !existing.yachtId) {
+    return false;
+  }
+
+  await changeInterestStage(interestId, portId, { pipelineStage: target, reason }, meta);
+  return true;
+}
+
 // ─── Archive / Restore ────────────────────────────────────────────────────────
 
 export async function archiveInterest(id: string, portId: string, meta: AuditMeta) {