refactor(sales): consolidate pipeline stages + wire EOI auto-advance

The 8→9 stage refresh from earlier today only updated constants.ts and the DB —
20 component/service files still hardcoded the old enum, leaving labels blank,
filter dropdowns wrong, kanban columns mismatched, and the analytics funnel
silently dropping new-stage rows. The platform also never advanced
pipelineStage on EOI lifecycle events: documents.service.ts wrote eoiStatus
but left the user-visible stage stuck.

This commit closes both gaps:

  1. Single source of truth in src/lib/constants.ts — adds STAGE_LABELS,
     STAGE_BADGE, STAGE_DOT, STAGE_WEIGHTS, STAGE_TRANSITIONS plus
     stageLabel / stageBadgeClass / stageDotClass / safeStage /
     canTransitionStage helpers. components/clients/pipeline-constants.ts
     becomes a re-export shim so existing imports keep working.

  2. 18 stale-enum surfaces migrated — interest list (table, card, filters,
     form, stage picker), pipeline board, client card, berth interests tab,
     portal client interests page, dashboard pipeline / funnel / revenue-
     forecast charts, settings pipeline_weights default, dashboard.service
     weights, analytics.service funnel stages, alert-rules stale-interest
     filter, interest-scoring stage rank.

  3. Documents tab wired into interest detail — replaced the placeholder in
     interest-tabs.tsx with InterestDocumentsTab + InterestFilesTab so the
     EOI launcher is back where salespeople work.

  4. Auto-advance — new advanceStageIfBehind() in interests.service.ts
     (forward-only, no-op if interest is already past the target). Called
     from documents.service.ts on send (→ eoi_sent), Documenso completed
     webhook (→ eoi_signed), and manual signed-EOI upload (→ eoi_signed).

  5. Transition guard — canTransitionStage() blocks egregious skips
     (e.g. completed → open, open → contract_signed). Enforced in
     changeInterestStage before the DB write.

Tests updated to reflect the 9-stage model. tsc clean, vitest 832/832,
ESLint clean on every file touched.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-05-01 23:33:53 +02:00
parent 0d357731ad
commit 886119cbde
26 changed files with 577 additions and 419 deletions

View File

@@ -862,11 +862,9 @@ export async function seedPortData(portId: string, portSlug: string): Promise<Se
// ── 7. Interests (15) ──────────────────────────────────────────────────
// Spread across pipeline stages.
// Valid stages (from interests schema comment):
// open, details_sent, in_communication, visited, signed_eoi_nda,
// deposit_10pct, contract, completed
// The task spec mentions "open, qualified, hot, won, lost" as logical buckets;
// map those loosely onto actual stages so we cover variety.
// Valid stages (see PIPELINE_STAGES in src/lib/constants.ts):
// open, details_sent, in_communication, eoi_sent, eoi_signed,
// deposit_10pct, contract_sent, contract_signed, completed
const interestPlan: Array<{
clientIdx: number;
berthIdx: number | null;
@@ -875,10 +873,11 @@ export async function seedPortData(portId: string, portSlug: string): Promise<Se
| 'open'
| 'details_sent'
| 'in_communication'
| 'visited'
| 'signed_eoi_nda'
| 'eoi_sent'
| 'eoi_signed'
| 'deposit_10pct'
| 'contract'
| 'contract_sent'
| 'contract_signed'
| 'completed';
leadCategory: 'general_interest' | 'specific_qualified' | 'hot_lead';
source: 'website' | 'manual' | 'referral' | 'broker';
@@ -916,7 +915,7 @@ export async function seedPortData(portId: string, portSlug: string): Promise<Se
clientIdx: 3,
berthIdx: 3,
yachtIdx: 6,
pipelineStage: 'visited',
pipelineStage: 'eoi_sent',
leadCategory: 'specific_qualified',
source: 'referral',
daysAgoFirst: 40,
@@ -934,7 +933,7 @@ export async function seedPortData(portId: string, portSlug: string): Promise<Se
clientIdx: 5,
berthIdx: 5,
yachtIdx: 3,
pipelineStage: 'signed_eoi_nda',
pipelineStage: 'eoi_signed',
leadCategory: 'hot_lead',
source: 'manual',
daysAgoFirst: 55,
@@ -952,7 +951,7 @@ export async function seedPortData(portId: string, portSlug: string): Promise<Se
clientIdx: 0,
berthIdx: 7,
yachtIdx: 5,
pipelineStage: 'contract',
pipelineStage: 'contract_signed',
leadCategory: 'hot_lead',
source: 'broker',
daysAgoFirst: 90,
@@ -1017,7 +1016,7 @@ export async function seedPortData(portId: string, portSlug: string): Promise<Se
clientIdx: 6,
berthIdx: 9,
yachtIdx: 4,
pipelineStage: 'visited',
pipelineStage: 'eoi_sent',
leadCategory: 'specific_qualified',
source: 'broker',
daysAgoFirst: 45,