feat(documents): folder tree + actions UI for system-managed folders

FolderTreeSidebar shows a lock marker on system_managed rows and renders
archived entity folders muted. FolderActionsMenu disables Rename /
Move / Delete with a tooltip explanation when a system folder is
selected; the server-side guard (Task 4) is the authoritative
rejection — the UI is the friendly first line.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-11 12:34:10 +02:00
parent 13fe3841d1
commit 7f85128dc2
2 changed files with 83 additions and 37 deletions

View File

@@ -21,14 +21,30 @@ import {
import { Input } from '@/components/ui/input'; import { Input } from '@/components/ui/input';
import { Label } from '@/components/ui/label'; import { Label } from '@/components/ui/label';
import { ConfirmationDialog } from '@/components/shared/confirmation-dialog'; import { ConfirmationDialog } from '@/components/shared/confirmation-dialog';
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from '@/components/ui/tooltip';
import { toastError } from '@/lib/api/toast-error'; import { toastError } from '@/lib/api/toast-error';
import { import {
useCreateFolder, useCreateFolder,
useDeleteFolder, useDeleteFolder,
useRenameFolder, useRenameFolder,
useDocumentFolders, useDocumentFolders,
type FolderNode,
} from '@/hooks/use-document-folders'; } from '@/hooks/use-document-folders';
function findInTree(nodes: FolderNode[], id: string): FolderNode | null {
for (const node of nodes) {
if (node.id === id) return node;
const found = findInTree(node.children, id);
if (found) return found;
}
return null;
}
interface FolderActionsMenuProps { interface FolderActionsMenuProps {
/** The folder these actions apply to. `null` means root → only the /** The folder these actions apply to. `null` means root → only the
* Create-new-folder action is available. */ * Create-new-folder action is available. */
@@ -61,6 +77,9 @@ export function FolderActionsMenu({ selectedFolderId, onAfterDelete }: FolderAct
return find(tree) ?? ''; return find(tree) ?? '';
})(); })();
const selectedNode = isFolderSelected ? findInTree(tree, selectedFolderId as string) : null;
const isSystem = selectedNode?.systemManaged ?? false;
return ( return (
<> <>
<DropdownMenu> <DropdownMenu>
@@ -81,9 +100,14 @@ export function FolderActionsMenu({ selectedFolderId, onAfterDelete }: FolderAct
New folder {isFolderSelected ? 'inside this' : 'at root'} New folder {isFolderSelected ? 'inside this' : 'at root'}
</DropdownMenuItem> </DropdownMenuItem>
{isFolderSelected ? ( {isFolderSelected ? (
<> <TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
<span>
<DropdownMenuItem <DropdownMenuItem
disabled={isSystem}
onClick={() => { onClick={() => {
if (isSystem) return;
setName(currentName); setName(currentName);
setRenameOpen(true); setRenameOpen(true);
}} }}
@@ -91,9 +115,19 @@ export function FolderActionsMenu({ selectedFolderId, onAfterDelete }: FolderAct
<Pencil className="mr-2 h-4 w-4" /> <Pencil className="mr-2 h-4 w-4" />
Rename Rename
</DropdownMenuItem> </DropdownMenuItem>
</span>
</TooltipTrigger>
{isSystem ? (
<TooltipContent>System folders can&apos;t be renamed.</TooltipContent>
) : null}
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<span>
<ConfirmationDialog <ConfirmationDialog
trigger={ trigger={
<DropdownMenuItem <DropdownMenuItem
disabled={isSystem}
onSelect={(e) => e.preventDefault()} onSelect={(e) => e.preventDefault()}
className="text-destructive" className="text-destructive"
> >
@@ -115,7 +149,13 @@ export function FolderActionsMenu({ selectedFolderId, onAfterDelete }: FolderAct
} }
}} }}
/> />
</> </span>
</TooltipTrigger>
{isSystem ? (
<TooltipContent>System folders can&apos;t be deleted.</TooltipContent>
) : null}
</Tooltip>
</TooltipProvider>
) : null} ) : null}
</DropdownMenuContent> </DropdownMenuContent>
</DropdownMenu> </DropdownMenu>

View File

@@ -1,7 +1,7 @@
'use client'; 'use client';
import { useState } from 'react'; import { useState } from 'react';
import { ChevronRight, Folder, FolderOpen, Inbox } from 'lucide-react'; import { ChevronRight, Folder, FolderOpen, Inbox, Lock } from 'lucide-react';
import { Button } from '@/components/ui/button'; import { Button } from '@/components/ui/button';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
@@ -135,7 +135,10 @@ function FolderRow({
<button <button
type="button" type="button"
onClick={() => onSelect(node.id)} onClick={() => onSelect(node.id)}
className="flex flex-1 items-center gap-1.5 truncate text-left" className={cn(
'flex flex-1 items-center gap-1.5 truncate text-left',
node.archivedAt != null && 'text-muted-foreground',
)}
> >
{open && hasChildren ? ( {open && hasChildren ? (
<FolderOpen className="h-4 w-4 shrink-0" /> <FolderOpen className="h-4 w-4 shrink-0" />
@@ -143,6 +146,9 @@ function FolderRow({
<Folder className="h-4 w-4 shrink-0" /> <Folder className="h-4 w-4 shrink-0" />
)} )}
<span className="truncate">{node.name}</span> <span className="truncate">{node.name}</span>
{node.systemManaged ? (
<Lock className="ml-1 h-3 w-3 shrink-0 text-muted-foreground" aria-label="System folder" />
) : null}
</button> </button>
</div> </div>
{open {open