feat(pipeline): 9→7 stage refactor + v1.1 hardening wave
Replaces the legacy 9-stage pipeline with 7 canonical stages
(enquiry → qualified → eoi → reservation → deposit_paid → contract →
nurturing) plus three doc sub-status columns (eoi_doc_status,
reservation_doc_status, contract_doc_status) that track sent/signed
within a single stage instead of branching it.
Schema (migration 0062):
- interests gains assigned_to, deposit_expected_amount/currency,
three doc-status columns, two documenso-id columns, and
date_reservation_signed.
- New tables: qualification_criteria (per-port admin-configurable),
interest_qualifications (per-interest state), payments (deposit /
balance / refund records keyed to interest + client).
- Default qualification criteria seeded for every existing port.
- Dummy-data UPDATEs collapse Sent/Signed pairs and 'completed' into
the new stage + doc-status + outcome shape.
Migration 0063 adds interest_contact_log.voice_transcript and
template_used columns for v1.1-A/B (quick-template buttons + voice
transcription via Web Speech API).
v1.1 phase work bundled here:
- A/B: Quick-template buttons (Call / Visit / Email) + mic toggle on
the contact-log compose dialog (useVoiceTranscription hook).
- C: berth-rules-engine wraps state writes in pg_advisory_xact_lock
with an idempotent re-read; emits rule_evaluated audit traces.
- D: Documenso webhook: reservation/contract sub-status stamping
moved out of the PDF-download try-block so a download failure
no longer swallows the stamp. New integration test coverage.
- E: /admin/qualification-criteria CRUD page + admin component.
- F: default_new_interest_owner exposed in System Settings.
- G: recentActivityCount + active_engagement deal-pulse signal
surfaced as a chip on interests + hot-deals card.
- H: interest_assigned notification on assignedTo change (skips
self-assign, uses a dedupe key).
Plus the supporting components: AssignedToChip, DealPulseChip,
PaymentsSection, QualificationChecklist, MultiEoiChip,
SkipAheadBanner, WonStatusPanel, InterestBerthStatusBanner,
SupplementalInfoRequestButton, UserPicker.
Tests: 1370/1370 vitest pass (added deal-health unit suite +
expanded constants/validators/pipeline-transitions coverage). tsc
clean, eslint clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -122,13 +122,20 @@ describe('Pipeline Transitions', () => {
|
||||
await cleanupPort(portId);
|
||||
});
|
||||
|
||||
itDb('advances through all 8 pipeline stages sequentially', async () => {
|
||||
itDb('advances through all 7 pipeline stages sequentially', async () => {
|
||||
const { changeInterestStage, getInterestById } =
|
||||
await import('@/lib/services/interests.service');
|
||||
const meta = makeAuditMeta({ portId });
|
||||
|
||||
for (const stage of PIPELINE_STAGES) {
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: stage }, meta);
|
||||
// Skip-ahead jumps are blocked unless override=true; the test runs
|
||||
// through each stage so we override consistently.
|
||||
await changeInterestStage(
|
||||
interestId,
|
||||
portId,
|
||||
{ pipelineStage: stage, override: true, reason: 'sequential walk for test' },
|
||||
meta,
|
||||
);
|
||||
|
||||
const updated = await getInterestById(interestId, portId);
|
||||
expect(updated.pipelineStage).toBe(stage);
|
||||
@@ -139,7 +146,7 @@ describe('Pipeline Transitions', () => {
|
||||
const { changeInterestStage } = await import('@/lib/services/interests.service');
|
||||
const meta = makeAuditMeta({ portId });
|
||||
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'open' }, meta);
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'enquiry' }, meta);
|
||||
|
||||
// Allow async audit log to flush
|
||||
await new Promise((r) => setTimeout(r, 100));
|
||||
@@ -150,49 +157,74 @@ describe('Pipeline Transitions', () => {
|
||||
expect(log!.entity_type).toBe('interest');
|
||||
|
||||
const newValue = log!.new_value as Record<string, unknown>;
|
||||
expect(newValue.pipelineStage).toBe('open');
|
||||
expect(newValue.pipelineStage).toBe('enquiry');
|
||||
});
|
||||
|
||||
itDb('backward transition: completed → open is permitted', async () => {
|
||||
itDb('backward transition: contract → enquiry is permitted with override', async () => {
|
||||
const { changeInterestStage, getInterestById } =
|
||||
await import('@/lib/services/interests.service');
|
||||
const meta = makeAuditMeta({ portId });
|
||||
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'completed' }, meta);
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'open' }, meta);
|
||||
await changeInterestStage(
|
||||
interestId,
|
||||
portId,
|
||||
{ pipelineStage: 'contract', override: true, reason: 'jump for backward test' },
|
||||
meta,
|
||||
);
|
||||
await changeInterestStage(
|
||||
interestId,
|
||||
portId,
|
||||
{ pipelineStage: 'enquiry', override: true, reason: 'backward rewind for test' },
|
||||
meta,
|
||||
);
|
||||
|
||||
const updated = await getInterestById(interestId, portId);
|
||||
expect(updated.pipelineStage).toBe('open');
|
||||
expect(updated.pipelineStage).toBe('enquiry');
|
||||
});
|
||||
|
||||
itDb('BR-133: advancing to signed_eoi_nda auto-populates dateEoiSigned', async () => {
|
||||
itDb('BR-133: advancing to eoi auto-populates dateEoiSent', async () => {
|
||||
const { changeInterestStage, getInterestById } =
|
||||
await import('@/lib/services/interests.service');
|
||||
const meta = makeAuditMeta({ portId });
|
||||
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'eoi_signed' }, meta);
|
||||
await changeInterestStage(
|
||||
interestId,
|
||||
portId,
|
||||
{ pipelineStage: 'eoi', override: true, reason: 'milestone backfill test' },
|
||||
meta,
|
||||
);
|
||||
|
||||
const updated = await getInterestById(interestId, portId);
|
||||
expect(updated.dateEoiSigned).not.toBeNull();
|
||||
expect(updated.dateEoiSent).not.toBeNull();
|
||||
});
|
||||
|
||||
itDb('BR-133: advancing to contract auto-populates dateContractSigned', async () => {
|
||||
itDb('BR-133: advancing to contract auto-populates dateContractSent', async () => {
|
||||
const { changeInterestStage, getInterestById } =
|
||||
await import('@/lib/services/interests.service');
|
||||
const meta = makeAuditMeta({ portId });
|
||||
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'contract_signed' }, meta);
|
||||
await changeInterestStage(
|
||||
interestId,
|
||||
portId,
|
||||
{ pipelineStage: 'contract', override: true, reason: 'milestone backfill test' },
|
||||
meta,
|
||||
);
|
||||
|
||||
const updated = await getInterestById(interestId, portId);
|
||||
expect(updated.dateContractSigned).not.toBeNull();
|
||||
expect(updated.dateContractSent).not.toBeNull();
|
||||
});
|
||||
|
||||
itDb('BR-133: advancing to deposit_10pct auto-populates dateDepositReceived', async () => {
|
||||
itDb('BR-133: advancing to deposit_paid auto-populates dateDepositReceived', async () => {
|
||||
const { changeInterestStage, getInterestById } =
|
||||
await import('@/lib/services/interests.service');
|
||||
const meta = makeAuditMeta({ portId });
|
||||
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'deposit_10pct' }, meta);
|
||||
await changeInterestStage(
|
||||
interestId,
|
||||
portId,
|
||||
{ pipelineStage: 'deposit_paid', override: true, reason: 'milestone backfill test' },
|
||||
meta,
|
||||
);
|
||||
|
||||
const updated = await getInterestById(interestId, portId);
|
||||
expect(updated.dateDepositReceived).not.toBeNull();
|
||||
@@ -205,12 +237,12 @@ describe('Pipeline Transitions', () => {
|
||||
|
||||
vi.clearAllMocks();
|
||||
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'details_sent' }, meta);
|
||||
await changeInterestStage(interestId, portId, { pipelineStage: 'qualified' }, meta);
|
||||
|
||||
expect(emitToRoom).toHaveBeenCalledWith(
|
||||
`port:${portId}`,
|
||||
'interest:stageChanged',
|
||||
expect.objectContaining({ interestId, newStage: 'details_sent' }),
|
||||
expect.objectContaining({ interestId, newStage: 'qualified' }),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user