fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish
Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -67,7 +67,14 @@ export async function loadEoiTemplatePdf(): Promise<Uint8Array> {
|
||||
|
||||
function formatAddress(address: EoiContext['client']['address']): string {
|
||||
if (!address) return '';
|
||||
return [address.street, address.city, address.country].filter(Boolean).join(', ');
|
||||
// EOI's Address field renders as: "street, city, REGION, postal, COUNTRY"
|
||||
// with REGION as the ISO-3166-2 suffix (e.g. NY) and COUNTRY as the
|
||||
// alpha-2 code (e.g. US) so the line fits in the PDF box. The separate
|
||||
// `Nationality` PDF field has been retired — the resident's country code
|
||||
// here is the canonical replacement.
|
||||
return [address.street, address.city, address.subdivision, address.postalCode, address.countryIso]
|
||||
.filter(Boolean)
|
||||
.join(', ');
|
||||
}
|
||||
|
||||
function setText(form: ReturnType<PDFDocument['getForm']>, name: string, value: string): void {
|
||||
@@ -120,6 +127,7 @@ function setCheckbox(
|
||||
export async function fillEoiFormFields(
|
||||
pdfBytes: Uint8Array,
|
||||
context: EoiContext,
|
||||
options?: { dimensionUnit?: 'ft' | 'm' },
|
||||
): Promise<Uint8Array> {
|
||||
const doc = await PDFDocument.load(pdfBytes);
|
||||
const form = doc.getForm();
|
||||
@@ -128,11 +136,20 @@ export async function fillEoiFormFields(
|
||||
setText(form, 'Email', context.client.primaryEmail ?? '');
|
||||
setText(form, 'Address', formatAddress(context.client.address));
|
||||
// Yacht + berth (EOI Section 3) are optional - leave the AcroForm fields
|
||||
// blank when the interest hasn't been linked to either.
|
||||
// blank when the interest hasn't been linked to either. Dimension side
|
||||
// (ft|m) honours the drawer's toggle; legacy callers omit and get ft.
|
||||
setText(form, 'Yacht Name', context.yacht?.name ?? '');
|
||||
setText(form, 'Length', context.yacht?.lengthFt ?? '');
|
||||
setText(form, 'Width', context.yacht?.widthFt ?? '');
|
||||
setText(form, 'Draft', context.yacht?.draftFt ?? '');
|
||||
const dimUnit: 'ft' | 'm' = options?.dimensionUnit ?? context.yacht?.lengthUnit ?? 'ft';
|
||||
const yLen = dimUnit === 'ft' ? context.yacht?.lengthFt : context.yacht?.lengthM;
|
||||
const yWid = dimUnit === 'ft' ? context.yacht?.widthFt : context.yacht?.widthM;
|
||||
const yDra = dimUnit === 'ft' ? context.yacht?.draftFt : context.yacht?.draftM;
|
||||
// Append the unit suffix so the rendered EOI reads "45 ft" / "13.7 m"
|
||||
// rather than the bare number — matches the Documenso pathway.
|
||||
const withDimUnit = (v: string | null | undefined): string =>
|
||||
v && String(v).trim() ? `${String(v).trim()} ${dimUnit}` : '';
|
||||
setText(form, 'Length', withDimUnit(yLen));
|
||||
setText(form, 'Width', withDimUnit(yWid));
|
||||
setText(form, 'Draft', withDimUnit(yDra));
|
||||
// Berth Number = compact range for multi-berth, primary mooring for
|
||||
// single-berth (formatBerthRange(['A1']) === 'A1' so single-berth is
|
||||
// byte-identical to the legacy primary-only path). The dedicated
|
||||
@@ -160,7 +177,10 @@ export async function fillEoiFormFields(
|
||||
/**
|
||||
* Convenience: loads the source PDF from disk and returns the filled bytes.
|
||||
*/
|
||||
export async function generateEoiPdfFromTemplate(context: EoiContext): Promise<Uint8Array> {
|
||||
export async function generateEoiPdfFromTemplate(
|
||||
context: EoiContext,
|
||||
options?: { dimensionUnit?: 'ft' | 'm' },
|
||||
): Promise<Uint8Array> {
|
||||
const bytes = await loadEoiTemplatePdf();
|
||||
return fillEoiFormFields(bytes, context);
|
||||
return fillEoiFormFields(bytes, context, options);
|
||||
}
|
||||
|
||||
35
src/lib/pdf/inspect-acroform.ts
Normal file
35
src/lib/pdf/inspect-acroform.ts
Normal file
@@ -0,0 +1,35 @@
|
||||
import { PDFDocument } from 'pdf-lib';
|
||||
|
||||
/**
|
||||
* Result of inspecting a PDF's AcroForm. Used by the Documenso template
|
||||
* sync flow to surface what AcroForm fields the operator's uploaded PDF
|
||||
* actually has — so the admin can verify their fillable PDF matches the
|
||||
* CRM's expected field-label set before any EOI is sent in anger.
|
||||
*/
|
||||
export interface AcroFormField {
|
||||
name: string;
|
||||
/**
|
||||
* `getType()` from pdf-lib's PDFField subclasses — usually one of
|
||||
* `PDFTextField`, `PDFCheckBox`, `PDFDropdown`, `PDFRadioGroup`,
|
||||
* `PDFSignature`, `PDFButton`. Exposed verbatim so the UI can show
|
||||
* the admin what each field expects at the AcroForm layer.
|
||||
*/
|
||||
type: string;
|
||||
}
|
||||
|
||||
/**
|
||||
* Parses the AcroForm in `pdfBytes` and returns one descriptor per form
|
||||
* field. Returns an empty array when the PDF has no AcroForm at all
|
||||
* (i.e. a flat / non-fillable PDF). Never throws on a missing form —
|
||||
* the caller treats "empty list" as a signal to nudge the operator
|
||||
* that their PDF isn't actually fillable.
|
||||
*/
|
||||
export async function inspectPdfAcroForm(pdfBytes: Buffer | Uint8Array): Promise<AcroFormField[]> {
|
||||
const doc = await PDFDocument.load(pdfBytes, { ignoreEncryption: true });
|
||||
const form = doc.getForm();
|
||||
const fields = form.getFields();
|
||||
return fields.map((f) => ({
|
||||
name: f.getName(),
|
||||
type: f.constructor.name,
|
||||
}));
|
||||
}
|
||||
Reference in New Issue
Block a user