fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish
Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
264
src/app/(dashboard)/[portSlug]/admin/pipeline-rules/page.tsx
Normal file
264
src/app/(dashboard)/[portSlug]/admin/pipeline-rules/page.tsx
Normal file
@@ -0,0 +1,264 @@
|
||||
'use client';
|
||||
|
||||
import { useEffect, useState } from 'react';
|
||||
import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query';
|
||||
import { Loader2, Save } from 'lucide-react';
|
||||
import { toast } from 'sonner';
|
||||
|
||||
import { PageHeader } from '@/components/shared/page-header';
|
||||
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card';
|
||||
import { Button } from '@/components/ui/button';
|
||||
import { Label } from '@/components/ui/label';
|
||||
import {
|
||||
Select,
|
||||
SelectContent,
|
||||
SelectItem,
|
||||
SelectTrigger,
|
||||
SelectValue,
|
||||
} from '@/components/ui/select';
|
||||
import { apiFetch } from '@/lib/api/client';
|
||||
import { toastError } from '@/lib/api/toast-error';
|
||||
|
||||
type Mode = 'auto' | 'suggest' | 'off';
|
||||
|
||||
const TRIGGERS: Array<{
|
||||
key: string;
|
||||
label: string;
|
||||
description: string;
|
||||
defaultMode: Mode;
|
||||
}> = [
|
||||
{
|
||||
key: 'eoi_sent',
|
||||
label: 'EOI sent',
|
||||
description: 'Rep generates an EOI for signing — moves the deal to "EOI" stage.',
|
||||
defaultMode: 'auto',
|
||||
},
|
||||
{
|
||||
key: 'eoi_signed',
|
||||
label: 'EOI signed (all parties)',
|
||||
description:
|
||||
'All signatories complete the EOI — moves the deal to "Reservation" stage. Conventional CRM behaviour.',
|
||||
defaultMode: 'auto',
|
||||
},
|
||||
{
|
||||
key: 'reservation_signed',
|
||||
label: 'Reservation agreement signed',
|
||||
description:
|
||||
'Reservation paperwork signed by all parties — keeps the deal at "Reservation" with sub-status signed.',
|
||||
defaultMode: 'auto',
|
||||
},
|
||||
{
|
||||
key: 'deposit_received',
|
||||
label: 'Deposit received in full',
|
||||
description:
|
||||
'Deposit total reaches the expected amount — moves the deal to "Deposit Paid" stage.',
|
||||
defaultMode: 'auto',
|
||||
},
|
||||
{
|
||||
key: 'contract_signed',
|
||||
label: 'Sales contract signed',
|
||||
description: 'Final contract signed by all parties — moves the deal to "Contract" stage.',
|
||||
defaultMode: 'auto',
|
||||
},
|
||||
];
|
||||
|
||||
const PRESETS = {
|
||||
aggressive: 'auto',
|
||||
conservative: 'suggest',
|
||||
} as const;
|
||||
type PresetName = keyof typeof PRESETS;
|
||||
|
||||
export default function PipelineRulesPage() {
|
||||
const queryClient = useQueryClient();
|
||||
const [rules, setRules] = useState<Record<string, Mode>>(() =>
|
||||
Object.fromEntries(TRIGGERS.map((t) => [t.key, t.defaultMode])),
|
||||
);
|
||||
|
||||
const { data, isLoading } = useQuery<{
|
||||
data: { values: Record<string, { value?: Record<string, Mode> | null }> };
|
||||
}>({
|
||||
queryKey: ['admin', 'settings', 'pipeline.auto_advance'],
|
||||
queryFn: () =>
|
||||
apiFetch<{
|
||||
data: { values: Record<string, { value?: Record<string, Mode> | null }> };
|
||||
}>('/api/v1/admin/settings/resolved?sections=pipeline.auto_advance'),
|
||||
});
|
||||
|
||||
// Hydrate the local form once the server-side state arrives. We treat
|
||||
// missing keys as the registered default — the page's persisted JSON
|
||||
// doesn't have to enumerate every trigger, just the overrides.
|
||||
useEffect(() => {
|
||||
const persisted = data?.data?.values?.stage_advance_rules?.value;
|
||||
if (!persisted || typeof persisted !== 'object') return;
|
||||
// eslint-disable-next-line react-hooks/set-state-in-effect
|
||||
setRules((prev) => {
|
||||
const next = { ...prev };
|
||||
for (const t of TRIGGERS) {
|
||||
const v = persisted[t.key];
|
||||
if (v === 'auto' || v === 'suggest' || v === 'off') next[t.key] = v;
|
||||
}
|
||||
return next;
|
||||
});
|
||||
}, [data]);
|
||||
|
||||
const saveMutation = useMutation({
|
||||
mutationFn: () =>
|
||||
apiFetch('/api/v1/admin/settings/stage_advance_rules', {
|
||||
method: 'PUT',
|
||||
body: { value: rules },
|
||||
}),
|
||||
onSuccess: () => {
|
||||
queryClient.invalidateQueries({ queryKey: ['admin', 'settings'] });
|
||||
toast.success('Pipeline rules saved.');
|
||||
},
|
||||
onError: (err) => toastError(err),
|
||||
});
|
||||
|
||||
const applyPreset = (preset: PresetName) => {
|
||||
const target = PRESETS[preset];
|
||||
setRules(Object.fromEntries(TRIGGERS.map((t) => [t.key, target])));
|
||||
};
|
||||
|
||||
const setMode = (key: string, mode: Mode) => {
|
||||
setRules((prev) => ({ ...prev, [key]: mode }));
|
||||
};
|
||||
|
||||
const allMatch = (mode: Mode) => TRIGGERS.every((t) => rules[t.key] === mode);
|
||||
const currentPreset: PresetName | 'custom' = allMatch('auto')
|
||||
? 'aggressive'
|
||||
: allMatch('suggest')
|
||||
? 'conservative'
|
||||
: 'custom';
|
||||
|
||||
return (
|
||||
<div className="space-y-6">
|
||||
<PageHeader
|
||||
title="Pipeline auto-advance rules"
|
||||
description="Control which lifecycle events (signing, payments) automatically advance the deal stage on the kanban. Choose a preset or fine-tune per trigger."
|
||||
/>
|
||||
|
||||
<Card>
|
||||
<CardHeader>
|
||||
<CardTitle className="text-base">Preset</CardTitle>
|
||||
</CardHeader>
|
||||
<CardContent className="space-y-3">
|
||||
<div className="grid gap-2 sm:grid-cols-3">
|
||||
<PresetButton
|
||||
name="aggressive"
|
||||
label="Aggressive (default)"
|
||||
description="Every trigger auto-advances the stage. Matches conventional CRM behaviour and saves rep clicks."
|
||||
active={currentPreset === 'aggressive'}
|
||||
onClick={() => applyPreset('aggressive')}
|
||||
/>
|
||||
<PresetButton
|
||||
name="conservative"
|
||||
label="Conservative"
|
||||
description="Every trigger sends a notification suggesting the move. Reps click Approve to advance."
|
||||
active={currentPreset === 'conservative'}
|
||||
onClick={() => applyPreset('conservative')}
|
||||
/>
|
||||
<div
|
||||
className={`rounded-lg border p-3 ${
|
||||
currentPreset === 'custom'
|
||||
? 'border-primary bg-primary/5'
|
||||
: 'border-muted bg-muted/20'
|
||||
}`}
|
||||
>
|
||||
<p className="text-sm font-semibold">Custom</p>
|
||||
<p className="text-xs text-muted-foreground">
|
||||
Mix and match — the per-trigger toggles below override the preset.
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
</CardContent>
|
||||
</Card>
|
||||
|
||||
<Card>
|
||||
<CardHeader>
|
||||
<CardTitle className="text-base">Per-trigger settings</CardTitle>
|
||||
</CardHeader>
|
||||
<CardContent className="space-y-4">
|
||||
{isLoading ? (
|
||||
<div className="flex items-center gap-2 text-sm text-muted-foreground">
|
||||
<Loader2 className="size-3.5 animate-spin" aria-hidden /> Loading…
|
||||
</div>
|
||||
) : (
|
||||
TRIGGERS.map((t) => (
|
||||
<div
|
||||
key={t.key}
|
||||
className="flex flex-col gap-2 rounded-md border p-3 sm:flex-row sm:items-center sm:justify-between"
|
||||
>
|
||||
<div className="flex-1">
|
||||
<p className="text-sm font-medium">{t.label}</p>
|
||||
<p className="text-xs text-muted-foreground">{t.description}</p>
|
||||
</div>
|
||||
<div className="flex items-center gap-2">
|
||||
<Label htmlFor={`mode-${t.key}`} className="sr-only">
|
||||
Mode
|
||||
</Label>
|
||||
<Select
|
||||
value={rules[t.key] ?? t.defaultMode}
|
||||
onValueChange={(v) => setMode(t.key, v as Mode)}
|
||||
>
|
||||
<SelectTrigger id={`mode-${t.key}`} className="w-40">
|
||||
<SelectValue />
|
||||
</SelectTrigger>
|
||||
<SelectContent>
|
||||
<SelectItem value="auto">Auto-advance</SelectItem>
|
||||
<SelectItem value="suggest">Suggest only</SelectItem>
|
||||
<SelectItem value="off">Off</SelectItem>
|
||||
</SelectContent>
|
||||
</Select>
|
||||
</div>
|
||||
</div>
|
||||
))
|
||||
)}
|
||||
</CardContent>
|
||||
</Card>
|
||||
|
||||
<div className="flex justify-end">
|
||||
<Button
|
||||
onClick={() => saveMutation.mutate()}
|
||||
disabled={saveMutation.isPending}
|
||||
className="gap-1.5 [&_svg]:size-3.5"
|
||||
>
|
||||
{saveMutation.isPending ? <Loader2 className="animate-spin" aria-hidden /> : <Save />}
|
||||
Save rules
|
||||
</Button>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
function PresetButton({
|
||||
name,
|
||||
label,
|
||||
description,
|
||||
active,
|
||||
onClick,
|
||||
}: {
|
||||
name: PresetName;
|
||||
label: string;
|
||||
description: string;
|
||||
active: boolean;
|
||||
onClick: () => void;
|
||||
}) {
|
||||
return (
|
||||
<button
|
||||
type="button"
|
||||
onClick={onClick}
|
||||
className={`rounded-lg border p-3 text-left transition-colors ${
|
||||
active
|
||||
? 'border-primary bg-primary/5 ring-2 ring-primary/40'
|
||||
: 'border-muted hover:border-foreground/30 hover:bg-muted/30'
|
||||
}`}
|
||||
aria-pressed={active}
|
||||
>
|
||||
<p className="text-sm font-semibold">{label}</p>
|
||||
<p className="text-xs text-muted-foreground">{description}</p>
|
||||
<p className="mt-1 text-[10px] uppercase tracking-wide text-muted-foreground">
|
||||
{name === 'aggressive' ? 'auto for all triggers' : 'suggest for all triggers'}
|
||||
</p>
|
||||
</button>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user