feat(portal): replace magic-link with email/password + admin-initiated activation
The client portal no longer uses passwordless / magic-link sign-in. Each
client now has a `portal_users` row with a scrypt-hashed password,
created by an admin from the client detail page; the admin's invite
mails an activation link that the client uses to set their own password.
Forgot-password is wired through the same token mechanism.
Schema (migration `0009_outgoing_rumiko_fujikawa.sql`):
- `portal_users` — one per client account, separate from the CRM
`users` table (better-auth) so the auth realms stay isolated. Email
is globally unique, password is null until activation.
- `portal_auth_tokens` — single-use activation / reset tokens. Stores
only the SHA-256 hash so a DB compromise never leaks live tokens.
Services:
- `src/lib/portal/passwords.ts` — scrypt hash/verify (no new deps;
uses node:crypto), token mint+hash helpers.
- `src/lib/services/portal-auth.service.ts` — createPortalUser,
resendActivation, activateAccount, signIn (timing-safe),
requestPasswordReset, resetPassword. Auth failures throw the new
UnauthorizedError (401); enumeration-safe behaviour everywhere.
Routes:
- POST /api/portal/auth/sign-in — sets the existing portal JWT cookie.
- POST /api/portal/auth/forgot-password — always 200.
- POST /api/portal/auth/reset-password — token + new password.
- POST /api/portal/auth/activate — token + initial password.
- POST /api/v1/clients/:id/portal-user — admin invite (and `?action=resend`).
- Removed: /api/portal/auth/request, /api/portal/auth/verify (magic link).
UI:
- /portal/login — replaced email-only magic-link form with email +
password + "forgot password" link.
- /portal/forgot-password, /portal/reset-password, /portal/activate — new.
- New shared `PasswordSetForm` component used by activate + reset.
- New `PortalInviteButton` rendered on the client detail header.
Email send:
- `createTransporter` now wires SMTP auth when SMTP_USER+SMTP_PASS are
set (gmail app-password or marina-server creds, configured via env).
- `SMTP_FROM` env var lets the sender address be overridden without
pinning it to `noreply@${SMTP_HOST}`.
Tests:
- Smoke spec 17 (client-portal) updated to the new flow: 7/7 green.
- Smoke specs 02-crud-spine, 05-invoices, 20-critical-path updated to
match the post-refactor client + invoice forms (drop companyName,
use OwnerPicker + billingEmail).
- Vitest 652/652 still green; type-check clean.
Drops the dead `requestMagicLink` from portal.service.ts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
import { test, expect } from '@playwright/test';
|
||||
import { login, navigateTo, PORT_SLUG } from './helpers';
|
||||
import { login, navigateTo, apiHeaders, PORT_SLUG } from './helpers';
|
||||
|
||||
test.describe('Invoicing', () => {
|
||||
test.beforeEach(async ({ page }) => {
|
||||
@@ -15,18 +15,40 @@ test.describe('Invoicing', () => {
|
||||
});
|
||||
|
||||
test('create a new invoice with 3 line items', async ({ page }) => {
|
||||
// Seed a client via API to pick in the billing-entity picker.
|
||||
const clientName = `Invoice Test Client ${Date.now()}`;
|
||||
const createRes = await page.request.post('/api/v1/clients', {
|
||||
headers: await apiHeaders(page),
|
||||
data: {
|
||||
fullName: clientName,
|
||||
contacts: [{ channel: 'email', value: 'billing@test.com', isPrimary: true }],
|
||||
},
|
||||
});
|
||||
expect(createRes.ok(), `client create returned ${createRes.status()}`).toBe(true);
|
||||
|
||||
await navigateTo(page, '/invoices');
|
||||
await page.waitForLoadState('networkidle');
|
||||
|
||||
// Click "New Invoice" (use first() for strict mode)
|
||||
const newBtn = page.getByRole('link', { name: /new invoice/i }).first()
|
||||
const newBtn = page
|
||||
.getByRole('link', { name: /new invoice/i })
|
||||
.first()
|
||||
.or(page.getByRole('button', { name: /new invoice/i }).first());
|
||||
await newBtn.first().click();
|
||||
|
||||
// Step 1: Client Info
|
||||
await page.waitForURL(`**/${PORT_SLUG}/invoices/new**`, { timeout: 10_000 });
|
||||
|
||||
await page.fill('#clientName', 'Invoice Test Client');
|
||||
// Step 1: pick the client in the OwnerPicker. The trigger renders as a
|
||||
// button with role="combobox" and the placeholder "Select owner..." while
|
||||
// empty.
|
||||
const ownerTrigger = page.locator('button[role="combobox"]:has-text("Select owner")').first();
|
||||
await expect(ownerTrigger).toBeVisible({ timeout: 5_000 });
|
||||
await ownerTrigger.click();
|
||||
const searchInput = page.getByPlaceholder(/search clients/i);
|
||||
await expect(searchInput).toBeVisible({ timeout: 5_000 });
|
||||
await searchInput.fill(clientName);
|
||||
await page.waitForTimeout(500); // let the debounced query fire
|
||||
await page.getByRole('option', { name: clientName }).first().click();
|
||||
|
||||
await page.fill('#billingEmail', 'billing@test.com');
|
||||
|
||||
const dueDate = new Date();
|
||||
@@ -36,7 +58,6 @@ test.describe('Invoicing', () => {
|
||||
await page.getByRole('button', { name: /next/i }).click();
|
||||
await page.waitForTimeout(1000);
|
||||
|
||||
// Step 2: Line Items — add 3 items
|
||||
for (let i = 0; i < 3; i++) {
|
||||
await page.getByRole('button', { name: /add line item/i }).click();
|
||||
await page.waitForTimeout(300);
|
||||
@@ -54,21 +75,16 @@ test.describe('Invoicing', () => {
|
||||
await page.locator('input[name="lineItems.2.quantity"]').fill('4');
|
||||
await page.locator('input[name="lineItems.2.unitPrice"]').fill('500');
|
||||
|
||||
// Verify subtotal appears (53800 formatted per locale)
|
||||
await expect(page.getByText(/53[,.]?800/).first()).toBeVisible({ timeout: 5_000 });
|
||||
|
||||
// Click Next to Review
|
||||
await page.getByRole('button', { name: /next/i }).click();
|
||||
await page.waitForTimeout(1000);
|
||||
await page.getByRole('button', { name: /^next$/i }).click();
|
||||
const createBtn = page.getByRole('button', { name: /create invoice/i });
|
||||
await expect(createBtn).toBeVisible({ timeout: 10_000 });
|
||||
|
||||
// Step 3: Review — verify summary
|
||||
await expect(page.getByText('Invoice Test Client')).toBeVisible();
|
||||
await expect(page.getByText(/53[,.]?800/).first()).toBeVisible();
|
||||
|
||||
// Submit
|
||||
await page.getByRole('button', { name: /create invoice/i }).click();
|
||||
await createBtn.click();
|
||||
|
||||
// Should redirect to invoice detail or list
|
||||
await page.waitForURL(
|
||||
(url) => url.pathname.includes('/invoices') && !url.pathname.includes('/new'),
|
||||
{ timeout: 15_000 },
|
||||
|
||||
Reference in New Issue
Block a user