feat(portal): replace magic-link with email/password + admin-initiated activation
The client portal no longer uses passwordless / magic-link sign-in. Each
client now has a `portal_users` row with a scrypt-hashed password,
created by an admin from the client detail page; the admin's invite
mails an activation link that the client uses to set their own password.
Forgot-password is wired through the same token mechanism.
Schema (migration `0009_outgoing_rumiko_fujikawa.sql`):
- `portal_users` — one per client account, separate from the CRM
`users` table (better-auth) so the auth realms stay isolated. Email
is globally unique, password is null until activation.
- `portal_auth_tokens` — single-use activation / reset tokens. Stores
only the SHA-256 hash so a DB compromise never leaks live tokens.
Services:
- `src/lib/portal/passwords.ts` — scrypt hash/verify (no new deps;
uses node:crypto), token mint+hash helpers.
- `src/lib/services/portal-auth.service.ts` — createPortalUser,
resendActivation, activateAccount, signIn (timing-safe),
requestPasswordReset, resetPassword. Auth failures throw the new
UnauthorizedError (401); enumeration-safe behaviour everywhere.
Routes:
- POST /api/portal/auth/sign-in — sets the existing portal JWT cookie.
- POST /api/portal/auth/forgot-password — always 200.
- POST /api/portal/auth/reset-password — token + new password.
- POST /api/portal/auth/activate — token + initial password.
- POST /api/v1/clients/:id/portal-user — admin invite (and `?action=resend`).
- Removed: /api/portal/auth/request, /api/portal/auth/verify (magic link).
UI:
- /portal/login — replaced email-only magic-link form with email +
password + "forgot password" link.
- /portal/forgot-password, /portal/reset-password, /portal/activate — new.
- New shared `PasswordSetForm` component used by activate + reset.
- New `PortalInviteButton` rendered on the client detail header.
Email send:
- `createTransporter` now wires SMTP auth when SMTP_USER+SMTP_PASS are
set (gmail app-password or marina-server creds, configured via env).
- `SMTP_FROM` env var lets the sender address be overridden without
pinning it to `noreply@${SMTP_HOST}`.
Tests:
- Smoke spec 17 (client-portal) updated to the new flow: 7/7 green.
- Smoke specs 02-crud-spine, 05-invoices, 20-critical-path updated to
match the post-refactor client + invoice forms (drop companyName,
use OwnerPicker + billingEmail).
- Vitest 652/652 still green; type-check clean.
Drops the dead `requestMagicLink` from portal.service.ts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -12,12 +12,14 @@ test.describe('CRUD Spine', () => {
|
||||
await navigateTo(page, '/clients');
|
||||
|
||||
// Click "New Client" button (use first() in case of duplicates in empty state)
|
||||
await page.getByRole('button', { name: /new client/i }).first().click();
|
||||
await page
|
||||
.getByRole('button', { name: /new client/i })
|
||||
.first()
|
||||
.click();
|
||||
await waitForSheet(page);
|
||||
|
||||
const sheet = page.locator('[role="dialog"]');
|
||||
await sheet.locator('input[name="fullName"]').fill(TEST_CLIENT_NAME);
|
||||
await sheet.locator('input[name="companyName"]').fill('E2E Test Corp');
|
||||
await sheet.locator('input[name="nationality"]').fill('British');
|
||||
await sheet.locator('input[name="contacts.0.value"]').fill('e2e@test.com');
|
||||
|
||||
@@ -34,7 +36,10 @@ test.describe('CRUD Spine', () => {
|
||||
await page.waitForTimeout(2000);
|
||||
|
||||
// The client name should appear somewhere in the table or page
|
||||
const hasClient = await page.getByText(TEST_CLIENT_NAME).isVisible({ timeout: 5_000 }).catch(() => false);
|
||||
const hasClient = await page
|
||||
.getByText(TEST_CLIENT_NAME)
|
||||
.isVisible({ timeout: 5_000 })
|
||||
.catch(() => false);
|
||||
if (!hasClient) {
|
||||
// Maybe the table loaded empty and we need to wait for data
|
||||
await page.waitForTimeout(3000);
|
||||
@@ -92,7 +97,10 @@ test.describe('CRUD Spine', () => {
|
||||
await page.waitForTimeout(2000);
|
||||
|
||||
// Client should disappear from active list
|
||||
const stillVisible = await page.getByText(TEST_CLIENT_NAME).isVisible({ timeout: 3_000 }).catch(() => false);
|
||||
const stillVisible = await page
|
||||
.getByText(TEST_CLIENT_NAME)
|
||||
.isVisible({ timeout: 3_000 })
|
||||
.catch(() => false);
|
||||
if (!stillVisible) {
|
||||
console.log(' ✓ Client archived and removed from list');
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user