feat(rbac): residential-partner route lockdown + role-aware mobile nav
UAT (residential partners must have zero access to anything non-residential; no marina dashboard). Server-side their permission map already 403s every marina domain — this locks the client surface to match: - AppShell: a residential-only user (residential_clients.view && !clients.view, non-super-admin) is redirected off ANY non-residential route to /residential/clients. Blocks the marina dashboard + every marina page in one place; personal surfaces (settings, inbox) stay reachable. (Fixes F4 — they no longer land on a marina dashboard of 403-ing empty widgets.) - Mobile bottom tabs were hardcoded Dashboard/Clients/Berths regardless of role; now role-aware — residential-only users get Residential Clients/Interests instead of marina tabs they 403 on. (Fixes F5.) - e2e: stale `#email` login selector → `#identifier` (smoke helper) — a real reason the smoke auth specs fail independent of the dev-server OOM. - New crash-safe `matrix` Playwright project (role×viewport access matrix + responsive overflow sweep) — lean alternative to the full suite which OOM-crashes next dev locally. Verified: matrix run shows residential_partner redirected to residential + residential-scoped mobile tabs; 403s unchanged; tsc + eslint + 42 permission tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1,8 +1,10 @@
|
||||
'use client';
|
||||
|
||||
import { useEffect, useState, type ComponentProps, type ReactNode } from 'react';
|
||||
import { usePathname, useRouter } from 'next/navigation';
|
||||
|
||||
import { cn } from '@/lib/utils';
|
||||
import { usePermissions } from '@/hooks/use-permissions';
|
||||
import { Sidebar } from '@/components/layout/sidebar';
|
||||
import { Topbar } from '@/components/layout/topbar';
|
||||
import { NavigationHistoryTracker } from '@/components/layout/navigation-history-tracker';
|
||||
@@ -112,6 +114,30 @@ export function AppShell({
|
||||
const currentPortId = useUIStore((s) => s.currentPortId);
|
||||
const logoUrl = currentPortSlug ? portLogoUrls[currentPortSlug] : null;
|
||||
|
||||
// Residential lockdown: a residential-only user (residential access, no
|
||||
// marina `clients.view`) must never see marina pages — including the marina
|
||||
// dashboard. The API already 403s their data; this guard blocks the *routes*,
|
||||
// redirecting any non-residential path to their residential home. Personal
|
||||
// surfaces (settings, inbox) stay reachable.
|
||||
const pathname = usePathname();
|
||||
const router = useRouter();
|
||||
const { can } = usePermissions();
|
||||
const residentialOnly =
|
||||
!isSuperAdmin && can('residential_clients', 'view') && !can('clients', 'view');
|
||||
useEffect(() => {
|
||||
if (!residentialOnly || !pathname) return;
|
||||
const [portSeg, ...rest] = pathname.split('/').filter(Boolean);
|
||||
const sub = rest.join('/');
|
||||
const allowed =
|
||||
sub === '' ||
|
||||
sub.startsWith('residential') ||
|
||||
sub.startsWith('settings') ||
|
||||
sub.startsWith('inbox');
|
||||
if (!allowed && portSeg) {
|
||||
router.replace(`/${portSeg}/residential/clients`);
|
||||
}
|
||||
}, [residentialOnly, pathname, router]);
|
||||
|
||||
useEffect(() => {
|
||||
const mqMobile = window.matchMedia(MOBILE_QUERY);
|
||||
const mqTablet = window.matchMedia(TABLET_QUERY);
|
||||
|
||||
Reference in New Issue
Block a user