feat(ui): broad consistency sweep — sources, dates, comboboxes, milestones

Mobile + responsive
- berth-form full-width on phones (was 480px fixed → overflowed iPhone)
- currency-input switched to inputMode=decimal with live thousands separator
- client-form Country/Timezone/Source/Preferred-Contact full-width <sm
- contacts row restructured so Primary toggle + Remove get their own strip
- customize-dashboard footer stacks vertically on mobile; Done full-width
- interest-form client/berth pickers no longer cmdk-filter on UUID (typing
  "Carlos" now returns Carlos Vega instead of "No clients found")

Data + consistency
- SOURCES + SOURCE_LABELS + formatSource() in lib/constants; 9 surfaces
  now resolve interest/client source from one place
- INTEREST_OUTCOMES adds lost_other (picker, badge, timeline)
- Berth options natural-sort A1 → A2 → … → A10 via lib/utils/mooring-sort
- archiver downgraded ^8 → ^7.0.1 so the GDPR export route compiles
- TableBody last-row uses border-b-0 (not border-0); colored left-accent
  on the bottom berth row now renders
- Hide Invite-to-Portal until port setting === true (was !== false default-show)
- OwnerPicker primer query resolves entity name on first paint (no more
  UUID flash before the popover opens)

Terminology
- Replaced user-facing "Documenso" with "signing service" / "Generated EOI" /
  "Manual EOI" in 8 components (admin/internal references kept)
- Plainer status-change copy on berth-detail-header

Forms + editing
- InlineEditableField gained a `date` variant (native picker); applied to
  company incorporation date and ready for other YYYY-MM-DD plaintext fields
- Inline source picker on interest-tabs detail (was free text)
- TagPicker self-hides when port has no tags AND nothing is selected
- New ReminderDaysInput with preset chips (1d / 3d / 1wk / 2wk / 1mo / custom)
- Compose dialog follow-up is now a toggle that reveals datetime picker

Pipeline milestones
- changeStageSchema accepts optional milestoneDate; service stamps it on the
  matching date column instead of always using now
- MilestoneAdvanceButton popover collects a back-date before stage advance
- Applied to every "Mark X manually" surface on the interest overview

EOI / linked-berths polish
- Add-bypass row aligned inline with toggle descriptions
- Tooltips on "Specifically pitching" / "Mark in EOI bundle" explain their
  legal vs. public-map consequences

Surfaces
- Companies list now has the column picker + persisted hidden-column prefs
- NotesList aggregate flag enabled on clients, companies, residential_clients
  (yachts already aggregated)

ft/m unit toggle (interim, before drift fix)
- "Berth size desired" gets a section-level ft/m toggle; per-field hint shows
  the converted value. Storage stays canonical-ft for now; the drift-safe
  persistence migration is the next step.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-12 14:50:58 +02:00
parent 638000bb58
commit 3ffee79f3f
132 changed files with 5784 additions and 997 deletions

View File

@@ -42,8 +42,18 @@ export function formatCurrency(
if (amount === null || amount === undefined || amount === '') return '';
const value = typeof amount === 'number' ? amount : Number(amount);
if (!Number.isFinite(value)) return '';
const code = (currency ?? 'USD').toUpperCase();
const { locale = 'en-US', minFractionDigits = 2, maxFractionDigits = 2 } = options;
// Defensive: trim + uppercase + fallback to USD when blank. Legacy
// NocoDB rows sometimes contain whitespace/empty strings rather than
// proper ISO codes, which would make Intl.NumberFormat throw.
const rawCode = (currency ?? 'USD').trim().toUpperCase();
const code = rawCode === '' ? 'USD' : rawCode;
// If the caller only specifies max (common: maxFractionDigits: 0 for
// whole-currency display), clamp min down to match — otherwise
// `toLocaleString` throws "Computed minimumFractionDigits is larger
// than maximumFractionDigits". The same defensive clamp protects
// Intl.NumberFormat too.
const { locale = 'en-US', maxFractionDigits = 2 } = options;
const minFractionDigits = options.minFractionDigits ?? Math.min(2, maxFractionDigits);
try {
return new Intl.NumberFormat(locale, {
style: 'currency',
@@ -52,10 +62,15 @@ export function formatCurrency(
maximumFractionDigits: maxFractionDigits,
}).format(value);
} catch {
// Unknown currency code — degrade to a bare number with the code
// appended rather than throwing. Keeps display robust against any
// legacy NocoDB rows that smuggled non-ISO strings into the column.
return `${value.toFixed(maxFractionDigits)} ${code}`;
// Unknown currency code — format the number with thousand
// separators (still useful) and append the code as a suffix rather
// than letting Intl crash the render. Keeps display robust against
// any legacy NocoDB rows that smuggled non-ISO strings.
const formatted = value.toLocaleString(locale, {
minimumFractionDigits: minFractionDigits,
maximumFractionDigits: maxFractionDigits,
});
return `${formatted} ${code}`;
}
}

View File

@@ -0,0 +1,27 @@
/**
* Natural-sort comparator for mooring numbers (`^[A-Z]+\d+$`, e.g. A1, B12,
* E18). Plain alphabetic sort orders them A1, A10, A11, A2 because '1' < '2'
* in lexicographic terms; this comparator splits the prefix from the index so
* A2 lands before A10 the way reps expect.
*
* Stable across the CRM: use this anywhere mooring numbers are presented in
* a list (dropdowns, table sorts, public-map ordering, berth options).
*/
const MOORING_PATTERN = /^([A-Z]+)(\d+)$/;
export function compareMooringNumbers(a: string, b: string): number {
const ma = MOORING_PATTERN.exec(a);
const mb = MOORING_PATTERN.exec(b);
// Fall back to plain locale compare for anything that doesn't match the
// canonical shape so we never throw on unexpected input.
if (!ma || !mb) return a.localeCompare(b);
const [, prefixA, numA] = ma;
const [, prefixB, numB] = mb;
if (prefixA !== prefixB) return (prefixA ?? '').localeCompare(prefixB ?? '');
return Number(numA) - Number(numB);
}
/** Sort an array of objects by their mooring-number field, in place safe. */
export function sortByMooring<T>(items: T[], pick: (item: T) => string): T[] {
return [...items].sort((a, b) => compareMooringNumbers(pick(a), pick(b)));
}