fix(clients): archiving is edit-level, not delete (unblocks Sales/Director)

Every client-archive route gated on clients:delete, which only super_admin
holds, so Sales Agent/Manager and Director users (clients.delete=false) got
403 on archive — the button was shown but never worked. Archiving is
reversible, so gate it on clients:edit instead; permanent deletion stays the
separate admin:permanently_delete_clients permission.

- New single source of truth CLIENT_ARCHIVE_ACTION='edit' (permissions.ts).
- All 5 archive routes use it: [id] DELETE, archive, archive-dossier,
  bulk-archive-preflight, bulk POST.
- UI affordances gate on clients:edit (detail-header archive/restore, bulk
  archive, per-row list + mobile-card archive) so view-only users don't see a
  button that 403s.
- permission-matrix regression test locks the policy (Sales/Director/Agent can
  archive; Viewer cannot).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L2qc3xZTfif7N4Wq3QDa8X

src/app/api/v1/clients/[id]/archive-dossier/route.ts

@@ -1,6 +1,7 @@
 import { NextResponse } from 'next/server';
 
 import { withAuth, withPermission } from '@/lib/api/helpers';
+import { CLIENT_ARCHIVE_ACTION } from '@/lib/auth/permissions';
 import { getClientArchiveDossier } from '@/lib/services/client-archive-dossier.service';
 import { errorResponse, NotFoundError } from '@/lib/errors';
 
@@ -10,7 +11,7 @@ import { errorResponse, NotFoundError } from '@/lib/errors';
  * decision points, and warnings.
  */
 export const GET = withAuth(
-  withPermission('clients', 'delete', async (_req, ctx, params) => {
+  withPermission('clients', CLIENT_ARCHIVE_ACTION, async (_req, ctx, params) => {
     try {
       const id = params.id;
       if (!id) throw new NotFoundError('client');

src/app/api/v1/clients/[id]/archive/route.ts

@@ -2,6 +2,7 @@ import { NextResponse } from 'next/server';
 import { z } from 'zod';
 
 import { withAuth, withPermission } from '@/lib/api/helpers';
+import { CLIENT_ARCHIVE_ACTION } from '@/lib/auth/permissions';
 import { parseBody } from '@/lib/api/route-helpers';
 import {
   archiveClientWithDecisions,
@@ -63,7 +64,7 @@ const decisionsSchema = z.object({
 });
 
 export const POST = withAuth(
-  withPermission('clients', 'delete', async (req, ctx, params) => {
+  withPermission('clients', CLIENT_ARCHIVE_ACTION, async (req, ctx, params) => {
     try {
       const id = params.id;
       if (!id) throw new NotFoundError('client');

src/app/api/v1/clients/[id]/route.ts

@@ -1,6 +1,7 @@
 import { NextResponse } from 'next/server';
 
 import { withAuth, withPermission } from '@/lib/api/helpers';
+import { CLIENT_ARCHIVE_ACTION } from '@/lib/auth/permissions';
 import { parseBody } from '@/lib/api/route-helpers';
 import { errorResponse } from '@/lib/errors';
 import { getClientById, updateClient, archiveClient } from '@/lib/services/clients.service';
@@ -35,7 +36,7 @@ export const PATCH = withAuth(
 );
 
 export const DELETE = withAuth(
-  withPermission('clients', 'delete', async (req, ctx, params) => {
+  withPermission('clients', CLIENT_ARCHIVE_ACTION, async (req, ctx, params) => {
     try {
       await archiveClient(params.id!, ctx.portId, {
         userId: ctx.userId,

src/app/api/v1/clients/bulk-archive-preflight/route.ts

@@ -2,6 +2,7 @@ import { NextResponse } from 'next/server';
 import { z } from 'zod';
 
 import { withAuth, withPermission } from '@/lib/api/helpers';
+import { CLIENT_ARCHIVE_ACTION } from '@/lib/auth/permissions';
 import { parseBody } from '@/lib/api/route-helpers';
 import { getClientArchiveDossier } from '@/lib/services/client-archive-dossier.service';
 import { errorResponse } from '@/lib/errors';
@@ -27,7 +28,7 @@ interface PreflightItem {
  *   - surface blockers (e.g. "has unpaid invoices") for the operator
  */
 export const POST = withAuth(
-  withPermission('clients', 'delete', async (req, ctx) => {
+  withPermission('clients', CLIENT_ARCHIVE_ACTION, async (req, ctx) => {
     try {
       const { ids } = await parseBody(req, bodySchema);
       const items: PreflightItem[] = [];

src/app/api/v1/clients/bulk/route.ts

@@ -3,6 +3,7 @@ import { z } from 'zod';
 import { eq, and } from 'drizzle-orm';
 
 import { withAuth, withRateLimit } from '@/lib/api/helpers';
+import { CLIENT_ARCHIVE_ACTION } from '@/lib/auth/permissions';
 import { parseBody } from '@/lib/api/route-helpers';
 import { runBulk } from '@/lib/api/bulk-helpers';
 import { db } from '@/lib/db';
@@ -43,7 +44,9 @@ const bulkSchema = z.discriminatedUnion('action', [
 ]);
 
 const PERMISSION_BY_ACTION = {
-  archive: 'delete' as const,
+  // Archiving is reversible -> edit-level (see CLIENT_ARCHIVE_ACTION). Not the
+  // destructive `delete`, which only super_admin holds.
+  archive: CLIENT_ARCHIVE_ACTION,
   add_tag: 'edit' as const,
   remove_tag: 'edit' as const,
 };

src/components/clients/client-card.tsx

@@ -27,9 +27,17 @@ interface ClientCardProps {
   portSlug: string;
   onEdit: (client: ClientRow) => void;
   onArchive: (client: ClientRow) => void;
+  /** Hide the Archive action for users who can't archive (clients:edit). */
+  canArchive?: boolean;
 }
 
-export function ClientCard({ client, portSlug, onEdit, onArchive }: ClientCardProps) {
+export function ClientCard({
+  client,
+  portSlug,
+  onEdit,
+  onArchive,
+  canArchive = true,
+}: ClientCardProps) {
   // Card display: prefer email, fall back to phone.
   const primaryContactValue = client.primaryEmail ?? client.primaryPhone ?? null;
   const nationality = client.nationalityIso ? getCountryName(client.nationalityIso, 'en') : null;
@@ -96,10 +104,12 @@ export function ClientCard({ client, portSlug, onEdit, onArchive }: ClientCardPr
               <Pencil className="mr-2 h-3.5 w-3.5" aria-hidden />
               Edit
             </DropdownMenuItem>
-            <DropdownMenuItem className="text-destructive" onClick={() => onArchive(client)}>
-              <Archive className="mr-2 h-3.5 w-3.5" aria-hidden />
-              Archive
-            </DropdownMenuItem>
+            {canArchive && (
+              <DropdownMenuItem className="text-destructive" onClick={() => onArchive(client)}>
+                <Archive className="mr-2 h-3.5 w-3.5" aria-hidden />
+                Archive
+              </DropdownMenuItem>
+            )}
           </DropdownMenuContent>
         </DropdownMenu>
       }

src/components/clients/client-columns.tsx

@@ -87,12 +87,15 @@ interface GetColumnsOptions {
   portSlug: string;
   onEdit: (client: ClientRow) => void;
   onArchive: (client: ClientRow) => void;
+  /** Hide the row Archive action for users who can't archive (clients:edit). */
+  canArchive?: boolean;
 }
 
 export function getClientColumns({
   portSlug,
   onEdit,
   onArchive,
+  canArchive = true,
 }: GetColumnsOptions): ColumnDef<ClientRow, unknown>[] {
   return [
     {
@@ -318,10 +321,15 @@ export function getClientColumns({
               <Pencil className="mr-2 h-3.5 w-3.5" aria-hidden />
               Edit
             </DropdownMenuItem>
-            <DropdownMenuItem className="text-destructive" onClick={() => onArchive(row.original)}>
-              <Archive className="mr-2 h-3.5 w-3.5" aria-hidden />
-              Archive
-            </DropdownMenuItem>
+            {canArchive && (
+              <DropdownMenuItem
+                className="text-destructive"
+                onClick={() => onArchive(row.original)}
+              >
+                <Archive className="mr-2 h-3.5 w-3.5" aria-hidden />
+                Archive
+              </DropdownMenuItem>
+            )}
           </DropdownMenuContent>
         </DropdownMenu>
       ),

src/components/clients/client-detail-header.tsx

@@ -146,23 +146,28 @@ export function ClientDetailHeader({ client }: ClientDetailHeaderProps) {
             >
               <Bell className="size-4" aria-hidden />
             </button>
-            <button
-              type="button"
-              onClick={() => setArchiveOpen(true)}
-              aria-label={isArchived ? 'Restore client' : 'Archive client'}
-              title={isArchived ? 'Restore client' : 'Archive client'}
-              className={cn(
-                'shrink-0 rounded-md p-1.5 text-muted-foreground/70 transition-colors',
-                'hover:bg-foreground/5',
-                isArchived ? 'hover:text-emerald-600' : 'hover:text-destructive',
-              )}
-            >
-              {isArchived ? (
-                <RotateCcw className="size-4" aria-hidden />
-              ) : (
-                <Archive className="size-4" aria-hidden />
-              )}
-            </button>
+            {/* Archive + Restore are reversible -> gate on clients:edit, the
+                same action the archive routes now require. Hidden for view-only
+                users so they never click a button that 403s. */}
+            <PermissionGate resource="clients" action="edit">
+              <button
+                type="button"
+                onClick={() => setArchiveOpen(true)}
+                aria-label={isArchived ? 'Restore client' : 'Archive client'}
+                title={isArchived ? 'Restore client' : 'Archive client'}
+                className={cn(
+                  'shrink-0 rounded-md p-1.5 text-muted-foreground/70 transition-colors',
+                  'hover:bg-foreground/5',
+                  isArchived ? 'hover:text-emerald-600' : 'hover:text-destructive',
+                )}
+              >
+                {isArchived ? (
+                  <RotateCcw className="size-4" aria-hidden />
+                ) : (
+                  <Archive className="size-4" aria-hidden />
+                )}
+              </button>
+            </PermissionGate>
           </div>
         </div>
       </DetailHeaderStrip>

src/components/clients/client-list.tsx

@@ -101,7 +101,9 @@ export function ClientList() {
 
   const { can } = usePermissions();
   const canHardDelete = can('admin', 'permanently_delete_clients');
-  const canBulkArchive = can('clients', 'delete');
+  // Archiving is reversible -> edit-level (see CLIENT_ARCHIVE_ACTION), not delete.
+  const canArchive = can('clients', 'edit');
+  const canBulkArchive = canArchive;
   const canBulkTag = can('clients', 'edit');
 
   const {
@@ -167,6 +169,7 @@ export function ClientList() {
     portSlug,
     onEdit: (client) => setEditClient(client),
     onArchive: (client) => setArchiveClient(client),
+    canArchive,
   });
 
   // Per-user column visibility, persisted into user_profiles.preferences
@@ -296,6 +299,7 @@ export function ClientList() {
               portSlug={portSlug}
               onEdit={setEditClient}
               onArchive={setArchiveClient}
+              canArchive={canArchive}
             />
           )}
           emptyState={

src/lib/auth/permissions.ts

@@ -75,6 +75,20 @@ export const PERMISSION_CATALOG = {
   [R in PermissionResource]: ReadonlyArray<PermissionAction<R> & string>;
 };
 
+/**
+ * Permission action that gates ARCHIVING a client. Archiving is reversible
+ * (sets `archivedAt`; restorable via the Restore flow), so it is an edit-level
+ * action — deliberately NOT the destructive `clients:delete` (which historically
+ * only super_admin held, locking every Sales/Director user out of archiving),
+ * and NOT `admin:permanently_delete_clients` (irreversible hard delete).
+ *
+ * Single source of truth: every client-archive route (single DELETE, archive
+ * with-decisions, archive-dossier, bulk-archive-preflight, bulk POST) gates on
+ * this, and the UI affordances gate on `clients:edit` to match. See the
+ * permission-matrix archive-policy test.
+ */
+export const CLIENT_ARCHIVE_ACTION = 'edit' as const;
+
 /** Every valid resource key, in catalog order. */
 export const PERMISSION_RESOURCES = Object.keys(PERMISSION_CATALOG) as PermissionResource[];