chore(cleanup): Phase 1 — gap closure across audit, alerts, soft-delete, perms
Multi-area cleanup pass closing partial-implementation gaps surfaced by the
post-i18n audit. No behavior changes for happy-path users; closes real
correctness/security holes.
PR1a Public yacht-interest endpoint i18n. /api/public/interests now accepts
phoneE164/phoneCountry, nationalityIso, address.{countryIso, subdivisionIso},
and company.{incorporationCountryIso, incorporationSubdivisionIso}.
Server-side parsePhone() fallback for legacy raw phone strings.
PR1b Alert rule registry trim. Two rule slots ('document.expiring_soon',
'audit.suspicious_login') were registered but evaluators returned [].
Both required schema/instrumentation that hadn't landed. Removed from
the registry; comments record the dependencies needed to revive them.
Effective rule count: 8 active.
PR1c vi.mock hoist + flake fix. Hoisted vi.mock calls to top-level in 5
integration test files; webhook-delivery uses vi.hoisted for the
queue-add ref. Vitest no longer warns about non-top-level mocks.
Deflaked the 'short value' assertion in security-encryption.test.ts
by switching plaintext from 'ab' to 'XY' (non-hex chars). 5/5 runs green.
PR1d Soft-delete reference audit. listClientOptions and listYachtsForOwner
now filter by isNull(archivedAt). Berths use status (no archivedAt).
PR1e Permission-matrix audit script + report. scripts/audit-permissions.ts
walks every src/app/api/v1/**/route.ts and reports handlers without a
withPermission() wrapper. Initial run found 33 violations.
- Allow-listed 17 with explicit reasons (self-data, admin, alerts,
search, currency, ai, custom-fields — some marked TODO).
- Wrapped 7 routes with concrete permissions: clients/options
(clients:view), berths/options (berths:view), dashboard/*
(reports:view_dashboard), analytics (reports:view_analytics).
Audit report at docs/runbooks/permission-audit.md. Script exits
non-zero on any unallow-listed violation so it can become a CI gate.
Vitest: 741 -> 741 (no new tests; existing suite covers the changes).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -15,6 +15,10 @@ import { describe, it, expect, beforeAll, afterAll, vi } from 'vitest';
|
||||
|
||||
import { makeAuditMeta } from '../helpers/factories';
|
||||
|
||||
vi.mock('@/lib/audit', () => ({
|
||||
createAuditLog: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
|
||||
const TEST_DB_URL =
|
||||
process.env.TEST_DATABASE_URL || 'postgresql://test:test@localhost:5433/portnimara_test';
|
||||
|
||||
@@ -66,10 +70,6 @@ describe('Custom Fields — Definitions', () => {
|
||||
let portId: string;
|
||||
const userId = crypto.randomUUID();
|
||||
|
||||
vi.mock('@/lib/audit', () => ({
|
||||
createAuditLog: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
|
||||
beforeAll(async () => {
|
||||
if (!dbAvailable) return;
|
||||
portId = await seedPort();
|
||||
@@ -141,9 +141,8 @@ describe('Custom Fields — Definitions', () => {
|
||||
});
|
||||
|
||||
itDb('updateDefinition with fieldType property throws ValidationError', async () => {
|
||||
const { createDefinition, updateDefinition } = await import(
|
||||
'@/lib/services/custom-fields.service'
|
||||
);
|
||||
const { createDefinition, updateDefinition } =
|
||||
await import('@/lib/services/custom-fields.service');
|
||||
const { ValidationError } = await import('@/lib/errors');
|
||||
const meta = makeAuditMeta({ portId, userId });
|
||||
|
||||
@@ -161,16 +160,21 @@ describe('Custom Fields — Definitions', () => {
|
||||
meta,
|
||||
);
|
||||
|
||||
// Cast to any to bypass TS — the service should guard against this at runtime
|
||||
// Cast bypasses TS — the service should guard against this at runtime.
|
||||
await expect(
|
||||
updateDefinition(portId, def.id, userId, { fieldType: 'number' } as any, meta),
|
||||
updateDefinition(
|
||||
portId,
|
||||
def.id,
|
||||
userId,
|
||||
{ fieldType: 'number' } as unknown as Parameters<typeof updateDefinition>[3],
|
||||
meta,
|
||||
),
|
||||
).rejects.toThrow(ValidationError);
|
||||
});
|
||||
|
||||
itDb('updateDefinition can change fieldLabel without error', async () => {
|
||||
const { createDefinition, updateDefinition } = await import(
|
||||
'@/lib/services/custom-fields.service'
|
||||
);
|
||||
const { createDefinition, updateDefinition } =
|
||||
await import('@/lib/services/custom-fields.service');
|
||||
const meta = makeAuditMeta({ portId, userId });
|
||||
|
||||
const def = await createDefinition(
|
||||
@@ -187,7 +191,13 @@ describe('Custom Fields — Definitions', () => {
|
||||
meta,
|
||||
);
|
||||
|
||||
const updated = await updateDefinition(portId, def.id, userId, { fieldLabel: 'Special Notes' }, meta);
|
||||
const updated = await updateDefinition(
|
||||
portId,
|
||||
def.id,
|
||||
userId,
|
||||
{ fieldLabel: 'Special Notes' },
|
||||
meta,
|
||||
);
|
||||
expect(updated.fieldLabel).toBe('Special Notes');
|
||||
expect(updated.fieldType).toBe('text');
|
||||
});
|
||||
@@ -200,10 +210,6 @@ describe('Custom Fields — Values', () => {
|
||||
const userId = crypto.randomUUID();
|
||||
const entityId = crypto.randomUUID();
|
||||
|
||||
vi.mock('@/lib/audit', () => ({
|
||||
createAuditLog: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
|
||||
beforeAll(async () => {
|
||||
if (!dbAvailable) return;
|
||||
portId = await seedPort();
|
||||
@@ -215,9 +221,8 @@ describe('Custom Fields — Values', () => {
|
||||
});
|
||||
|
||||
itDb('setValues stores a text value and getValues returns it with definition', async () => {
|
||||
const { createDefinition, setValues, getValues } = await import(
|
||||
'@/lib/services/custom-fields.service'
|
||||
);
|
||||
const { createDefinition, setValues, getValues } =
|
||||
await import('@/lib/services/custom-fields.service');
|
||||
const meta = makeAuditMeta({ portId, userId });
|
||||
|
||||
const def = await createDefinition(
|
||||
@@ -270,9 +275,8 @@ describe('Custom Fields — Values', () => {
|
||||
});
|
||||
|
||||
itDb('deleteDefinition cascades to remove associated values', async () => {
|
||||
const { createDefinition, setValues, deleteDefinition, getValues } = await import(
|
||||
'@/lib/services/custom-fields.service'
|
||||
);
|
||||
const { createDefinition, setValues, deleteDefinition, getValues } =
|
||||
await import('@/lib/services/custom-fields.service');
|
||||
const meta = makeAuditMeta({ portId, userId });
|
||||
|
||||
const cascadeEntityId = crypto.randomUUID();
|
||||
|
||||
Reference in New Issue
Block a user