fix(clients): list contacts join + nationality backfill + col redesign

Wire primary email + primary phone into the /clients list service so
the redesigned columns (Name · Email · Phone · Country · Source ·
Latest stage · Created) actually have data. Picks the row marked
is_primary=true; falls back to most-recent created_at when the flag
is unset.

- 0026 schema migration: unique partial index
  idx_cc_one_primary_per_channel on (client_id, channel) WHERE
  is_primary=true. Prevents the §14.2 "multiple primaries" ambiguity.
- 0027 data migration: backfill clients.nationality_iso from the
  primary phone's value_country. 218 -> 36 missing on dev. Idempotent.
- listClients: add a fifth parallel query for client_contacts; build
  primaryEmailMap / primaryPhoneMap in-memory from the pre-sorted
  result.
- client-columns: drop Yachts/Companies/Tags from the default view
  per §5.1; add Email/Phone/Country/Latest-stage columns; rename
  "Nationality" -> "Country" since phone country is a proxy (§14.2).
- client-card: prefer email, fall back to phone, for the line under
  the name; replaces the old `contacts.find(isPrimary)` lookup.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-05-05 02:15:03 +02:00
parent a2588f2c4a
commit 3017ce4b3a
9 changed files with 21563 additions and 106 deletions

View File

@@ -0,0 +1 @@
CREATE UNIQUE INDEX "idx_cc_one_primary_per_channel" ON "client_contacts" USING btree ("client_id","channel") WHERE "client_contacts"."is_primary" = true;

View File

@@ -0,0 +1,24 @@
-- Backfill clients.nationality_iso from the primary phone's parsed
-- value_country. Idempotent (only runs on rows where nationality_iso
-- is null), safe to re-execute. Phone country is a *proxy* for
-- nationality - the client-list UI labels the column "Country" rather
-- than "Nationality" to avoid implying it's authoritative (see §14.2).
--
-- Pattern: prefer the row marked `is_primary=true`; fall back to the
-- most recently created phone contact when no row is flagged primary.
WITH primary_phone AS (
SELECT DISTINCT ON (cc.client_id)
cc.client_id,
cc.value_country
FROM client_contacts cc
WHERE cc.channel = 'phone'
AND cc.value_country IS NOT NULL
ORDER BY cc.client_id,
cc.is_primary DESC,
cc.created_at DESC
)
UPDATE clients c
SET nationality_iso = primary_phone.value_country
FROM primary_phone
WHERE c.nationality_iso IS NULL
AND c.id = primary_phone.client_id;

File diff suppressed because it is too large Load Diff

File diff suppressed because it is too large Load Diff

View File

@@ -183,6 +183,20 @@
"when": 1777939212954,
"tag": "0025_berth_pricing_columns",
"breakpoints": true
},
{
"idx": 26,
"version": "7",
"when": 1777939906731,
"tag": "0026_client_contacts_one_primary_per_channel",
"breakpoints": true
},
{
"idx": 27,
"version": "7",
"when": 1777939914252,
"tag": "0027_backfill_nationality_iso_from_phone",
"breakpoints": true
}
]
}

View File

@@ -77,6 +77,11 @@ export const clientContacts = pgTable(
index('idx_cc_phone')
.on(table.channel, table.value)
.where(sql`${table.channel} = 'phone'`),
// At most one is_primary=true per (client_id, channel). Prevents
// ambiguity when the /clients list pulls "the" primary phone/email.
uniqueIndex('idx_cc_one_primary_per_channel')
.on(table.clientId, table.channel)
.where(sql`${table.isPrimary} = true`),
],
);