diff --git a/src/components/layout/topbar.tsx b/src/components/layout/topbar.tsx index 4088783f..5ba5b563 100644 --- a/src/components/layout/topbar.tsx +++ b/src/components/layout/topbar.tsx @@ -59,7 +59,13 @@ export function Topbar({ ports, user, leadingSlot }: TopbarProps) { // Three-column grid: breadcrumbs left, search center, actions right. // The brand logo lives in the sidebar header (per design feedback) so the // topbar center is dedicated to the global search bar. -
+ // + // Center column min-width: 280 at tablet, 420 at lg+. The earlier + // single 420 min starved the left column to ~100px at 768 viewport + // width (when the sidebar is hidden under a Sheet on tablet) — that + // was hiding the new logo-trigger leadingSlot AppShell mounts. Two + // breakpoints split the difference cleanly. +
{/* LEFT: optional sidebar trigger (tablet) + optional back button + breadcrumbs */}
{leadingSlot} @@ -85,9 +91,13 @@ export function Topbar({ ports, user, leadingSlot }: TopbarProps) { translate-X that shifts left by half the sidebar width. Without the translate the topbar's grid centers inside the area-after-the-sidebar, so the search visually drifts right - by half the sidebar width. */} + by half the sidebar width. + The translate is gated to `lg:` because at tablet (768-1023) + the sidebar is HIDDEN behind a Sheet — translating left there + shifts the search into the leading-slot column, hiding the + AppShell-mounted logo trigger. */}
-
+
diff --git a/src/components/shared/page-header.tsx b/src/components/shared/page-header.tsx index 5de5dac0..8501f153 100644 --- a/src/components/shared/page-header.tsx +++ b/src/components/shared/page-header.tsx @@ -46,18 +46,21 @@ export function PageHeader({ ) : null} {/* Tablet + desktop: full strip with title, eyebrow, description, kpi line, actions. - Stacks vertically at sm (640px) up to lg (1024px) so the title - doesn't get truncated next to a wide actions row on tablet — the - previous `sm:flex-row sm:flex-nowrap` forced four-button toolbars - (e.g. the dashboard's DateRange + ExportPdf + Rearrange + Customize) - onto one row at 768px, crushing the title. At lg+ the row layout - returns. */} + Stacks vertically at sm (640px) up to xl (1280px). The earlier + revision moved the stack point from sm to lg, which fixed the + tablet (768) crush but introduced a SECOND crush at exactly + 1024: that's where the desktop shell mounts (sidebar = 256px) + AND `lg:flex-row` kicks in, leaving the title cell to compete + with a four-button action row in only ~720px of content. Moving + to xl (1280) means the strip stays stacked through tablet AND + the narrowest desktop width; horizontal layout returns once + there's actual room. */}
{actions ? ( -
{actions}
+
{actions}
) : null}