feat(i18n): country/phone/timezone/subdivision primitives + form wiring
Cross-cutting i18n polish for forms across the marina + residential + company
domains. Introduces a single source of truth for country/phone/timezone/
subdivision data and replaces every nationality-as-free-text and timezone-
as-string Input with a dedicated combobox.
PR1 Countries — ALL_COUNTRY_CODES (~250 ISO-3166-1 alpha-2), Intl.DisplayNames
for localized labels, detectDefaultCountry() with navigator-region
fallback to US, CountryCombobox with regional-indicator flag glyphs +
compact mode for inline use.
PR2 Phone — libphonenumber-js wrapper (parsePhone / formatAsYouType /
callingCodeFor), PhoneInput with flag dropdown + national-format
AsYouType + paste-detect that flips the country dropdown for pasted
international strings.
PR3 Timezones — country->IANA map (250 entries, multi-zone for AU/BR/CA/CD/
ID/KZ/MN/MX/RU/US), formatTimezoneLabel ("Europe/London (UTC+1)"),
TimezoneCombobox with Suggested/All grouping driven by countryHint.
PR4 Subdivisions — wraps the iso-3166-2 npm package (~5000 ISO 3166-2
codes for every country), per-country cache, SubdivisionCombobox with
"Pick a country first" / "No regions available" empty states.
PR5 Schema deltas (migration 0015) — clients.nationality_iso, clientContacts
{value_e164, value_country}, clientAddresses {country_iso, subdivision_iso},
residentialClients {phone_e164, phone_country, nationality_iso, timezone,
place_of_residence_country_iso, subdivision_iso}, companies {incorporation_
country_iso, incorporation_subdivision_iso}, companyAddresses {country_iso,
subdivision_iso}. Plus shared zod validators (validators/i18n.ts) used
by every entity validator + route handler.
PR6 ClientForm + ClientDetail — CountryCombobox replaces nationality Input,
TimezoneCombobox replaces timezone Input (driven by nationalityIso hint),
PhoneInput conditionally rendered for phone/whatsapp contacts. Inline
editors (InlineCountryField / InlineTimezoneField / InlinePhoneField)
for the detail-page overview rows + ContactsEditor.
PR7 Residential client form + detail — phone -> PhoneInput, nationality/
timezone/place-of-residence-country/subdivision rows in both create
sheet and inline-editable detail view. Subdivision wipes when country
flips since codes are country-scoped.
PR8 Company form + detail — incorporation country -> CountryCombobox,
incorporation region -> SubdivisionCombobox in both modes.
PR9 Public inquiry endpoint — accepts pre-normalized phoneE164/phoneCountry
and i18n fields from newer website builds, server-side parsePhone()
fallback for legacy raw-international submissions. Old Nuxt builds
keep working unchanged.
Tests: 4 unit suites for the primitives (25 tests), 1 integration spec for
the public phone-normalization path (3 tests), 1 smoke spec asserting the
combobox triggers render in all three create sheets.
Test totals: vitest 713 -> 741 (+28).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
71
tests/unit/i18n-timezones.test.ts
Normal file
71
tests/unit/i18n-timezones.test.ts
Normal file
@@ -0,0 +1,71 @@
|
||||
/**
|
||||
* i18n PR3 — timezone helpers.
|
||||
*
|
||||
* Validates:
|
||||
* 1. Single-zone countries return one IANA string
|
||||
* 2. Multi-zone countries return >1 zones with the most-populous first
|
||||
* 3. primaryTimezoneFor returns the first entry
|
||||
* 4. isMultiZone correctly classifies a sample of single + multi countries
|
||||
* 5. listAllTimezones returns at least our bundled set
|
||||
* 6. formatTimezoneLabel renders an offset for known zones
|
||||
*/
|
||||
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import {
|
||||
timezonesForCountry,
|
||||
primaryTimezoneFor,
|
||||
isMultiZone,
|
||||
listAllTimezones,
|
||||
formatTimezoneLabel,
|
||||
} from '@/lib/i18n/timezones';
|
||||
|
||||
describe('i18n timezones', () => {
|
||||
it('single-zone countries map to one IANA zone', () => {
|
||||
expect(timezonesForCountry('PL')).toEqual(['Europe/Warsaw']);
|
||||
expect(timezonesForCountry('GB')).toEqual(['Europe/London']);
|
||||
expect(timezonesForCountry('JP')).toEqual(['Asia/Tokyo']);
|
||||
expect(timezonesForCountry('AE')).toEqual(['Asia/Dubai']);
|
||||
});
|
||||
|
||||
it('multi-zone countries return ordered lists with the primary first', () => {
|
||||
const us = timezonesForCountry('US');
|
||||
expect(us[0]).toBe('America/New_York');
|
||||
expect(us.length).toBeGreaterThan(5);
|
||||
const ru = timezonesForCountry('RU');
|
||||
expect(ru[0]).toBe('Europe/Moscow');
|
||||
expect(ru.length).toBeGreaterThan(5);
|
||||
});
|
||||
|
||||
it('primaryTimezoneFor returns the first entry or null', () => {
|
||||
expect(primaryTimezoneFor('FR')).toBe('Europe/Paris');
|
||||
expect(primaryTimezoneFor('US')).toBe('America/New_York');
|
||||
// 'AQ' is in our map; Antarctica/McMurdo
|
||||
expect(primaryTimezoneFor('AQ')).toBe('Antarctica/McMurdo');
|
||||
});
|
||||
|
||||
it('isMultiZone discriminates correctly', () => {
|
||||
expect(isMultiZone('US')).toBe(true);
|
||||
expect(isMultiZone('RU')).toBe(true);
|
||||
expect(isMultiZone('AU')).toBe(true);
|
||||
expect(isMultiZone('PL')).toBe(false);
|
||||
expect(isMultiZone('JP')).toBe(false);
|
||||
});
|
||||
|
||||
it('listAllTimezones returns at minimum the entries from the country map', () => {
|
||||
const all = listAllTimezones();
|
||||
expect(all.length).toBeGreaterThanOrEqual(200);
|
||||
expect(all).toContain('Europe/Warsaw');
|
||||
expect(all).toContain('America/New_York');
|
||||
expect(all).toContain('Asia/Tokyo');
|
||||
});
|
||||
|
||||
it('formatTimezoneLabel includes an offset for known zones', () => {
|
||||
const label = formatTimezoneLabel('Europe/London');
|
||||
expect(label).toMatch(/Europe\/London/);
|
||||
expect(label).toMatch(/UTC|GMT/);
|
||||
});
|
||||
|
||||
it('formatTimezoneLabel falls back to the bare zone for unknown input', () => {
|
||||
expect(formatTimezoneLabel('Not/A_Zone')).toBe('Not/A_Zone');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user