feat(i18n): country/phone/timezone/subdivision primitives + form wiring
Cross-cutting i18n polish for forms across the marina + residential + company
domains. Introduces a single source of truth for country/phone/timezone/
subdivision data and replaces every nationality-as-free-text and timezone-
as-string Input with a dedicated combobox.
PR1 Countries — ALL_COUNTRY_CODES (~250 ISO-3166-1 alpha-2), Intl.DisplayNames
for localized labels, detectDefaultCountry() with navigator-region
fallback to US, CountryCombobox with regional-indicator flag glyphs +
compact mode for inline use.
PR2 Phone — libphonenumber-js wrapper (parsePhone / formatAsYouType /
callingCodeFor), PhoneInput with flag dropdown + national-format
AsYouType + paste-detect that flips the country dropdown for pasted
international strings.
PR3 Timezones — country->IANA map (250 entries, multi-zone for AU/BR/CA/CD/
ID/KZ/MN/MX/RU/US), formatTimezoneLabel ("Europe/London (UTC+1)"),
TimezoneCombobox with Suggested/All grouping driven by countryHint.
PR4 Subdivisions — wraps the iso-3166-2 npm package (~5000 ISO 3166-2
codes for every country), per-country cache, SubdivisionCombobox with
"Pick a country first" / "No regions available" empty states.
PR5 Schema deltas (migration 0015) — clients.nationality_iso, clientContacts
{value_e164, value_country}, clientAddresses {country_iso, subdivision_iso},
residentialClients {phone_e164, phone_country, nationality_iso, timezone,
place_of_residence_country_iso, subdivision_iso}, companies {incorporation_
country_iso, incorporation_subdivision_iso}, companyAddresses {country_iso,
subdivision_iso}. Plus shared zod validators (validators/i18n.ts) used
by every entity validator + route handler.
PR6 ClientForm + ClientDetail — CountryCombobox replaces nationality Input,
TimezoneCombobox replaces timezone Input (driven by nationalityIso hint),
PhoneInput conditionally rendered for phone/whatsapp contacts. Inline
editors (InlineCountryField / InlineTimezoneField / InlinePhoneField)
for the detail-page overview rows + ContactsEditor.
PR7 Residential client form + detail — phone -> PhoneInput, nationality/
timezone/place-of-residence-country/subdivision rows in both create
sheet and inline-editable detail view. Subdivision wipes when country
flips since codes are country-scoped.
PR8 Company form + detail — incorporation country -> CountryCombobox,
incorporation region -> SubdivisionCombobox in both modes.
PR9 Public inquiry endpoint — accepts pre-normalized phoneE164/phoneCountry
and i18n fields from newer website builds, server-side parsePhone()
fallback for legacy raw-international submissions. Old Nuxt builds
keep working unchanged.
Tests: 4 unit suites for the primitives (25 tests), 1 integration spec for
the public phone-normalization path (3 tests), 1 smoke spec asserting the
combobox triggers render in all three create sheets.
Test totals: vitest 713 -> 741 (+28).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
60
tests/unit/i18n-phone.test.ts
Normal file
60
tests/unit/i18n-phone.test.ts
Normal file
@@ -0,0 +1,60 @@
|
||||
/**
|
||||
* i18n PR2 — phone helpers.
|
||||
*
|
||||
* Validates:
|
||||
* 1. parsePhone yields E.164 + country + display formats
|
||||
* 2. parsePhone returns the empty record for unparseable input
|
||||
* 3. AsYouType formats digits in the country's national style
|
||||
* 4. isValidE164 accepts only E.164 form
|
||||
* 5. callingCodeFor returns the dial prefix
|
||||
* 6. International-format paste detects country
|
||||
*/
|
||||
|
||||
import { describe, it, expect } from 'vitest';
|
||||
import { parsePhone, formatAsYouType, isValidE164, callingCodeFor } from '@/lib/i18n/phone';
|
||||
|
||||
describe('i18n phone', () => {
|
||||
it('parses an international-format input regardless of defaultCountry', () => {
|
||||
const r = parsePhone('+44 20 7946 0958');
|
||||
expect(r.e164).toBe('+442079460958');
|
||||
expect(r.country).toBe('GB');
|
||||
expect(r.isValid).toBe(true);
|
||||
expect(r.national).toMatch(/020 7946 0958/);
|
||||
expect(r.international).toMatch(/\+44 20 7946 0958/);
|
||||
});
|
||||
|
||||
it('parses a national-format input against the defaultCountry', () => {
|
||||
const r = parsePhone('020 7946 0958', 'GB');
|
||||
expect(r.e164).toBe('+442079460958');
|
||||
expect(r.country).toBe('GB');
|
||||
expect(r.isValid).toBe(true);
|
||||
});
|
||||
|
||||
it('returns the empty record for empty / nonsense input', () => {
|
||||
expect(parsePhone('').isValid).toBe(false);
|
||||
expect(parsePhone('abc').isValid).toBe(false);
|
||||
expect(parsePhone('').e164).toBeNull();
|
||||
});
|
||||
|
||||
it('formatAsYouType produces national-format output', () => {
|
||||
// GB national-format breaks 020 7946 0958.
|
||||
const out = formatAsYouType('2079460958', 'GB');
|
||||
expect(out.length).toBeGreaterThan(0);
|
||||
// US national-format breaks (415) 555-1234.
|
||||
const us = formatAsYouType('4155551234', 'US');
|
||||
expect(us).toContain('415');
|
||||
});
|
||||
|
||||
it('isValidE164 accepts only E.164', () => {
|
||||
expect(isValidE164('+442079460958')).toBe(true);
|
||||
expect(isValidE164('+1 415 555 1234')).toBe(true); // libphonenumber tolerates spaces
|
||||
expect(isValidE164('020 7946 0958')).toBe(false); // missing +country prefix
|
||||
expect(isValidE164('not a phone')).toBe(false);
|
||||
});
|
||||
|
||||
it('callingCodeFor returns the dial prefix', () => {
|
||||
expect(callingCodeFor('US')).toBe('+1');
|
||||
expect(callingCodeFor('GB')).toBe('+44');
|
||||
expect(callingCodeFor('PL')).toBe('+48');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user