feat(i18n): country/phone/timezone/subdivision primitives + form wiring
Cross-cutting i18n polish for forms across the marina + residential + company
domains. Introduces a single source of truth for country/phone/timezone/
subdivision data and replaces every nationality-as-free-text and timezone-
as-string Input with a dedicated combobox.
PR1 Countries — ALL_COUNTRY_CODES (~250 ISO-3166-1 alpha-2), Intl.DisplayNames
for localized labels, detectDefaultCountry() with navigator-region
fallback to US, CountryCombobox with regional-indicator flag glyphs +
compact mode for inline use.
PR2 Phone — libphonenumber-js wrapper (parsePhone / formatAsYouType /
callingCodeFor), PhoneInput with flag dropdown + national-format
AsYouType + paste-detect that flips the country dropdown for pasted
international strings.
PR3 Timezones — country->IANA map (250 entries, multi-zone for AU/BR/CA/CD/
ID/KZ/MN/MX/RU/US), formatTimezoneLabel ("Europe/London (UTC+1)"),
TimezoneCombobox with Suggested/All grouping driven by countryHint.
PR4 Subdivisions — wraps the iso-3166-2 npm package (~5000 ISO 3166-2
codes for every country), per-country cache, SubdivisionCombobox with
"Pick a country first" / "No regions available" empty states.
PR5 Schema deltas (migration 0015) — clients.nationality_iso, clientContacts
{value_e164, value_country}, clientAddresses {country_iso, subdivision_iso},
residentialClients {phone_e164, phone_country, nationality_iso, timezone,
place_of_residence_country_iso, subdivision_iso}, companies {incorporation_
country_iso, incorporation_subdivision_iso}, companyAddresses {country_iso,
subdivision_iso}. Plus shared zod validators (validators/i18n.ts) used
by every entity validator + route handler.
PR6 ClientForm + ClientDetail — CountryCombobox replaces nationality Input,
TimezoneCombobox replaces timezone Input (driven by nationalityIso hint),
PhoneInput conditionally rendered for phone/whatsapp contacts. Inline
editors (InlineCountryField / InlineTimezoneField / InlinePhoneField)
for the detail-page overview rows + ContactsEditor.
PR7 Residential client form + detail — phone -> PhoneInput, nationality/
timezone/place-of-residence-country/subdivision rows in both create
sheet and inline-editable detail view. Subdivision wipes when country
flips since codes are country-scoped.
PR8 Company form + detail — incorporation country -> CountryCombobox,
incorporation region -> SubdivisionCombobox in both modes.
PR9 Public inquiry endpoint — accepts pre-normalized phoneE164/phoneCountry
and i18n fields from newer website builds, server-side parsePhone()
fallback for legacy raw-international submissions. Old Nuxt builds
keep working unchanged.
Tests: 4 unit suites for the primitives (25 tests), 1 integration spec for
the public phone-normalization path (3 tests), 1 smoke spec asserting the
combobox triggers render in all three create sheets.
Test totals: vitest 713 -> 741 (+28).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
138
tests/integration/public-residential-inquiry.test.ts
Normal file
138
tests/integration/public-residential-inquiry.test.ts
Normal file
@@ -0,0 +1,138 @@
|
||||
/**
|
||||
* i18n PR9–10 — public residential inquiry endpoint.
|
||||
*
|
||||
* Validates the server-side phone normalization that the public inquiry
|
||||
* route runs when the website posts a raw international format (older
|
||||
* Nuxt builds), and that pre-normalized payloads pass through unchanged.
|
||||
*/
|
||||
|
||||
import { describe, it, expect, vi, beforeAll } from 'vitest';
|
||||
import { eq } from 'drizzle-orm';
|
||||
|
||||
import { db } from '@/lib/db';
|
||||
import { residentialClients } from '@/lib/db/schema/residential';
|
||||
import { makePort } from '../helpers/factories';
|
||||
import { makeMockRequest } from '../helpers/route-tester';
|
||||
|
||||
vi.mock('@/lib/socket/server', () => ({ emitToRoom: vi.fn() }));
|
||||
vi.mock('@/lib/email', () => ({ sendEmail: vi.fn().mockResolvedValue(undefined) }));
|
||||
|
||||
let ipCounter = 1;
|
||||
function uniqueIp(): string {
|
||||
ipCounter += 1;
|
||||
return `10.50.${Math.floor(ipCounter / 255) % 255}.${ipCounter % 255}`;
|
||||
}
|
||||
|
||||
describe('POST /api/public/residential-inquiries', () => {
|
||||
let POST: typeof import('@/app/api/public/residential-inquiries/route').POST;
|
||||
|
||||
beforeAll(async () => {
|
||||
const mod = await import('@/app/api/public/residential-inquiries/route');
|
||||
POST = mod.POST;
|
||||
});
|
||||
|
||||
it('parses a raw international phone string into E.164 + country', async () => {
|
||||
const port = await makePort();
|
||||
const email = `res-${Math.random().toString(36).slice(2, 8)}@test.local`;
|
||||
|
||||
const req = makeMockRequest(
|
||||
'POST',
|
||||
`http://localhost/api/public/residential-inquiries?portId=${port.id}`,
|
||||
{
|
||||
headers: { 'x-forwarded-for': uniqueIp() },
|
||||
body: {
|
||||
firstName: 'Anna',
|
||||
lastName: 'Nowak',
|
||||
email,
|
||||
// Raw international format — server should normalize.
|
||||
phone: '+44 20 7946 0958',
|
||||
placeOfResidence: 'Warsaw',
|
||||
},
|
||||
},
|
||||
);
|
||||
|
||||
const res = await POST(req);
|
||||
expect(res.status).toBe(201);
|
||||
|
||||
const [row] = await db
|
||||
.select()
|
||||
.from(residentialClients)
|
||||
.where(eq(residentialClients.email, email));
|
||||
|
||||
expect(row).toBeDefined();
|
||||
expect(row?.phoneE164).toBe('+442079460958');
|
||||
expect(row?.phoneCountry).toBe('GB');
|
||||
// Free-text legacy column preserved verbatim for backfill.
|
||||
expect(row?.phone).toBe('+44 20 7946 0958');
|
||||
});
|
||||
|
||||
it('passes pre-normalized E.164 + country through unchanged', async () => {
|
||||
const port = await makePort();
|
||||
const email = `res-${Math.random().toString(36).slice(2, 8)}@test.local`;
|
||||
|
||||
const req = makeMockRequest(
|
||||
'POST',
|
||||
`http://localhost/api/public/residential-inquiries?portId=${port.id}`,
|
||||
{
|
||||
headers: { 'x-forwarded-for': uniqueIp() },
|
||||
body: {
|
||||
firstName: 'Jan',
|
||||
lastName: 'Kowalski',
|
||||
email,
|
||||
phone: '+48 22 555 0100',
|
||||
phoneE164: '+48225550100',
|
||||
phoneCountry: 'PL',
|
||||
nationalityIso: 'PL',
|
||||
timezone: 'Europe/Warsaw',
|
||||
placeOfResidence: 'Warsaw',
|
||||
placeOfResidenceCountryIso: 'PL',
|
||||
},
|
||||
},
|
||||
);
|
||||
|
||||
const res = await POST(req);
|
||||
expect(res.status).toBe(201);
|
||||
|
||||
const [row] = await db
|
||||
.select()
|
||||
.from(residentialClients)
|
||||
.where(eq(residentialClients.email, email));
|
||||
|
||||
expect(row?.phoneE164).toBe('+48225550100');
|
||||
expect(row?.phoneCountry).toBe('PL');
|
||||
expect(row?.nationalityIso).toBe('PL');
|
||||
expect(row?.timezone).toBe('Europe/Warsaw');
|
||||
expect(row?.placeOfResidenceCountryIso).toBe('PL');
|
||||
});
|
||||
|
||||
it('persists a national-format phone when the website only sends a country hint', async () => {
|
||||
const port = await makePort();
|
||||
const email = `res-${Math.random().toString(36).slice(2, 8)}@test.local`;
|
||||
|
||||
const req = makeMockRequest(
|
||||
'POST',
|
||||
`http://localhost/api/public/residential-inquiries?portId=${port.id}`,
|
||||
{
|
||||
headers: { 'x-forwarded-for': uniqueIp() },
|
||||
body: {
|
||||
firstName: 'Marta',
|
||||
lastName: 'Lewandowska',
|
||||
email,
|
||||
phone: '22 555 0200', // National-format
|
||||
phoneCountry: 'PL', // Hint only — no E.164 yet.
|
||||
},
|
||||
},
|
||||
);
|
||||
|
||||
const res = await POST(req);
|
||||
expect(res.status).toBe(201);
|
||||
|
||||
const [row] = await db
|
||||
.select()
|
||||
.from(residentialClients)
|
||||
.where(eq(residentialClients.email, email));
|
||||
|
||||
expect(row?.phoneE164).toBe('+48225550200');
|
||||
expect(row?.phoneCountry).toBe('PL');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user