fix(api): kill currentPortId persist race + dedupe admin/ports stampede

The dashboard and residential interest smoke tests were intermittently
failing with the page rendering empty/skeleton state. Root causes:

1. ui-store persisted currentPortId/Slug, but those are URL-derived state.
   After login lands on /<first-port-by-name>/dashboard, localStorage holds
   that port. Hard-navigating to /port-nimara/... rehydrated the store with
   the stale id, and useQuery fired with the wrong port before
   PortProvider's URL-sync useEffect could correct it. Drop both fields
   from partialize — PortProvider re-derives them from the route every
   navigation.

2. apiFetch's slug-to-port fallback fired N parallel /api/v1/admin/ports
   calls when N components mounted simultaneously with an empty store.
   Dedupe in-flight lookups so a stampede collapses into one round-trip.

Also tightened four flaky smoke tests that depended on a fixed 3s wait or
non-waiting isVisible({timeout}) — replaced with expect(...).toBeVisible
or expect.poll so they handle dev-mode JIT cold-start delays cleanly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-04-28 04:38:57 +02:00
parent 259cd7b8bb
commit 0406778c44
6 changed files with 74 additions and 28 deletions

View File

@@ -162,7 +162,13 @@ test.describe('Admin Features', () => {
test('monitoring dashboard shows queue overview with expected queues', async ({ page }) => {
await navigateTo(page, '/admin/monitoring');
await page.waitForTimeout(3_000);
// Wait for the queue overview section to render. The queue cards expose
// names that don't appear in the sidebar (e.g. webhooks, maintenance) so
// we anchor on one of those to confirm the panel has loaded.
await expect(page.getByText('webhooks', { exact: false }).first()).toBeVisible({
timeout: 15_000,
});
// All 10 expected queue names from QUEUE_CONFIGS
const expectedQueues = [
@@ -181,7 +187,7 @@ test.describe('Admin Features', () => {
let foundCount = 0;
for (const queueName of expectedQueues) {
const queueEl = page.getByText(queueName, { exact: false }).first();
const visible = await queueEl.isVisible({ timeout: 2_000 }).catch(() => false);
const visible = await queueEl.isVisible().catch(() => false);
if (visible) foundCount++;
}