fix(api): kill currentPortId persist race + dedupe admin/ports stampede
The dashboard and residential interest smoke tests were intermittently
failing with the page rendering empty/skeleton state. Root causes:
1. ui-store persisted currentPortId/Slug, but those are URL-derived state.
After login lands on /<first-port-by-name>/dashboard, localStorage holds
that port. Hard-navigating to /port-nimara/... rehydrated the store with
the stale id, and useQuery fired with the wrong port before
PortProvider's URL-sync useEffect could correct it. Drop both fields
from partialize — PortProvider re-derives them from the route every
navigation.
2. apiFetch's slug-to-port fallback fired N parallel /api/v1/admin/ports
calls when N components mounted simultaneously with an empty store.
Dedupe in-flight lookups so a stampede collapses into one round-trip.
Also tightened four flaky smoke tests that depended on a fixed 3s wait or
non-waiting isVisible({timeout}) — replaced with expect(...).toBeVisible
or expect.poll so they handle dev-mode JIT cold-start delays cleanly.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -12,9 +12,10 @@ test.describe('Dashboard', () => {
|
||||
// navigate to the port-scoped dashboard to verify the real content renders.
|
||||
await navigateTo(page, '/');
|
||||
expect(page.url()).toContain(`/${PORT_SLUG}`);
|
||||
// Should see the dashboard shell (KPI cards are always rendered at the top)
|
||||
// Should see the dashboard shell (KPI cards are always rendered at the top).
|
||||
// Dev-mode JIT compilation can push first-hit render past 10s.
|
||||
await expect(page.getByText(/total clients/i).first()).toBeVisible({
|
||||
timeout: 10_000,
|
||||
timeout: 15_000,
|
||||
});
|
||||
// Should NOT see the old placeholder text
|
||||
await expect(page.getByText('Coming in Layer'))
|
||||
@@ -25,9 +26,11 @@ test.describe('Dashboard', () => {
|
||||
// Test 2: All 4 KPI cards render
|
||||
test('all 4 KPI cards render without errors', async ({ page }) => {
|
||||
await navigateTo(page, '/');
|
||||
await page.waitForTimeout(3_000);
|
||||
|
||||
// Look for KPI-related text/elements — the cards should contain numbers or labels
|
||||
// Wait for the KPI cards to actually render (dev mode JIT can take >3s on
|
||||
// a cold dashboard hit). The cards expose stable label text we can poll on.
|
||||
await expect(page.getByText('Total Clients')).toBeVisible({ timeout: 15_000 });
|
||||
|
||||
const cards = page.locator('[class*="card"], [data-testid*="kpi"]');
|
||||
const cardCount = await cards.count();
|
||||
expect(cardCount).toBeGreaterThanOrEqual(4);
|
||||
|
||||
Reference in New Issue
Block a user