letsbe/pn-new-crm
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(api): kill currentPortId persist race + dedupe admin/ports stampede

Browse Source 
The dashboard and residential interest smoke tests were intermittently
failing with the page rendering empty/skeleton state. Root causes:

1. ui-store persisted currentPortId/Slug, but those are URL-derived state.
   After login lands on /<first-port-by-name>/dashboard, localStorage holds
   that port. Hard-navigating to /port-nimara/... rehydrated the store with
   the stale id, and useQuery fired with the wrong port before
   PortProvider's URL-sync useEffect could correct it. Drop both fields
   from partialize — PortProvider re-derives them from the route every
   navigation.

2. apiFetch's slug-to-port fallback fired N parallel /api/v1/admin/ports
   calls when N components mounted simultaneously with an empty store.
   Dedupe in-flight lookups so a stampede collapses into one round-trip.

Also tightened four flaky smoke tests that depended on a fixed 3s wait or
non-waiting isVisible({timeout}) — replaced with expect(...).toBeVisible
or expect.poll so they handle dev-mode JIT cold-start delays cleanly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Ciaccio
2026-04-28 04:38:57 +02:00
parent 259cd7b8bb
commit 0406778c44
6 changed files with 74 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tests/e2e/smoke/03-pipeline.spec.ts
View File

@@ -1,5 +1,5 @@
import { test, expect } from '@playwright/test';
import { login, navigateTo, waitForSheet, PORT_SLUG } from './helpers';
import { login, navigateTo, waitForSheet } from './helpers';
test.describe('Interest Pipeline', () => {
test.beforeEach(async ({ page }) => {
@@ -9,7 +9,10 @@ test.describe('Interest Pipeline', () => {
test('create a client and interest', async ({ page }) => {
// First create a client
await navigateTo(page, '/clients');
await page.getByRole('button', { name: /new client/i }).first().click();
await page
.getByRole('button', { name: /new client/i })
.first()
.click();
await waitForSheet(page);
const clientName = `Pipeline Client ${Date.now()}`;
@@ -76,16 +79,31 @@ test.describe('Interest Pipeline', () => {
test('interests page loads with data', async ({ page }) => {
await navigateTo(page, '/interests');
await page.waitForLoadState('networkidle');
await page.waitForTimeout(3000);
// Should see interests page content
const heading = page.getByText(/interests/i).first();
await expect(heading).toBeVisible({ timeout: 10_000 });
await expect(heading).toBeVisible({ timeout: 15_000 });
// Check for table or board view
const hasTable = await page.locator('table').isVisible({ timeout: 3_000 }).catch(() => false);
const hasBoard = await page.getByText(/open|board|kanban/i).isVisible({ timeout: 3_000 }).catch(() => false);
expect(hasTable || hasBoard).toBeTruthy();
// Wait for either the table or pipeline board to render (dev-mode JIT can
// take >3s on first hit). `isVisible()` is non-waiting; use `expect.poll`
// to actually wait for one of the views to appear.
await expect
.poll(
async () => {
const table = await page
.locator('table')
.isVisible()
.catch(() => false);
const board = await page
.locator('[data-testid="pipeline-board"], [class*="board"]')
.first()
.isVisible()
.catch(() => false);
return table || board;
},
{ timeout: 15_000 },
)
.toBe(true);
});
test('interest detail page works', async ({ page }) => {