fix(api): kill currentPortId persist race + dedupe admin/ports stampede
The dashboard and residential interest smoke tests were intermittently
failing with the page rendering empty/skeleton state. Root causes:
1. ui-store persisted currentPortId/Slug, but those are URL-derived state.
After login lands on /<first-port-by-name>/dashboard, localStorage holds
that port. Hard-navigating to /port-nimara/... rehydrated the store with
the stale id, and useQuery fired with the wrong port before
PortProvider's URL-sync useEffect could correct it. Drop both fields
from partialize — PortProvider re-derives them from the route every
navigation.
2. apiFetch's slug-to-port fallback fired N parallel /api/v1/admin/ports
calls when N components mounted simultaneously with an empty store.
Dedupe in-flight lookups so a stampede collapses into one round-trip.
Also tightened four flaky smoke tests that depended on a fixed 3s wait or
non-waiting isVisible({timeout}) — replaced with expect(...).toBeVisible
or expect.poll so they handle dev-mode JIT cold-start delays cleanly.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -24,10 +24,12 @@ export const useUIStore = create<UIStore>()(
|
||||
}),
|
||||
{
|
||||
name: 'pn-crm-ui',
|
||||
// currentPortId/Slug are URL-derived, not user preferences. PortProvider
|
||||
// re-populates them from the route on every navigation. Persisting them
|
||||
// creates a hydration race where queries fire with a stale port id from
|
||||
// the previous session before the URL-derived effect runs.
|
||||
partialize: (state) => ({
|
||||
sidebarCollapsed: state.sidebarCollapsed,
|
||||
currentPortId: state.currentPortId,
|
||||
currentPortSlug: state.currentPortSlug,
|
||||
darkMode: state.darkMode,
|
||||
}),
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user