2026-05-14 15:24:38 +02:00
|
|
|
'use client';
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* Per-category send-from routing matrix.
|
|
|
|
|
*
|
|
|
|
|
* Renders one row per email category with a `noreply | sales` dropdown.
|
|
|
|
|
* When the port has no sales SMTP credentials configured, the `sales`
|
|
|
|
|
* option is disabled across the board and the card explains why.
|
|
|
|
|
*/
|
|
|
|
|
import { useQuery, useMutation, useQueryClient } from '@tanstack/react-query';
|
|
|
|
|
import { Loader2 } from 'lucide-react';
|
|
|
|
|
import { toast } from 'sonner';
|
|
|
|
|
|
|
|
|
|
import { Button } from '@/components/ui/button';
|
|
|
|
|
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/components/ui/card';
|
|
|
|
|
import {
|
|
|
|
|
Select,
|
|
|
|
|
SelectContent,
|
|
|
|
|
SelectItem,
|
|
|
|
|
SelectTrigger,
|
|
|
|
|
SelectValue,
|
|
|
|
|
} from '@/components/ui/select';
|
|
|
|
|
import { WarningCallout } from '@/components/ui/warning-callout';
|
|
|
|
|
import { apiFetch } from '@/lib/api/client';
|
|
|
|
|
import { toastError } from '@/lib/api/toast-error';
|
|
|
|
|
|
|
|
|
|
type Sender = 'noreply' | 'sales';
|
|
|
|
|
|
|
|
|
|
interface RoutingResponse {
|
|
|
|
|
data: {
|
|
|
|
|
routing: Record<string, Sender>;
|
|
|
|
|
isSalesAvailable: boolean;
|
|
|
|
|
categories: readonly string[];
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const LABELS: Record<string, string> = {
|
|
|
|
|
account_activation: 'Account activation',
|
|
|
|
|
password_reset: 'Password reset',
|
|
|
|
|
notification_digest: 'Notification digest',
|
|
|
|
|
eoi_signing_request: 'EOI signing request',
|
|
|
|
|
reservation_signing_request: 'Reservation signing request',
|
|
|
|
|
contract_signing_request: 'Contract signing request',
|
|
|
|
|
brochure_send: 'Brochure send',
|
|
|
|
|
berth_pdf_send: 'Berth PDF send',
|
|
|
|
|
signed_doc_completion: 'Signed-doc completion',
|
|
|
|
|
sales_sendout: 'Sales send-out',
|
|
|
|
|
manual_compose: 'Manual rep compose',
|
|
|
|
|
inquiry_confirmation: 'Inquiry confirmation (to client)',
|
|
|
|
|
inquiry_sales_notification: 'Inquiry notification (to sales)',
|
|
|
|
|
crm_invite: 'CRM user invite',
|
|
|
|
|
admin_email_change: 'Admin email-change notice',
|
|
|
|
|
gdpr_export: 'GDPR export delivery',
|
|
|
|
|
system_other: 'Other system-generated',
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
export function EmailRoutingCard() {
|
|
|
|
|
const qc = useQueryClient();
|
|
|
|
|
const { data, isLoading, isError } = useQuery<RoutingResponse>({
|
|
|
|
|
queryKey: ['admin', 'email', 'routing'],
|
|
|
|
|
queryFn: () => apiFetch<RoutingResponse>('/api/v1/admin/email/routing'),
|
|
|
|
|
staleTime: 30_000,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const update = useMutation({
|
|
|
|
|
mutationFn: (routing: Record<string, Sender>) =>
|
|
|
|
|
apiFetch<RoutingResponse>('/api/v1/admin/email/routing', {
|
|
|
|
|
method: 'PATCH',
|
fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish
Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 13:28:50 +02:00
|
|
|
body: { routing },
|
2026-05-14 15:24:38 +02:00
|
|
|
}),
|
|
|
|
|
onSuccess: (resp) => {
|
|
|
|
|
qc.setQueryData(['admin', 'email', 'routing'], resp);
|
|
|
|
|
toast.success('Send-from routing saved');
|
|
|
|
|
},
|
|
|
|
|
onError: (err) => toastError(err, 'Failed to save send-from routing'),
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
if (isLoading) {
|
|
|
|
|
return (
|
|
|
|
|
<Card>
|
|
|
|
|
<CardHeader>
|
|
|
|
|
<CardTitle>Send-from routing</CardTitle>
|
|
|
|
|
</CardHeader>
|
|
|
|
|
<CardContent>
|
|
|
|
|
<Loader2 className="size-4 animate-spin" aria-hidden />
|
|
|
|
|
</CardContent>
|
|
|
|
|
</Card>
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (isError || !data) {
|
|
|
|
|
return (
|
|
|
|
|
<Card>
|
|
|
|
|
<CardHeader>
|
|
|
|
|
<CardTitle>Send-from routing</CardTitle>
|
|
|
|
|
</CardHeader>
|
|
|
|
|
<CardContent>
|
|
|
|
|
<p className="text-sm text-muted-foreground">Failed to load routing matrix.</p>
|
|
|
|
|
</CardContent>
|
|
|
|
|
</Card>
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const { routing, isSalesAvailable, categories } = data.data;
|
|
|
|
|
|
|
|
|
|
const setCategory = (category: string, sender: Sender) => {
|
|
|
|
|
update.mutate({ ...routing, [category]: sender });
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
return (
|
|
|
|
|
<Card>
|
|
|
|
|
<CardHeader>
|
|
|
|
|
<CardTitle>Send-from routing</CardTitle>
|
|
|
|
|
<CardDescription>
|
|
|
|
|
Pick which account each email category sends from. Automated traffic typically goes
|
|
|
|
|
through <code className="rounded bg-muted px-1 text-xs">noreply</code>; human-touch
|
|
|
|
|
traffic (brochures, send-outs) goes through{' '}
|
|
|
|
|
<code className="rounded bg-muted px-1 text-xs">sales</code>.
|
|
|
|
|
</CardDescription>
|
|
|
|
|
</CardHeader>
|
|
|
|
|
<CardContent className="space-y-4">
|
|
|
|
|
{!isSalesAvailable ? (
|
|
|
|
|
<WarningCallout>
|
|
|
|
|
<p className="text-sm">
|
2026-05-21 20:02:58 +02:00
|
|
|
Sales sender is disabled - configure SMTP credentials in the "Sales send-from
|
2026-05-14 15:24:38 +02:00
|
|
|
account" card below to enable the <code>sales</code> option.
|
|
|
|
|
</p>
|
|
|
|
|
</WarningCallout>
|
|
|
|
|
) : null}
|
|
|
|
|
<div className="grid grid-cols-1 gap-3 sm:grid-cols-[1fr_180px]">
|
|
|
|
|
{categories.map((cat) => (
|
|
|
|
|
<div
|
|
|
|
|
key={cat}
|
|
|
|
|
className="contents [&>*]:flex [&>*]:items-center [&>*]:border-b [&>*]:border-border [&>*]:py-2"
|
|
|
|
|
>
|
|
|
|
|
<div className="text-sm font-medium">{LABELS[cat] ?? cat}</div>
|
|
|
|
|
<div>
|
|
|
|
|
<Select
|
|
|
|
|
value={routing[cat] ?? 'noreply'}
|
|
|
|
|
onValueChange={(v) => setCategory(cat, v as Sender)}
|
|
|
|
|
disabled={update.isPending}
|
|
|
|
|
>
|
|
|
|
|
<SelectTrigger className="h-9">
|
|
|
|
|
<SelectValue />
|
|
|
|
|
</SelectTrigger>
|
|
|
|
|
<SelectContent>
|
|
|
|
|
<SelectItem value="noreply">noreply</SelectItem>
|
|
|
|
|
<SelectItem value="sales" disabled={!isSalesAvailable}>
|
|
|
|
|
sales {!isSalesAvailable ? '(not configured)' : ''}
|
|
|
|
|
</SelectItem>
|
|
|
|
|
</SelectContent>
|
|
|
|
|
</Select>
|
|
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
))}
|
|
|
|
|
</div>
|
|
|
|
|
<p className="text-xs text-muted-foreground">
|
|
|
|
|
Changes save automatically when you pick a new sender. The <code>sales</code> option falls
|
|
|
|
|
back to <code>noreply</code> at send-time if creds are removed.
|
|
|
|
|
</p>
|
|
|
|
|
{update.isPending ? (
|
|
|
|
|
<div className="flex items-center gap-2 text-xs text-muted-foreground">
|
|
|
|
|
<Loader2 className="size-3 animate-spin" aria-hidden /> Saving…
|
|
|
|
|
</div>
|
|
|
|
|
) : null}
|
|
|
|
|
</CardContent>
|
|
|
|
|
<CardContent className="pt-0">
|
|
|
|
|
<Button
|
|
|
|
|
type="button"
|
|
|
|
|
variant="ghost"
|
|
|
|
|
size="sm"
|
|
|
|
|
onClick={() =>
|
|
|
|
|
update.mutate({
|
|
|
|
|
account_activation: 'noreply',
|
|
|
|
|
password_reset: 'noreply',
|
|
|
|
|
notification_digest: 'noreply',
|
|
|
|
|
eoi_signing_request: 'noreply',
|
|
|
|
|
reservation_signing_request: 'noreply',
|
|
|
|
|
contract_signing_request: 'noreply',
|
|
|
|
|
brochure_send: 'sales',
|
|
|
|
|
berth_pdf_send: 'sales',
|
|
|
|
|
signed_doc_completion: 'sales',
|
|
|
|
|
sales_sendout: 'sales',
|
|
|
|
|
manual_compose: 'sales',
|
|
|
|
|
inquiry_confirmation: 'noreply',
|
|
|
|
|
inquiry_sales_notification: 'noreply',
|
|
|
|
|
crm_invite: 'noreply',
|
|
|
|
|
admin_email_change: 'noreply',
|
|
|
|
|
gdpr_export: 'noreply',
|
|
|
|
|
system_other: 'noreply',
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
disabled={update.isPending}
|
|
|
|
|
>
|
|
|
|
|
Reset to defaults
|
|
|
|
|
</Button>
|
|
|
|
|
</CardContent>
|
|
|
|
|
</Card>
|
|
|
|
|
);
|
|
|
|
|
}
|