Files
pn-new-crm/tests/unit/sales-email-config-validators.test.ts

63 lines
2.1 KiB
TypeScript
Raw Normal View History

feat(emails): sales send-out flows + brochures + email-from settings Phase 7 of the berth-recommender refactor (plan §3.3, §4.8, §4.9, §5.7, §5.8, §5.9, §11.1, §14.7, §14.9). Adds the rep-driven send-out path for per-berth PDFs and port-wide brochures, the per-port sales SMTP/IMAP config + body templates, and the supporting admin UI. Migration: 0031_brochures_and_document_sends.sql Schema additions: - brochures (port-wide, with isDefault marker + archive) - brochure_versions (versioned uploads, storageKey per §4.7a) - document_sends (audit log of every rep-initiated send; failures captured with failedAt + errorReason). berthPdfVersionId is a plain text column (no FK) — loose-coupled to Phase 6b's berth_pdf_versions so the two phases stay independent. §14.7 critical mitigations: - Body XSS: rep-authored markdown goes through renderEmailBody() (HTML-escape first, then a tight allowlist of bold/italic/code/link rules). https:// + mailto: only — javascript:/data: URLs stripped. Tested against script/img/iframe/svg/onerror polyglots. - Recipient typo: strict email regex + two-step confirm modal that shows the exact recipient before send. - Unresolved merge fields: pre-send dry-run /preview endpoint blocks submission until findUnresolvedTokens() returns empty. - SMTP failure: every transport rejection writes a document_sends row with failedAt + errorReason; UI surfaces the message. - Hourly per-user rate limit: 50 sends/user/hour via existing checkRateLimit(). - Size threshold fallback (§11.1): files above email_attach_threshold_mb (default 15) ship as a 24h signed-URL download link in the body instead of an attachment. Storage stream flows directly to nodemailer to avoid buffering 20MB+. §14.10 critical mitigation: - SMTP/IMAP passwords encrypted at rest via the existing EMAIL_CREDENTIAL_KEY (AES-256-GCM). The /api/v1/admin/email/ sales-config GET endpoint never returns the decrypted value — only a *PassIsSet boolean. PATCH treats empty string as "leave unchanged" and explicit null as "clear", so the masked-placeholder UI round- trips without forcing re-entry on every save. system_settings keys (per-port unless noted): - sales_from_address, sales_smtp_{host,port,secure,user,pass_encrypted} - sales_imap_{host,port,user,pass_encrypted} - sales_auth_method (default app_password) - noreply_from_address - email_template_send_berth_pdf_body, email_template_send_brochure_body - brochure_max_upload_mb (default 50) - email_attach_threshold_mb (default 15) UI surfaces (per §5.7, §5.8, §5.9): - <SendDocumentDialog> shared 2-step compose+confirm flow. - <SendBerthPdfDialog>, <SendDocumentsDialog>, <SendFromInterestButton> wrappers per detail page. - /[portSlug]/admin/brochures: list, upload (direct-to-storage presigned PUT for the 20MB+ files per §11.1), default toggle, archive. - /[portSlug]/admin/email extended with <SalesEmailConfigCard>: SMTP + IMAP creds, body templates, threshold/max settings. Storage: every upload + download goes through getStorageBackend() — no direct minio imports, per Phase 6a contract. Tests: 1145 vitest passing (+ 50 new in markdown-email-sanitization.test.ts, document-sends-validators.test.ts, sales-email-config-validators.test.ts). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-05 03:38:47 +02:00
/**
* Phase 7 §14.10 critical mitigation: SMTP/IMAP credential validators.
*
* Validates the API surface of the sales-config update payload: that
* malformed addresses are rejected, that sensible bounds are enforced,
* and that the empty-string-means-unchanged convention is preserved by the
* validator (the service-layer assumption).
*/
import { describe, expect, it } from 'vitest';
import { updateSalesEmailConfigSchema } from '@/lib/validators/sales-email-config';
describe('updateSalesEmailConfigSchema', () => {
it('accepts a fully populated payload', () => {
const r = updateSalesEmailConfigSchema.safeParse({
fromAddress: 'sales@example.com',
smtpHost: 'smtp.example.com',
smtpPort: 587,
smtpSecure: false,
smtpUser: 'sales',
smtpPass: 'secret',
noreplyFromAddress: 'noreply@example.com',
templateBerthPdfBody: 'Hi {{client.fullName}}',
templateBrochureBody: 'Hi {{client.fullName}}',
brochureMaxUploadMb: 50,
emailAttachThresholdMb: 15,
});
expect(r.success).toBe(true);
});
it('accepts empty-string smtpPass (means "leave unchanged")', () => {
const r = updateSalesEmailConfigSchema.safeParse({ smtpPass: '' });
expect(r.success).toBe(true);
});
it('accepts explicit null smtpPass (means "clear")', () => {
const r = updateSalesEmailConfigSchema.safeParse({ smtpPass: null });
expect(r.success).toBe(true);
});
it('rejects malformed from address', () => {
const r = updateSalesEmailConfigSchema.safeParse({ fromAddress: 'not-an-email' });
expect(r.success).toBe(false);
});
it('rejects out-of-range smtp port', () => {
const r = updateSalesEmailConfigSchema.safeParse({ smtpPort: 99999 });
expect(r.success).toBe(false);
});
it('rejects unknown auth method', () => {
const r = updateSalesEmailConfigSchema.safeParse({ authMethod: 'oauth_apple' });
expect(r.success).toBe(false);
});
it('caps body templates at 50KB', () => {
const r = updateSalesEmailConfigSchema.safeParse({
templateBrochureBody: 'x'.repeat(60_000),
});
expect(r.success).toBe(false);
});
});