Files
pn-new-crm/tests/unit/i18n-subdivisions.test.ts

58 lines
2.2 KiB
TypeScript
Raw Normal View History

feat(i18n): country/phone/timezone/subdivision primitives + form wiring Cross-cutting i18n polish for forms across the marina + residential + company domains. Introduces a single source of truth for country/phone/timezone/ subdivision data and replaces every nationality-as-free-text and timezone- as-string Input with a dedicated combobox. PR1 Countries — ALL_COUNTRY_CODES (~250 ISO-3166-1 alpha-2), Intl.DisplayNames for localized labels, detectDefaultCountry() with navigator-region fallback to US, CountryCombobox with regional-indicator flag glyphs + compact mode for inline use. PR2 Phone — libphonenumber-js wrapper (parsePhone / formatAsYouType / callingCodeFor), PhoneInput with flag dropdown + national-format AsYouType + paste-detect that flips the country dropdown for pasted international strings. PR3 Timezones — country->IANA map (250 entries, multi-zone for AU/BR/CA/CD/ ID/KZ/MN/MX/RU/US), formatTimezoneLabel ("Europe/London (UTC+1)"), TimezoneCombobox with Suggested/All grouping driven by countryHint. PR4 Subdivisions — wraps the iso-3166-2 npm package (~5000 ISO 3166-2 codes for every country), per-country cache, SubdivisionCombobox with "Pick a country first" / "No regions available" empty states. PR5 Schema deltas (migration 0015) — clients.nationality_iso, clientContacts {value_e164, value_country}, clientAddresses {country_iso, subdivision_iso}, residentialClients {phone_e164, phone_country, nationality_iso, timezone, place_of_residence_country_iso, subdivision_iso}, companies {incorporation_ country_iso, incorporation_subdivision_iso}, companyAddresses {country_iso, subdivision_iso}. Plus shared zod validators (validators/i18n.ts) used by every entity validator + route handler. PR6 ClientForm + ClientDetail — CountryCombobox replaces nationality Input, TimezoneCombobox replaces timezone Input (driven by nationalityIso hint), PhoneInput conditionally rendered for phone/whatsapp contacts. Inline editors (InlineCountryField / InlineTimezoneField / InlinePhoneField) for the detail-page overview rows + ContactsEditor. PR7 Residential client form + detail — phone -> PhoneInput, nationality/ timezone/place-of-residence-country/subdivision rows in both create sheet and inline-editable detail view. Subdivision wipes when country flips since codes are country-scoped. PR8 Company form + detail — incorporation country -> CountryCombobox, incorporation region -> SubdivisionCombobox in both modes. PR9 Public inquiry endpoint — accepts pre-normalized phoneE164/phoneCountry and i18n fields from newer website builds, server-side parsePhone() fallback for legacy raw-international submissions. Old Nuxt builds keep working unchanged. Tests: 4 unit suites for the primitives (25 tests), 1 integration spec for the public phone-normalization path (3 tests), 1 smoke spec asserting the combobox triggers render in all three create sheets. Test totals: vitest 713 -> 741 (+28). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 18:13:08 +02:00
/**
* i18n PR4 subdivisions.
*
* Validates:
* 1. Major countries (PL, US, CA, GB, AU) return non-empty lists
* 2. Sample known codes resolve to expected names
* 3. hasSubdivisions correctly classifies micro-states with no subs
* 4. Validation rejects garbage codes
* 5. getSubdivisionName returns the human name
*/
import { describe, it, expect } from 'vitest';
import {
subdivisionsForCountry,
hasSubdivisions,
isValidSubdivisionCode,
getSubdivisionName,
} from '@/lib/i18n/subdivisions';
describe('i18n subdivisions', () => {
it('major countries return populated subdivision lists', () => {
expect(subdivisionsForCountry('PL').length).toBeGreaterThanOrEqual(16);
expect(subdivisionsForCountry('US').length).toBeGreaterThanOrEqual(50);
expect(subdivisionsForCountry('CA').length).toBeGreaterThanOrEqual(13);
expect(subdivisionsForCountry('GB').length).toBeGreaterThan(4); // GB has constituent + 200+ admin areas
expect(subdivisionsForCountry('AU').length).toBeGreaterThanOrEqual(8);
});
it('returns sorted-by-name results', () => {
const us = subdivisionsForCountry('US');
const names = us.map((s) => s.name);
const sortedCopy = [...names].sort((a, b) => a.localeCompare(b));
expect(names).toEqual(sortedCopy);
});
it('hasSubdivisions is true for known countries', () => {
expect(hasSubdivisions('US')).toBe(true);
expect(hasSubdivisions('PL')).toBe(true);
expect(hasSubdivisions('GB')).toBe(true);
});
it('isValidSubdivisionCode accepts known codes and rejects junk', () => {
expect(isValidSubdivisionCode('US-CA')).toBe(true);
expect(isValidSubdivisionCode('PL-MZ')).toBe(true);
expect(isValidSubdivisionCode('US-XX')).toBe(false);
expect(isValidSubdivisionCode('GARBAGE')).toBe(false);
expect(isValidSubdivisionCode('')).toBe(false);
});
it('getSubdivisionName returns the human name', () => {
expect(getSubdivisionName('US-CA')).toMatch(/California/);
expect(getSubdivisionName('PL-MZ')).toMatch(/Mazowieckie|Masovian/);
expect(getSubdivisionName('AU-NSW')).toMatch(/New South Wales/);
// Unknown -> code itself
expect(getSubdivisionName('XX-YY')).toBe('XX-YY');
});
});