Files
pn-new-crm/src/hooks/use-realtime-invalidation.ts

56 lines
2.0 KiB
TypeScript
Raw Normal View History

'use client';
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
import { useEffect, useRef } from 'react';
import { useQueryClient } from '@tanstack/react-query';
import { useSocket } from '@/providers/socket-provider';
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
import { subscribeRealtimeInvalidations, type EventMap } from '@/hooks/realtime-invalidation-core';
// Re-export for convenience so callers don't need to know about the split.
export type { EventMap, SocketLike } from '@/hooks/realtime-invalidation-core';
/**
* Subscribes to socket events and invalidates React Query caches.
*
* Safe to call with an inline-literal `eventMap` - the hook only re-subscribes
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
* when the SET of event keys actually changes (not when the object identity
* changes). The latest query-key list is read at event fire-time via a ref.
*
* @example
* useRealtimeInvalidation({
* 'client:created': [['clients']],
* 'client:updated': [['clients'], ['clients', clientId]],
* 'client:archived': [['clients']],
* });
*/
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
export function useRealtimeInvalidation(eventMap: EventMap) {
const socket = useSocket();
const queryClient = useQueryClient();
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
// Stash the latest map in a ref so handlers always see fresh queryKeys
fix(compiler): React Compiler safety triage — 5 categories cleared Cleared 4 rule buckets (37 violations, including 5 real bugs) and silenced 1 informational bucket from the Next 16 / react-hooks v7 upgrade. Cleared rules promoted from `warn` back to `error` so new regressions block CI. Real bug fixes: - `interest-contact-log-tab.tsx`: `useMemo` used for side effects (5 setState calls inside a memo body); converted to `useEffect`. - `PieChart.tsx`: cumulative `let angle` mutation in a render-phase `map`; converted to `reduce` so the slice array is built without re-assignment. - `documents-hub.tsx`: `useMemo(() => ({ count: 0 }))` used as a mutable drag counter; converted to `useRef`. - `notes-list.tsx`: `Date.now()` read during render for note-edit countdown (impure) → pinned to a `now` state ticked every 30s. - `onboarding-checklist.tsx` / `user-profile.tsx` / `user-settings.tsx`: `useEffect(() => void load(), [])` with the `load` function declared AFTER the effect — relied on hoisting, trips Compiler's "access before declared" rule. Declared inside the effect. Pattern fixes (intentional cache-via-ref → state or layout-effect): - 6 `ref.current = x` writes during render moved into layout effects (`use-realtime-invalidation`, `settings-form-card`, `inbox`). - 3 `ref.current` reads during render (search totals cache, scanner file ref) rewritten to backed-by-state. - `use-is-mobile.ts` rewritten on `useSyncExternalStore` to avoid the SSR-then-rehydrate setState dance. - `use-notifications.ts` rewritten to write socket pushes directly into the React Query cache via `setQueryData`, removing a local state mirror. Rule config (`eslint.config.mjs`): - `react-hooks/purity` → error (was warn, cleared) - `react-hooks/set-state-in-render` → error (was warn, cleared) - `react-hooks/immutability` → error (was warn, cleared) - `react-hooks/refs` → error (was warn, cleared) - `react-hooks/incompatible-library` → off (informational only) - `react-hooks/set-state-in-effect` → warn (51 remaining, all the useEffect→fetch→setState data-fetch pattern; migration to useQuery tracked in BACKLOG) Verified: tsc clean, eslint 0 errors / 69 warnings (down from 105), vitest 1315/1315, next build green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 23:14:16 +02:00
// without re-subscribing. Writing to ref.current during render trips
// the React Compiler purity rules; the equivalent layout-effect
// wiring runs synchronously after commit and is Compiler-safe.
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
const eventMapRef = useRef(eventMap);
fix(compiler): React Compiler safety triage — 5 categories cleared Cleared 4 rule buckets (37 violations, including 5 real bugs) and silenced 1 informational bucket from the Next 16 / react-hooks v7 upgrade. Cleared rules promoted from `warn` back to `error` so new regressions block CI. Real bug fixes: - `interest-contact-log-tab.tsx`: `useMemo` used for side effects (5 setState calls inside a memo body); converted to `useEffect`. - `PieChart.tsx`: cumulative `let angle` mutation in a render-phase `map`; converted to `reduce` so the slice array is built without re-assignment. - `documents-hub.tsx`: `useMemo(() => ({ count: 0 }))` used as a mutable drag counter; converted to `useRef`. - `notes-list.tsx`: `Date.now()` read during render for note-edit countdown (impure) → pinned to a `now` state ticked every 30s. - `onboarding-checklist.tsx` / `user-profile.tsx` / `user-settings.tsx`: `useEffect(() => void load(), [])` with the `load` function declared AFTER the effect — relied on hoisting, trips Compiler's "access before declared" rule. Declared inside the effect. Pattern fixes (intentional cache-via-ref → state or layout-effect): - 6 `ref.current = x` writes during render moved into layout effects (`use-realtime-invalidation`, `settings-form-card`, `inbox`). - 3 `ref.current` reads during render (search totals cache, scanner file ref) rewritten to backed-by-state. - `use-is-mobile.ts` rewritten on `useSyncExternalStore` to avoid the SSR-then-rehydrate setState dance. - `use-notifications.ts` rewritten to write socket pushes directly into the React Query cache via `setQueryData`, removing a local state mirror. Rule config (`eslint.config.mjs`): - `react-hooks/purity` → error (was warn, cleared) - `react-hooks/set-state-in-render` → error (was warn, cleared) - `react-hooks/immutability` → error (was warn, cleared) - `react-hooks/refs` → error (was warn, cleared) - `react-hooks/incompatible-library` → off (informational only) - `react-hooks/set-state-in-effect` → warn (51 remaining, all the useEffect→fetch→setState data-fetch pattern; migration to useQuery tracked in BACKLOG) Verified: tsc clean, eslint 0 errors / 69 warnings (down from 105), vitest 1315/1315, next build green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 23:14:16 +02:00
useEffect(() => {
eventMapRef.current = eventMap;
});
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
// Re-subscribe ONLY when the set of event names changes. Object identity
// of `eventMap` flips on every caller render; the joined key signature
// doesn't.
const eventKeysSig = Object.keys(eventMap).sort().join('|');
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
useEffect(() => {
if (!socket) return;
// eventMapRef is intentionally not in deps - it's a ref; we only want to
fix(realtime): keep socket through reconnects, stop re-subscribe storm Two correctness bugs in the real-time stack — both silent failures, both session-wide once they trigger. (1) `SocketProvider` was setting the React context to null on every `disconnect` event. socket.io's built-in reconnection re-establishes the underlying transport and replays handlers, but the React tree had already lost its reference to the socket — so every `useSocket()` consumer saw null until a session/port change forced a remount. Effect: after the first transient drop (laptop sleep, wifi blip, server restart), realtime invalidation and toasts went dead session-wide with no user-visible signal. Fix: keep the socket reference stable for the lifetime of the session+port, and surface a separate `isConnected` boolean for any UI that wants to render an offline indicator. Exposed as a new `useIsSocketConnected()` hook; `useSocket()` signature is unchanged. (2) `useRealtimeInvalidation` captured `eventMap` as a useEffect dependency. Every caller passes a fresh `{ ... }` object literal on each render, so the effect re-ran every render → `socket.off`/`socket.on` storm on pages with many subscribed events. Fix: extract the subscription logic into a pure helper (`realtime-invalidation-core.ts`, JSX-free for vitest). The hook now keeps the latest map in a ref and only re-subscribes when the SET of event names changes (joined-keys signature, not object identity). The handler reads `ref.current` at fire time, so callers still see fresh queryKey lists without re-binding. Helper is unit-tested with a stub socket: registration count, fire-time map lookup, cleanup deregistration, missing-event safety. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-02 23:11:52 +02:00
// re-run when the socket, queryClient, or the event-key SET changes.
return subscribeRealtimeInvalidations(
socket,
eventKeysSig.length > 0 ? eventKeysSig.split('|') : [],
queryClient,
() => eventMapRef.current,
);
}, [socket, queryClient, eventKeysSig]);
}