Files
pn-new-crm/src/components/companies/add-membership-dialog.tsx

230 lines
6.7 KiB
TypeScript
Raw Normal View History

'use client';
import { useEffect, useState } from 'react';
feat(forms): migrate remaining native date inputs to <DatePicker> / <DateTimePicker> Sweeps the last ~17 native `<Input type="date"|"datetime-local">` call sites onto the shared `<DatePicker>` / `<DateTimePicker>` primitives so date entry is uniform across the app (calendar popover on desktop, native OS picker on mobile via the primitive's viewport-aware fallback). Three patterns handled: 1. Controlled value/onChange — direct swap to <DatePicker value/onChange>: audit-log-list.tsx (audit-from / audit-to filters) reports/generate-report-form.tsx (date range) scan/scan-shell.tsx (expense date) reservations/reservation-detail.tsx (end-reservation dialog) shared/filter-bar.tsx ('date' filter variant) 2. RHF `register('field')` pattern — wrapped in <Controller> with field.value/field.onChange bridge. The picker's '' → undefined normalisation kicks in via `field.onChange(v || undefined)`: berths/berth-form.tsx (tenureStartDate + tenureEndDate) reservations/berth-reserve-dialog.tsx (startDate) companies/add-membership-dialog.tsx (startDate) yachts/yacht-transfer-dialog.tsx (effectiveDate) invoices/invoice-detail.tsx (paymentDate) 3. RHF + Date-typed schema — same Controller wrap, plus a Date<->YYYY-MM-DD bridge in the render() since the zod schema coerces these to Date: expenses/expense-form-dialog.tsx (expenseDate) companies/company-form.tsx (incorporationDate) 4. Datetime variants — swapped onto <DateTimePicker>: interests/interest-contact-log-tab.tsx (occurredAt + followUpAt) Skipped because they ARE picker primitives or internal date variants: - ui/date-picker.tsx, ui/date-time-picker.tsx (the primitives) - shared/inline-editable-field.tsx (the InlineEditableField date variant) - dashboard/date-range-picker.tsx (its own popover with min/max gating that doesn't map cleanly onto the shared primitive) Removed now-unused Input imports from four files. Verified: tsc clean, vitest 1448/1448. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-21 20:14:33 +02:00
import { useForm, Controller } from 'react-hook-form';
import { useMutation, useQueryClient } from '@tanstack/react-query';
import { Loader2 } from 'lucide-react';
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from '@/components/ui/dialog';
import { Button } from '@/components/ui/button';
import { Checkbox } from '@/components/ui/checkbox';
import { Input } from '@/components/ui/input';
import { Label } from '@/components/ui/label';
feat(forms): migrate remaining native date inputs to <DatePicker> / <DateTimePicker> Sweeps the last ~17 native `<Input type="date"|"datetime-local">` call sites onto the shared `<DatePicker>` / `<DateTimePicker>` primitives so date entry is uniform across the app (calendar popover on desktop, native OS picker on mobile via the primitive's viewport-aware fallback). Three patterns handled: 1. Controlled value/onChange — direct swap to <DatePicker value/onChange>: audit-log-list.tsx (audit-from / audit-to filters) reports/generate-report-form.tsx (date range) scan/scan-shell.tsx (expense date) reservations/reservation-detail.tsx (end-reservation dialog) shared/filter-bar.tsx ('date' filter variant) 2. RHF `register('field')` pattern — wrapped in <Controller> with field.value/field.onChange bridge. The picker's '' → undefined normalisation kicks in via `field.onChange(v || undefined)`: berths/berth-form.tsx (tenureStartDate + tenureEndDate) reservations/berth-reserve-dialog.tsx (startDate) companies/add-membership-dialog.tsx (startDate) yachts/yacht-transfer-dialog.tsx (effectiveDate) invoices/invoice-detail.tsx (paymentDate) 3. RHF + Date-typed schema — same Controller wrap, plus a Date<->YYYY-MM-DD bridge in the render() since the zod schema coerces these to Date: expenses/expense-form-dialog.tsx (expenseDate) companies/company-form.tsx (incorporationDate) 4. Datetime variants — swapped onto <DateTimePicker>: interests/interest-contact-log-tab.tsx (occurredAt + followUpAt) Skipped because they ARE picker primitives or internal date variants: - ui/date-picker.tsx, ui/date-time-picker.tsx (the primitives) - shared/inline-editable-field.tsx (the InlineEditableField date variant) - dashboard/date-range-picker.tsx (its own popover with min/max gating that doesn't map cleanly onto the shared primitive) Removed now-unused Input imports from four files. Verified: tsc clean, vitest 1448/1448. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-21 20:14:33 +02:00
import { DatePicker } from '@/components/ui/date-picker';
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from '@/components/ui/select';
import { Textarea } from '@/components/ui/textarea';
import { ClientPicker } from '@/components/shared/client-picker';
import { apiFetch } from '@/lib/api/client';
import { ROLES } from '@/lib/validators/company-memberships';
type RoleEnum = (typeof ROLES)[number];
type FormValues = {
clientId: string | null;
role: RoleEnum;
roleDetail?: string;
startDate: string; // YYYY-MM-DD
isPrimary: boolean;
notes?: string;
};
interface AddMembershipDialogProps {
open: boolean;
onOpenChange: (open: boolean) => void;
companyId: string;
}
const todayIso = (): string => new Date().toISOString().slice(0, 10);
const ROLE_LABEL: Record<RoleEnum, string> = {
director: 'Director',
officer: 'Officer',
broker: 'Broker',
representative: 'Representative',
legal_counsel: 'Legal counsel',
employee: 'Employee',
shareholder: 'Shareholder',
other: 'Other',
};
export function AddMembershipDialog({ open, onOpenChange, companyId }: AddMembershipDialogProps) {
const queryClient = useQueryClient();
const [formError, setFormError] = useState<string | null>(null);
const {
register,
handleSubmit,
watch,
setValue,
reset,
feat(forms): migrate remaining native date inputs to <DatePicker> / <DateTimePicker> Sweeps the last ~17 native `<Input type="date"|"datetime-local">` call sites onto the shared `<DatePicker>` / `<DateTimePicker>` primitives so date entry is uniform across the app (calendar popover on desktop, native OS picker on mobile via the primitive's viewport-aware fallback). Three patterns handled: 1. Controlled value/onChange — direct swap to <DatePicker value/onChange>: audit-log-list.tsx (audit-from / audit-to filters) reports/generate-report-form.tsx (date range) scan/scan-shell.tsx (expense date) reservations/reservation-detail.tsx (end-reservation dialog) shared/filter-bar.tsx ('date' filter variant) 2. RHF `register('field')` pattern — wrapped in <Controller> with field.value/field.onChange bridge. The picker's '' → undefined normalisation kicks in via `field.onChange(v || undefined)`: berths/berth-form.tsx (tenureStartDate + tenureEndDate) reservations/berth-reserve-dialog.tsx (startDate) companies/add-membership-dialog.tsx (startDate) yachts/yacht-transfer-dialog.tsx (effectiveDate) invoices/invoice-detail.tsx (paymentDate) 3. RHF + Date-typed schema — same Controller wrap, plus a Date<->YYYY-MM-DD bridge in the render() since the zod schema coerces these to Date: expenses/expense-form-dialog.tsx (expenseDate) companies/company-form.tsx (incorporationDate) 4. Datetime variants — swapped onto <DateTimePicker>: interests/interest-contact-log-tab.tsx (occurredAt + followUpAt) Skipped because they ARE picker primitives or internal date variants: - ui/date-picker.tsx, ui/date-time-picker.tsx (the primitives) - shared/inline-editable-field.tsx (the InlineEditableField date variant) - dashboard/date-range-picker.tsx (its own popover with min/max gating that doesn't map cleanly onto the shared primitive) Removed now-unused Input imports from four files. Verified: tsc clean, vitest 1448/1448. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-21 20:14:33 +02:00
control,
formState: { errors, isSubmitting },
} = useForm<FormValues>({
defaultValues: {
clientId: null,
role: 'director',
roleDetail: '',
startDate: todayIso(),
isPrimary: false,
notes: '',
},
});
useEffect(() => {
if (open) {
setFormError(null);
reset({
clientId: null,
role: 'director',
roleDetail: '',
startDate: todayIso(),
isPrimary: false,
notes: '',
});
}
}, [open, reset]);
const clientId = watch('clientId');
const role = watch('role');
const isPrimary = watch('isPrimary');
const mutation = useMutation({
mutationFn: async (data: FormValues) => {
if (!data.clientId) {
throw new Error('Please select a client');
}
await apiFetch(`/api/v1/companies/${companyId}/members`, {
method: 'POST',
body: {
clientId: data.clientId,
role: data.role,
roleDetail: data.roleDetail?.trim() || undefined,
startDate: data.startDate,
isPrimary: data.isPrimary,
notes: data.notes?.trim() || undefined,
},
});
},
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['companies', companyId, 'members'] });
onOpenChange(false);
},
onError: (err: unknown) => {
let msg = err instanceof Error ? err.message : 'Failed to add membership';
// Detect 409 - service returns a "membership already exists" message
if (/already exists/i.test(msg)) {
msg = 'This membership already exists (same client + role + start date).';
}
setFormError(msg);
},
});
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="max-w-md">
<DialogHeader>
<DialogTitle>Add member</DialogTitle>
<DialogDescription>
Associate a client with this company in a specific role.
</DialogDescription>
</DialogHeader>
<form
onSubmit={handleSubmit((data) => {
setFormError(null);
mutation.mutate(data);
})}
className="space-y-4"
>
<div className="space-y-2">
<Label>Client</Label>
<ClientPicker value={clientId} onChange={(id) => setValue('clientId', id)} />
{!clientId && errors.clientId && <p className="text-xs text-destructive">Required</p>}
</div>
<div className="space-y-2">
<Label>Role</Label>
<Select value={role} onValueChange={(v) => setValue('role', v as RoleEnum)}>
<SelectTrigger>
<SelectValue />
</SelectTrigger>
<SelectContent>
{ROLES.map((r) => (
<SelectItem key={r} value={r}>
{ROLE_LABEL[r]}
</SelectItem>
))}
</SelectContent>
</Select>
</div>
<div className="space-y-2">
<Label htmlFor="roleDetail">Role detail (optional)</Label>
<Input
id="roleDetail"
{...register('roleDetail')}
placeholder="e.g. Chief Investment Officer"
/>
</div>
<div className="space-y-2">
<Label htmlFor="startDate">Start date</Label>
feat(forms): migrate remaining native date inputs to <DatePicker> / <DateTimePicker> Sweeps the last ~17 native `<Input type="date"|"datetime-local">` call sites onto the shared `<DatePicker>` / `<DateTimePicker>` primitives so date entry is uniform across the app (calendar popover on desktop, native OS picker on mobile via the primitive's viewport-aware fallback). Three patterns handled: 1. Controlled value/onChange — direct swap to <DatePicker value/onChange>: audit-log-list.tsx (audit-from / audit-to filters) reports/generate-report-form.tsx (date range) scan/scan-shell.tsx (expense date) reservations/reservation-detail.tsx (end-reservation dialog) shared/filter-bar.tsx ('date' filter variant) 2. RHF `register('field')` pattern — wrapped in <Controller> with field.value/field.onChange bridge. The picker's '' → undefined normalisation kicks in via `field.onChange(v || undefined)`: berths/berth-form.tsx (tenureStartDate + tenureEndDate) reservations/berth-reserve-dialog.tsx (startDate) companies/add-membership-dialog.tsx (startDate) yachts/yacht-transfer-dialog.tsx (effectiveDate) invoices/invoice-detail.tsx (paymentDate) 3. RHF + Date-typed schema — same Controller wrap, plus a Date<->YYYY-MM-DD bridge in the render() since the zod schema coerces these to Date: expenses/expense-form-dialog.tsx (expenseDate) companies/company-form.tsx (incorporationDate) 4. Datetime variants — swapped onto <DateTimePicker>: interests/interest-contact-log-tab.tsx (occurredAt + followUpAt) Skipped because they ARE picker primitives or internal date variants: - ui/date-picker.tsx, ui/date-time-picker.tsx (the primitives) - shared/inline-editable-field.tsx (the InlineEditableField date variant) - dashboard/date-range-picker.tsx (its own popover with min/max gating that doesn't map cleanly onto the shared primitive) Removed now-unused Input imports from four files. Verified: tsc clean, vitest 1448/1448. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-21 20:14:33 +02:00
<Controller
control={control}
name="startDate"
rules={{ required: true }}
render={({ field }) => (
<DatePicker id="startDate" value={field.value ?? ''} onChange={field.onChange} />
)}
/>
{errors.startDate && <p className="text-xs text-destructive">Required</p>}
</div>
<div className="flex items-center gap-2">
<Checkbox
id="isPrimary"
checked={isPrimary}
onCheckedChange={(v) => setValue('isPrimary', v === true)}
/>
<Label htmlFor="isPrimary" className="cursor-pointer">
Set as primary contact
</Label>
</div>
<div className="space-y-2">
<Label htmlFor="notes">Notes (optional)</Label>
<Textarea id="notes" rows={2} {...register('notes')} />
</div>
{formError && <p className="text-sm text-destructive">{formError}</p>}
<DialogFooter>
<Button type="button" variant="outline" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button type="submit" disabled={isSubmitting || mutation.isPending}>
{(isSubmitting || mutation.isPending) && (
<Loader2 className="mr-2 h-4 w-4 animate-spin" aria-hidden />
)}
Add member
</Button>
</DialogFooter>
</form>
</DialogContent>
</Dialog>
);
}