2026-04-24 12:20:40 +02:00
|
|
|
import { describe, it, expect } from 'vitest';
|
|
|
|
|
|
|
|
|
|
import { buildEoiContext } from '@/lib/services/eoi-context';
|
2026-06-19 10:41:42 +02:00
|
|
|
import { setBerthPriceOverride } from '@/lib/services/interest-berths.service';
|
2026-04-24 12:20:40 +02:00
|
|
|
import { makePort, makeClient, makeCompany, makeBerth, makeYacht } from '../../helpers/factories';
|
|
|
|
|
import { db } from '@/lib/db';
|
2026-05-05 02:41:52 +02:00
|
|
|
import {
|
|
|
|
|
interests,
|
|
|
|
|
interestBerths,
|
|
|
|
|
clientContacts,
|
|
|
|
|
clientAddresses,
|
|
|
|
|
companyAddresses,
|
|
|
|
|
} from '@/lib/db/schema';
|
2026-04-24 12:20:40 +02:00
|
|
|
import { ValidationError, NotFoundError } from '@/lib/errors';
|
|
|
|
|
|
|
|
|
|
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
async function insertInterest(args: {
|
|
|
|
|
portId: string;
|
|
|
|
|
clientId: string;
|
|
|
|
|
yachtId?: string | null;
|
|
|
|
|
berthId?: string | null;
|
|
|
|
|
pipelineStage?: string;
|
|
|
|
|
}) {
|
|
|
|
|
const [row] = await db
|
|
|
|
|
.insert(interests)
|
|
|
|
|
.values({
|
|
|
|
|
portId: args.portId,
|
|
|
|
|
clientId: args.clientId,
|
|
|
|
|
yachtId: args.yachtId ?? null,
|
|
|
|
|
pipelineStage: args.pipelineStage ?? 'open',
|
|
|
|
|
})
|
|
|
|
|
.returning();
|
2026-05-05 02:41:52 +02:00
|
|
|
// Plan §3.4: legacy interests.berth_id replaced by the junction. Tests
|
|
|
|
|
// that pass berthId materialise a primary junction row alongside the
|
|
|
|
|
// interest so getPrimaryBerth() resolves it during EOI context build.
|
|
|
|
|
if (args.berthId) {
|
|
|
|
|
await db.insert(interestBerths).values({
|
|
|
|
|
interestId: row!.id,
|
|
|
|
|
berthId: args.berthId,
|
|
|
|
|
isPrimary: true,
|
|
|
|
|
isSpecificInterest: true,
|
|
|
|
|
});
|
|
|
|
|
}
|
2026-04-24 12:20:40 +02:00
|
|
|
return row!;
|
|
|
|
|
}
|
|
|
|
|
|
2026-05-02 03:11:14 +02:00
|
|
|
/**
|
|
|
|
|
* Adds the EOI-required client details (primary email + primary address) so
|
|
|
|
|
* `buildEoiContext` clears its hard gate. Tests that exercise non-EOI-gating
|
|
|
|
|
* behavior should call this once per client they create.
|
|
|
|
|
*/
|
|
|
|
|
async function seedClientEoiPrereqs(args: {
|
|
|
|
|
clientId: string;
|
|
|
|
|
portId: string;
|
|
|
|
|
email?: string;
|
|
|
|
|
street?: string;
|
|
|
|
|
}) {
|
|
|
|
|
await db.insert(clientContacts).values({
|
|
|
|
|
clientId: args.clientId,
|
|
|
|
|
channel: 'email',
|
|
|
|
|
value: args.email ?? `client-${args.clientId.slice(0, 8)}@example.com`,
|
|
|
|
|
isPrimary: true,
|
|
|
|
|
});
|
|
|
|
|
await db.insert(clientAddresses).values({
|
|
|
|
|
clientId: args.clientId,
|
|
|
|
|
portId: args.portId,
|
|
|
|
|
streetAddress: args.street ?? '1 Harbour Way',
|
|
|
|
|
city: 'Anguilla',
|
|
|
|
|
countryIso: 'AI',
|
|
|
|
|
isPrimary: true,
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
2026-04-24 12:20:40 +02:00
|
|
|
// ─── Tests ────────────────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
describe('buildEoiContext', () => {
|
|
|
|
|
it('returns a fully-populated context for a client-owned yacht', async () => {
|
|
|
|
|
const port = await makePort();
|
|
|
|
|
const client = await makeClient({
|
|
|
|
|
portId: port.id,
|
chore(i18n): drop legacy free-text country/nationality columns
Test-data only — no production migration needed (per earlier decision).
Schema is now ISO-only; readers convert ISO codes to localized names where
human-readable output is required (EOI documents, invoices, portal).
Migration 0016 drops:
- clients.nationality
- companies.incorporation_country
- client_addresses.{state_province, country}
- company_addresses.{state_province, country}
Code paths that previously read free-text values now read the ISO column
and pass through `getCountryName()` / `getSubdivisionName()` for rendering.
Document templates ({{client.nationality}}), portal client view, EOI/
reservation-agreement contexts, and invoice billing addresses all updated.
Public yacht-interest endpoint (/api/public/interests) drops the legacy
fields from its insert path and writes ISO codes only. The Zod validators
no longer accept the legacy fields — older website builds posting raw
'incorporationCountry' / 'country' / 'stateProvince' will get 400s.
Server-side phone normalization is unchanged.
Seed data updated to use ISO codes (GB/FR/ES/GR/SE/IT/GH/MC/PA), spread
across continents to keep test fixtures realistic.
Test assertions updated to match the new render shape (e.g.
'United States' not 'US', 'California' not 'CA').
Vitest: 741 -> 741 (unchanged count; assertions updated, no new tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 19:00:57 +02:00
|
|
|
overrides: { fullName: 'Alice Test', nationalityIso: 'US' },
|
2026-04-24 12:20:40 +02:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Insert contacts.
|
|
|
|
|
await db.insert(clientContacts).values([
|
|
|
|
|
{
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
channel: 'email',
|
|
|
|
|
value: 'alice@example.com',
|
|
|
|
|
isPrimary: true,
|
|
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
channel: 'phone',
|
|
|
|
|
value: '+1-555-1234',
|
|
|
|
|
isPrimary: true,
|
|
|
|
|
},
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
// Insert primary address.
|
|
|
|
|
await db.insert(clientAddresses).values({
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
portId: port.id,
|
|
|
|
|
streetAddress: '1 Harbour Way',
|
|
|
|
|
city: 'Anguilla',
|
chore(i18n): drop legacy free-text country/nationality columns
Test-data only — no production migration needed (per earlier decision).
Schema is now ISO-only; readers convert ISO codes to localized names where
human-readable output is required (EOI documents, invoices, portal).
Migration 0016 drops:
- clients.nationality
- companies.incorporation_country
- client_addresses.{state_province, country}
- company_addresses.{state_province, country}
Code paths that previously read free-text values now read the ISO column
and pass through `getCountryName()` / `getSubdivisionName()` for rendering.
Document templates ({{client.nationality}}), portal client view, EOI/
reservation-agreement contexts, and invoice billing addresses all updated.
Public yacht-interest endpoint (/api/public/interests) drops the legacy
fields from its insert path and writes ISO codes only. The Zod validators
no longer accept the legacy fields — older website builds posting raw
'incorporationCountry' / 'country' / 'stateProvince' will get 400s.
Server-side phone normalization is unchanged.
Seed data updated to use ISO codes (GB/FR/ES/GR/SE/IT/GH/MC/PA), spread
across continents to keep test fixtures realistic.
Test assertions updated to match the new render shape (e.g.
'United States' not 'US', 'California' not 'CA').
Vitest: 741 -> 741 (unchanged count; assertions updated, no new tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 19:00:57 +02:00
|
|
|
countryIso: 'AI',
|
2026-04-24 12:20:40 +02:00
|
|
|
isPrimary: true,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const yacht = await makeYacht({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
ownerType: 'client',
|
|
|
|
|
ownerId: client.id,
|
|
|
|
|
name: 'Sea Breeze',
|
|
|
|
|
overrides: {
|
|
|
|
|
lengthFt: '60',
|
|
|
|
|
widthFt: '20',
|
|
|
|
|
draftFt: '8',
|
|
|
|
|
hullNumber: 'HN-1',
|
|
|
|
|
flag: 'US',
|
|
|
|
|
yearBuilt: 2020,
|
|
|
|
|
},
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const berth = await makeBerth({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
overrides: { mooringNumber: 'M-42', area: 'North', lengthFt: '70' },
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
yachtId: yacht.id,
|
|
|
|
|
berthId: berth.id,
|
|
|
|
|
pipelineStage: 'in_communication',
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const ctx = await buildEoiContext(interest.id, port.id);
|
|
|
|
|
|
chore(i18n): drop legacy free-text country/nationality columns
Test-data only — no production migration needed (per earlier decision).
Schema is now ISO-only; readers convert ISO codes to localized names where
human-readable output is required (EOI documents, invoices, portal).
Migration 0016 drops:
- clients.nationality
- companies.incorporation_country
- client_addresses.{state_province, country}
- company_addresses.{state_province, country}
Code paths that previously read free-text values now read the ISO column
and pass through `getCountryName()` / `getSubdivisionName()` for rendering.
Document templates ({{client.nationality}}), portal client view, EOI/
reservation-agreement contexts, and invoice billing addresses all updated.
Public yacht-interest endpoint (/api/public/interests) drops the legacy
fields from its insert path and writes ISO codes only. The Zod validators
no longer accept the legacy fields — older website builds posting raw
'incorporationCountry' / 'country' / 'stateProvince' will get 400s.
Server-side phone normalization is unchanged.
Seed data updated to use ISO codes (GB/FR/ES/GR/SE/IT/GH/MC/PA), spread
across continents to keep test fixtures realistic.
Test assertions updated to match the new render shape (e.g.
'United States' not 'US', 'California' not 'CA').
Vitest: 741 -> 741 (unchanged count; assertions updated, no new tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 19:00:57 +02:00
|
|
|
// Client assertions. Nationality + address country are rendered as
|
|
|
|
|
// localized names (Intl.DisplayNames) from the ISO codes.
|
2026-04-24 12:20:40 +02:00
|
|
|
expect(ctx.client.fullName).toBe('Alice Test');
|
chore(i18n): drop legacy free-text country/nationality columns
Test-data only — no production migration needed (per earlier decision).
Schema is now ISO-only; readers convert ISO codes to localized names where
human-readable output is required (EOI documents, invoices, portal).
Migration 0016 drops:
- clients.nationality
- companies.incorporation_country
- client_addresses.{state_province, country}
- company_addresses.{state_province, country}
Code paths that previously read free-text values now read the ISO column
and pass through `getCountryName()` / `getSubdivisionName()` for rendering.
Document templates ({{client.nationality}}), portal client view, EOI/
reservation-agreement contexts, and invoice billing addresses all updated.
Public yacht-interest endpoint (/api/public/interests) drops the legacy
fields from its insert path and writes ISO codes only. The Zod validators
no longer accept the legacy fields — older website builds posting raw
'incorporationCountry' / 'country' / 'stateProvince' will get 400s.
Server-side phone normalization is unchanged.
Seed data updated to use ISO codes (GB/FR/ES/GR/SE/IT/GH/MC/PA), spread
across continents to keep test fixtures realistic.
Test assertions updated to match the new render shape (e.g.
'United States' not 'US', 'California' not 'CA').
Vitest: 741 -> 741 (unchanged count; assertions updated, no new tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 19:00:57 +02:00
|
|
|
expect(ctx.client.nationality).toBe('United States');
|
2026-04-24 12:20:40 +02:00
|
|
|
expect(ctx.client.primaryEmail).toBe('alice@example.com');
|
|
|
|
|
expect(ctx.client.primaryPhone).toBe('+1-555-1234');
|
|
|
|
|
expect(ctx.client.address).toEqual({
|
|
|
|
|
street: '1 Harbour Way',
|
|
|
|
|
city: 'Anguilla',
|
fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish
Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 13:28:50 +02:00
|
|
|
subdivision: '',
|
|
|
|
|
postalCode: '',
|
chore(i18n): drop legacy free-text country/nationality columns
Test-data only — no production migration needed (per earlier decision).
Schema is now ISO-only; readers convert ISO codes to localized names where
human-readable output is required (EOI documents, invoices, portal).
Migration 0016 drops:
- clients.nationality
- companies.incorporation_country
- client_addresses.{state_province, country}
- company_addresses.{state_province, country}
Code paths that previously read free-text values now read the ISO column
and pass through `getCountryName()` / `getSubdivisionName()` for rendering.
Document templates ({{client.nationality}}), portal client view, EOI/
reservation-agreement contexts, and invoice billing addresses all updated.
Public yacht-interest endpoint (/api/public/interests) drops the legacy
fields from its insert path and writes ISO codes only. The Zod validators
no longer accept the legacy fields — older website builds posting raw
'incorporationCountry' / 'country' / 'stateProvince' will get 400s.
Server-side phone normalization is unchanged.
Seed data updated to use ISO codes (GB/FR/ES/GR/SE/IT/GH/MC/PA), spread
across continents to keep test fixtures realistic.
Test assertions updated to match the new render shape (e.g.
'United States' not 'US', 'California' not 'CA').
Vitest: 741 -> 741 (unchanged count; assertions updated, no new tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 19:00:57 +02:00
|
|
|
country: 'Anguilla',
|
fix(audit): comprehensive 2026-05-15 audit fix wave + Documenso v2 polish
Bundles the prior session's 50-task fix sweep (Documenso v2 + EOI/signing-
progress redesign + env-to-admin migration + dev-mode banner) with the
2026-05-18 audit fix wave (3 CRITICAL, 14 HIGH, 28 MEDIUM, 6 LOW).
CRITICAL (3):
- C-01 interest-berths INNER JOIN -> LEFT JOIN so hard-deleted berths
no longer silently drop interest links
- C-02 /setup added to PUBLIC_PATHS; fresh-deploy bootstrap loop fixed
- C-03 generic PATCH /interests/[id] no longer accepts pipelineStage —
callers must go through /stage with the override-guard chain
HIGH (14/15):
- H-01 explicit ON DELETE on previously-implicit NO ACTION FKs across
interests/documents/reservations/reminders/invoices (migration 0070)
- H-02 login page reads ?redirect= param with same-origin guard
- H-03 CRM invite token moves to URL fragment so it never lands in
nginx access logs / Referer headers
- H-04 Retry-After header on sign-in-by-identifier 429 (RFC 6585 §4)
- H-05 toggleAccount writes an audit row
- H-06 upsertSetting masks any value whose key ends with _encrypted
- H-07 archiveClient cascade fires per-interest audit rows
- H-08 createSalesTransporter applies SMTP_TIMEOUTS
- H-09 AppShell stable children — viewport flip across breakpoint no
longer destroys in-progress form drafts
- H-10 portal documents page swaps Unicode glyph status icons for
Lucide CheckCircle2/XCircle/Circle + aria-labels
- H-12 list components swap alert(...) for toast.warning(...)
- H-13 5 icon-only buttons gain aria-label
- H-14 parseBody treats empty bodies as {}
- H-15 admin layout renders a 403 panel instead of silent bounce
- H-11 not applicable — mobile-search-overlay IS a mobile bottom-sheet
MEDIUM (28+):
- M-MT01-05 defense-in-depth port_id/parent-id filters on UPDATE/DELETE
WHEREs across custom-fields, notes (all 6 entity types x update +
delete), client-contacts, yacht ownerClient lookup, webhook reads
- M-D01 documents-hub realtime event-name typo (file:created -> uploaded)
- M-EM01 portal-auth emails thread through portId
- M-EM02 sendEmail accepts cc/bcc params
- M-EM04 notification_digest catalog key
- M-IN01 portal presigned download URLs use 4h TTL
- M-IN02 OpenAI client lazy-instantiated
- M-IN04 stale pdfme refs updated to pdf-lib AcroForm
- M-IN05 umami.testConnection returns tagged union
- M-L01 reservations tenure_type unified with berths
- M-L02 report-generators canonicalize stage values
- M-AU01 audit log placeholder copy fixed
- M-AU04 outcome_set / outcome_cleared distinct audit verbs
- M-NEW-2 activity feed entity name+type separator
- M-R01 portal allowlist narrowed + portal_session backstop in proxy
- M-SC02 companies archived partial index
- M-SC04 audit_logs.searchText documented as DB-managed
- M-S01 storage_s3_access_key_encrypted admin field
- M-U01 audit log empty state uses <EmptyState>
- M-U09 invoice delete dialog -> <AlertDialog>
- M-U10 toast.success on ClientForm + InterestForm create/edit
- M-U11 settings-form-card logo preview alt text
- M-U14 mobile topbar title on clients/yachts/interests/berths
- M-U15 Invoices in mobile More-sheet
LOW (6/8):
- L-AU01 severity defaults for security-relevant verbs
- L-AU02 +13 missing actions in admin audit filter
- L-AU03 +7 missing entity types in admin audit filter
- L-AU04 dead listAuditLogs stubbed
- L-D02 CLAUDE.md Owner-wins chain tightened
Bonus — Document detail polish (#67 partial, 3/6 deliverables):
- state-aware action button per signer
- watcher Add UI with display-name resolution
- cleanSignerName cleanup
Prior session work bundled in:
- Documenso v2 webhook + envelope-ID normalization + sequential signing
- SigningProgress UI redesign (avatars, per-signer state, timestamps)
- env->admin settings registry + RegistryDrivenForm + encrypted creds
- Embedded-signing card + Test connection + setup help
- Dev-mode EMAIL_REDIRECT_TO banner
- Pipeline rules admin page
- Sales email config card
- Audit log details Sheet
- EOI tab: Finalising badge, absolute timestamps, sequential indicator
- Notes pipeline_stage_at_creation (migration 0069)
- Documenso numeric ID dual-key webhook (migration 0068)
- Dimensions criterion copy (migration 0067)
Tests: 1374/1374 vitest pass. tsc clean. lint clean.
See docs/AUDIT-FIX-WAVE-2026-05-18.md for the full progress report and
the user-input items still pending.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-18 13:28:50 +02:00
|
|
|
countryIso: 'AI',
|
2026-04-24 12:20:40 +02:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Yacht assertions.
|
2026-05-02 03:11:14 +02:00
|
|
|
expect(ctx.yacht?.name).toBe('Sea Breeze');
|
|
|
|
|
expect(ctx.yacht?.hullNumber).toBe('HN-1');
|
|
|
|
|
expect(ctx.yacht?.yearBuilt).toBe(2020);
|
2026-04-24 12:20:40 +02:00
|
|
|
|
|
|
|
|
// Berth assertions.
|
2026-05-02 03:11:14 +02:00
|
|
|
expect(ctx.berth?.mooringNumber).toBe('M-42');
|
|
|
|
|
expect(ctx.berth?.area).toBe('North');
|
2026-04-24 12:20:40 +02:00
|
|
|
|
|
|
|
|
// Interest assertions.
|
|
|
|
|
expect(ctx.interest.stage).toBe('in_communication');
|
|
|
|
|
|
|
|
|
|
// Port assertions.
|
|
|
|
|
expect(ctx.port.name).toBe(port.name);
|
|
|
|
|
expect(ctx.port.defaultCurrency).toBe(port.defaultCurrency);
|
|
|
|
|
|
|
|
|
|
// Date assertions.
|
|
|
|
|
expect(ctx.date.today).toMatch(/^\d{4}-\d{2}-\d{2}$/);
|
|
|
|
|
expect(ctx.date.year).toMatch(/^\d{4}$/);
|
|
|
|
|
|
|
|
|
|
// Owner assertions.
|
|
|
|
|
expect(ctx.owner.type).toBe('client');
|
|
|
|
|
expect(ctx.owner.name).toBe('Alice Test');
|
|
|
|
|
|
|
|
|
|
// Company field.
|
|
|
|
|
expect(ctx.company).toBeNull();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('returns a fully-populated context for a company-owned yacht', async () => {
|
|
|
|
|
const port = await makePort();
|
|
|
|
|
const company = await makeCompany({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
overrides: { name: 'Acme Shipping', legalName: 'Acme Shipping Ltd.' },
|
|
|
|
|
});
|
|
|
|
|
const client = await makeClient({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
overrides: { fullName: 'Bob Contact' },
|
|
|
|
|
});
|
2026-05-02 03:11:14 +02:00
|
|
|
await seedClientEoiPrereqs({ clientId: client.id, portId: port.id });
|
2026-04-24 12:20:40 +02:00
|
|
|
|
|
|
|
|
const yacht = await makeYacht({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
ownerType: 'company',
|
|
|
|
|
ownerId: company.id,
|
|
|
|
|
name: 'Acme Runner',
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const berth = await makeBerth({ portId: port.id });
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
yachtId: yacht.id,
|
|
|
|
|
berthId: berth.id,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const ctx = await buildEoiContext(interest.id, port.id);
|
|
|
|
|
|
|
|
|
|
expect(ctx.owner.type).toBe('company');
|
|
|
|
|
expect(ctx.owner.name).toBe('Acme Shipping');
|
|
|
|
|
expect(ctx.owner.legalName).toBe('Acme Shipping Ltd.');
|
|
|
|
|
expect(ctx.company).not.toBeNull();
|
|
|
|
|
expect(ctx.company!.name).toBe('Acme Shipping');
|
|
|
|
|
expect(ctx.company!.legalName).toBe('Acme Shipping Ltd.');
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('includes company billingAddress when company has a primary address', async () => {
|
|
|
|
|
const port = await makePort();
|
|
|
|
|
const company = await makeCompany({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
overrides: { name: 'Billing Co' },
|
|
|
|
|
});
|
|
|
|
|
await db.insert(companyAddresses).values({
|
|
|
|
|
companyId: company.id,
|
|
|
|
|
portId: port.id,
|
|
|
|
|
streetAddress: '99 Commerce St',
|
|
|
|
|
city: 'Valley',
|
chore(i18n): drop legacy free-text country/nationality columns
Test-data only — no production migration needed (per earlier decision).
Schema is now ISO-only; readers convert ISO codes to localized names where
human-readable output is required (EOI documents, invoices, portal).
Migration 0016 drops:
- clients.nationality
- companies.incorporation_country
- client_addresses.{state_province, country}
- company_addresses.{state_province, country}
Code paths that previously read free-text values now read the ISO column
and pass through `getCountryName()` / `getSubdivisionName()` for rendering.
Document templates ({{client.nationality}}), portal client view, EOI/
reservation-agreement contexts, and invoice billing addresses all updated.
Public yacht-interest endpoint (/api/public/interests) drops the legacy
fields from its insert path and writes ISO codes only. The Zod validators
no longer accept the legacy fields — older website builds posting raw
'incorporationCountry' / 'country' / 'stateProvince' will get 400s.
Server-side phone normalization is unchanged.
Seed data updated to use ISO codes (GB/FR/ES/GR/SE/IT/GH/MC/PA), spread
across continents to keep test fixtures realistic.
Test assertions updated to match the new render shape (e.g.
'United States' not 'US', 'California' not 'CA').
Vitest: 741 -> 741 (unchanged count; assertions updated, no new tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 19:00:57 +02:00
|
|
|
countryIso: 'AI',
|
2026-04-24 12:20:40 +02:00
|
|
|
isPrimary: true,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const client = await makeClient({ portId: port.id });
|
2026-05-02 03:11:14 +02:00
|
|
|
await seedClientEoiPrereqs({ clientId: client.id, portId: port.id });
|
2026-04-24 12:20:40 +02:00
|
|
|
const yacht = await makeYacht({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
ownerType: 'company',
|
|
|
|
|
ownerId: company.id,
|
|
|
|
|
});
|
|
|
|
|
const berth = await makeBerth({ portId: port.id });
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
yachtId: yacht.id,
|
|
|
|
|
berthId: berth.id,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const ctx = await buildEoiContext(interest.id, port.id);
|
|
|
|
|
|
|
|
|
|
expect(ctx.company).not.toBeNull();
|
|
|
|
|
expect(ctx.company!.billingAddress).not.toBeNull();
|
|
|
|
|
expect(ctx.company!.billingAddress).toContain('99 Commerce St');
|
|
|
|
|
expect(ctx.company!.billingAddress).toContain('Valley');
|
chore(i18n): drop legacy free-text country/nationality columns
Test-data only — no production migration needed (per earlier decision).
Schema is now ISO-only; readers convert ISO codes to localized names where
human-readable output is required (EOI documents, invoices, portal).
Migration 0016 drops:
- clients.nationality
- companies.incorporation_country
- client_addresses.{state_province, country}
- company_addresses.{state_province, country}
Code paths that previously read free-text values now read the ISO column
and pass through `getCountryName()` / `getSubdivisionName()` for rendering.
Document templates ({{client.nationality}}), portal client view, EOI/
reservation-agreement contexts, and invoice billing addresses all updated.
Public yacht-interest endpoint (/api/public/interests) drops the legacy
fields from its insert path and writes ISO codes only. The Zod validators
no longer accept the legacy fields — older website builds posting raw
'incorporationCountry' / 'country' / 'stateProvince' will get 400s.
Server-side phone normalization is unchanged.
Seed data updated to use ISO codes (GB/FR/ES/GR/SE/IT/GH/MC/PA), spread
across continents to keep test fixtures realistic.
Test assertions updated to match the new render shape (e.g.
'United States' not 'US', 'California' not 'CA').
Vitest: 741 -> 741 (unchanged count; assertions updated, no new tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 19:00:57 +02:00
|
|
|
// Country is rendered as the localized name (AI -> Anguilla).
|
|
|
|
|
expect(ctx.company!.billingAddress).toContain('Anguilla');
|
2026-04-24 12:20:40 +02:00
|
|
|
});
|
|
|
|
|
|
2026-05-02 03:11:14 +02:00
|
|
|
it('builds a valid context when yacht is missing (Section 3 left blank)', async () => {
|
2026-04-24 12:20:40 +02:00
|
|
|
const port = await makePort();
|
|
|
|
|
const client = await makeClient({ portId: port.id });
|
2026-05-02 03:11:14 +02:00
|
|
|
await seedClientEoiPrereqs({ clientId: client.id, portId: port.id });
|
2026-04-24 12:20:40 +02:00
|
|
|
const berth = await makeBerth({ portId: port.id });
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
yachtId: null,
|
|
|
|
|
berthId: berth.id,
|
|
|
|
|
});
|
|
|
|
|
|
2026-05-02 03:11:14 +02:00
|
|
|
const ctx = await buildEoiContext(interest.id, port.id);
|
|
|
|
|
expect(ctx.yacht).toBeNull();
|
|
|
|
|
expect(ctx.berth?.mooringNumber).toBe(berth.mooringNumber);
|
|
|
|
|
// Owner falls back to the interest's client when no yacht is linked.
|
|
|
|
|
expect(ctx.owner.type).toBe('client');
|
|
|
|
|
expect(ctx.owner.name).toBe(client.fullName);
|
2026-04-24 12:20:40 +02:00
|
|
|
});
|
|
|
|
|
|
2026-05-02 03:11:14 +02:00
|
|
|
it('builds a valid context when berth is missing (Section 3 left blank)', async () => {
|
2026-04-24 12:20:40 +02:00
|
|
|
const port = await makePort();
|
|
|
|
|
const client = await makeClient({ portId: port.id });
|
2026-05-02 03:11:14 +02:00
|
|
|
await seedClientEoiPrereqs({ clientId: client.id, portId: port.id });
|
2026-04-24 12:20:40 +02:00
|
|
|
const yacht = await makeYacht({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
ownerType: 'client',
|
|
|
|
|
ownerId: client.id,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
yachtId: yacht.id,
|
|
|
|
|
berthId: null,
|
|
|
|
|
});
|
|
|
|
|
|
2026-05-02 03:11:14 +02:00
|
|
|
const ctx = await buildEoiContext(interest.id, port.id);
|
|
|
|
|
expect(ctx.berth).toBeNull();
|
|
|
|
|
expect(ctx.yacht?.name).toBe(yacht.name);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('throws ValidationError when client has no email', async () => {
|
|
|
|
|
const port = await makePort();
|
|
|
|
|
const client = await makeClient({ portId: port.id });
|
chore(autonomous-session): consolidate uncommitted work from prior session
Bundles the prior autonomous-session output that was sitting unstaged:
- Em-dash sweep across src/ + tests/ (en-dash/em-dash to hyphen, ~2280 instances)
- country-flag-icons rollout (CountryFlag component, replaces emoji glyphs that
never rendered on Windows; lazy-loads the 3x2 SVG index as a single chunk
after the per-subpath dynamic-import approach silently failed in webpack)
- Admin IA Phase 1+2: 7-domain regroup, 41 to 38 pages, /admin/berths index,
redirects (ocr to ai, reports to dashboard, invitations to users),
docs/admin-ia-proposal.md
- Per-template email tester (registry + endpoint + UI on Email admin page)
- Cancel-document mode picker (delete-from-Documenso vs keep-for-audit)
- Dashboard PDF report: 25 widgets, SVG charts, date-range picker, 11 resolvers
- Customize-widgets per-region sortables at xl+ (charts/rails/feed); single
flat sortable below xl when the layout stacks; per-viewport saved orders
- Audit doc updates capturing each shipped item
- Lint fixes: react-compiler immutability in DonutChart (reduce instead of
let-reassign), set-state-in-effect disables in CountryFlag and
UploadForSigning preview-bytes effect, unused 'confirm' destructures in
interest contract + reservation tabs, unescaped apostrophe in test-template
card copy
2026-05-23 00:52:59 +02:00
|
|
|
// Address only, no email - gate should fail.
|
2026-05-02 03:11:14 +02:00
|
|
|
await db.insert(clientAddresses).values({
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
portId: port.id,
|
|
|
|
|
streetAddress: '1 Harbour Way',
|
|
|
|
|
city: 'Anguilla',
|
|
|
|
|
countryIso: 'AI',
|
|
|
|
|
isPrimary: true,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({ portId: port.id, clientId: client.id });
|
|
|
|
|
|
|
|
|
|
await expect(buildEoiContext(interest.id, port.id)).rejects.toThrow(ValidationError);
|
|
|
|
|
await expect(buildEoiContext(interest.id, port.id)).rejects.toThrow(/client email/i);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('throws ValidationError when client has no primary address', async () => {
|
|
|
|
|
const port = await makePort();
|
|
|
|
|
const client = await makeClient({ portId: port.id });
|
chore(autonomous-session): consolidate uncommitted work from prior session
Bundles the prior autonomous-session output that was sitting unstaged:
- Em-dash sweep across src/ + tests/ (en-dash/em-dash to hyphen, ~2280 instances)
- country-flag-icons rollout (CountryFlag component, replaces emoji glyphs that
never rendered on Windows; lazy-loads the 3x2 SVG index as a single chunk
after the per-subpath dynamic-import approach silently failed in webpack)
- Admin IA Phase 1+2: 7-domain regroup, 41 to 38 pages, /admin/berths index,
redirects (ocr to ai, reports to dashboard, invitations to users),
docs/admin-ia-proposal.md
- Per-template email tester (registry + endpoint + UI on Email admin page)
- Cancel-document mode picker (delete-from-Documenso vs keep-for-audit)
- Dashboard PDF report: 25 widgets, SVG charts, date-range picker, 11 resolvers
- Customize-widgets per-region sortables at xl+ (charts/rails/feed); single
flat sortable below xl when the layout stacks; per-viewport saved orders
- Audit doc updates capturing each shipped item
- Lint fixes: react-compiler immutability in DonutChart (reduce instead of
let-reassign), set-state-in-effect disables in CountryFlag and
UploadForSigning preview-bytes effect, unused 'confirm' destructures in
interest contract + reservation tabs, unescaped apostrophe in test-template
card copy
2026-05-23 00:52:59 +02:00
|
|
|
// Email only, no address - gate should fail.
|
2026-05-02 03:11:14 +02:00
|
|
|
await db.insert(clientContacts).values({
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
channel: 'email',
|
|
|
|
|
value: 'test@example.com',
|
|
|
|
|
isPrimary: true,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({ portId: port.id, clientId: client.id });
|
|
|
|
|
|
2026-04-24 12:20:40 +02:00
|
|
|
await expect(buildEoiContext(interest.id, port.id)).rejects.toThrow(ValidationError);
|
2026-05-02 03:11:14 +02:00
|
|
|
await expect(buildEoiContext(interest.id, port.id)).rejects.toThrow(/client address/i);
|
2026-04-24 12:20:40 +02:00
|
|
|
});
|
|
|
|
|
|
2026-06-19 10:41:42 +02:00
|
|
|
it('renders the deal-specific override price for the primary berth', async () => {
|
|
|
|
|
const port = await makePort();
|
|
|
|
|
const client = await makeClient({ portId: port.id });
|
|
|
|
|
await seedClientEoiPrereqs({ clientId: client.id, portId: port.id });
|
|
|
|
|
const berth = await makeBerth({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
overrides: { mooringNumber: 'P-1', price: '3880800', priceCurrency: 'USD' },
|
|
|
|
|
});
|
|
|
|
|
const interest = await insertInterest({
|
|
|
|
|
portId: port.id,
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
berthId: berth.id,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Base list price flows through first.
|
|
|
|
|
let ctx = await buildEoiContext(interest.id, port.id);
|
|
|
|
|
expect(ctx.berth?.price).toBe('3880800');
|
|
|
|
|
expect(ctx.berth?.priceCurrency).toBe('USD');
|
|
|
|
|
|
|
|
|
|
// The deal-specific override supersedes the list price for this interest.
|
|
|
|
|
await setBerthPriceOverride(interest.id, berth.id, 1500000, 'EUR', port.id);
|
|
|
|
|
ctx = await buildEoiContext(interest.id, port.id);
|
|
|
|
|
expect(ctx.berth?.price).toBe('1500000');
|
|
|
|
|
expect(ctx.berth?.priceCurrency).toBe('EUR');
|
|
|
|
|
});
|
|
|
|
|
|
2026-04-24 12:20:40 +02:00
|
|
|
it('throws NotFoundError for non-existent interest', async () => {
|
|
|
|
|
const port = await makePort();
|
|
|
|
|
await expect(buildEoiContext('fake-id', port.id)).rejects.toThrow(NotFoundError);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('is tenant-scoped (interest from different port throws NotFoundError)', async () => {
|
|
|
|
|
const portA = await makePort();
|
|
|
|
|
const portB = await makePort();
|
|
|
|
|
const client = await makeClient({ portId: portA.id });
|
|
|
|
|
const yacht = await makeYacht({
|
|
|
|
|
portId: portA.id,
|
|
|
|
|
ownerType: 'client',
|
|
|
|
|
ownerId: client.id,
|
|
|
|
|
});
|
|
|
|
|
const berth = await makeBerth({ portId: portA.id });
|
|
|
|
|
|
|
|
|
|
const interest = await insertInterest({
|
|
|
|
|
portId: portA.id,
|
|
|
|
|
clientId: client.id,
|
|
|
|
|
yachtId: yacht.id,
|
|
|
|
|
berthId: berth.id,
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await expect(buildEoiContext(interest.id, portB.id)).rejects.toThrow(NotFoundError);
|
|
|
|
|
});
|
|
|
|
|
});
|